Closed (fixed)
Project:
Facebook Connect
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
10 May 2010 at 18:50 UTC
Updated:
22 Jun 2012 at 22:43 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
johngriffin commentedtracking
Comment #2
vectoroc commentedI've created 7.x branch in github, but I did'nt test it. Fbconnect module should be rewritten cause a lot of changes in FB API
Comment #3
johngriffin commentedIs the correct repo - http://github.com/voxpelli/drupal-fbconnect ?
Comment #4
Cheek commentedsubscribing
Comment #5
BenK commentedHi vectoroc,
Thanks for the update. Since you brought up the topic of Facebook API changes, I thought it would be useful to start a discussion of what specific changes need to be incorporated into the module. As I understand it, there are three new aspects to the Facebook API:
1. Social Plugins: Enables developers to easily add user interaction to web pages (e.g., a “Like” button) using an
or a combination of XFBML and FaceBook’s JavaScript SDK. 2. The Open Graph Protocol: Content can be linked with one or more users, across different parts of their profiles, including profile pages, activity streams, news feeds, and even search results. Currently the protocol is implemented by adding several tags to the of a web page. 3. The Graph API: Access to various data objects has been streamlined (https://graph.facebook.com/username). Were you thinking about incorporating these changes or something different? Thanks, BenComment #6
BenK commented@johngriffin: Actually, I think the repo that vectoroc is referring to is here:
http://github.com/vectoroc/fbconnect/tree/7.x
@vetoroc: Are there any maintenance/refactoring tasks that need to be done to the 6.x branch before proceeding with more active development on the 7.x branch?
--Ben
Comment #7
langworthy commented@vectoroc I've forked your repo and have started a little work. As mentioned in my first pull request on github i'm pretty new to github collaboration so please go easy on me. Thanks.
Comment #8
langworthy commentedI was planning on giving a little help getting a module to 7 but I see in http://drupal.org/node/788118 that the 6.x of this needs some love. I'll be working on that for the time being.
Comment #9
ryan.armstrong commentedWould be great to have a D7 version, but I agree, getting the 6x some love is a good idea
Comment #10
vectoroc commentedBenK: I think that new fb api does not belong to facebook connect (and this module). Only things that should be done before D7 porting is bug fixing...
Comment #11
vectoroc commentedBenK: I think that new fb api does not belong to facebook connect (and this module). Only things that should be done before D7 porting is bug fixing...#788118: This module needs to be updated
Comment #12
Cheek commentedAny update? Would be great to have this ready for the first D7 beta..
Comment #13
willmoy commentedTag and sub
Comment #14
nunof commentedsubscribing
Comment #15
zandros commentedsubscribing
Comment #16
gordon commentedsubscribe
Comment #17
shaynl commentedany news about D7 version?
Comment #18
mainpc commentedduplicate post (feel free to delete)
Comment #19
mainpc commentedsubscribing
Comment #20
ramper commentedSubscribing
Comment #21
roam2345 commentedSubscribing
Comment #22
itsmarc commentedsubscribing
Comment #23
jeffl8n commentedsubscribing
Comment #24
int commented+1
Comment #25
Smenzo commentedsubscribing
Comment #26
blackspiraldancer commentedsubscribing, too
Comment #27
gvc commentedwaiting for this module in D7..
Comment #28
dropbydrop commentedany news?
is there any other module or alternative way to do the same job?
Comment #29
kinshuksunil commentedsubscribing
Comment #30
davividal commented@vectoroc: I've just forked your repo on github. How can I help in order to port this module to D7?
Thanks
Comment #31
nunof commentedsubscribing
Comment #32
ConradFlashback commentedsubscribing
Comment #33
vectoroc commented@davividal: see 7.x branch. but porting is'nt started yet
btw this branch is outdated a bit
Comment #34
chevy commentedsubscribing
Comment #35
negatifo commentedsubscribing
Comment #36
discursives commented+1 subscribe
Comment #37
hello@melmcdougall.com commentedsubscribing
Comment #38
pixelsweatshop commentedsub
Comment #39
tim.plunkettI'm working on this actively. I will post a link to my github fork soon.
Comment #40
tim.plunkettGithub was way out of date.
One patch ignores all whitespace changes, for easier readability.
Mostly changes to function signatures, and to DBTNG.
Comment #41
tim.plunkettWas missing a parenthesis. That's what I get for uploading the patch before testing.
Comment #42
venkatd commentedI am really in need of a D7 version of fbconnect. Let me know if I can be of any help.
I am new to the Facebook API and I've just started using D7 but I'm not new to PHP or Drupal.
Comment #43
tim.plunkettComment #44
vectoroc commented@tim.plunkett: github version was most up to date (if I got correctly your thoughts)
I will review your patch as soon as I can
Comment #45
SilviaT commentedsubscribe
Comment #46
vectoroc commented@tim.plunkett: in what order do I apply your patches? or just last one?
Comment #47
tim.plunkettJust the last one, to a CVS chectkout of DRUPAL-6--2.
Comment #48
physicalpatrick commentedsubscribed
Comment #49
achtonsubscribing
Comment #50
n20 commentedsubscribing
Comment #51
eugene_z commentedsubscribing
Comment #52
KirstenLangholz commentedsubscribing
Comment #53
mthart commentedsubscribing
Comment #54
MrVictor commentedsubscribing
Comment #55
Anonymous (not verified) commentedsubscribing
Comment #56
likewhoa commentedsubscribing
Comment #57
tim.plunkettInstead of just subscribing, how about someone review the patch in #41?
Also, keeping the module name in the issue makes it easier to discern in the tracker.
Comment #58
jennifermontes commentedI tried the patch and it's not really working for me. For an anonymous user that's not logged in to the site, I get the following notices:
The last notice, "Undefined variable: closure", is probably caused by adding
print $closureto the end of my template as per the instructions in the README.The module inserted the following HTML into my login block, but no actual active link:
I used patch #41 on the dev version of the Facebook Connect module, and the module is on a clean install of drupal on my local machine. The Application ID and Application Secret were set and the XFBML tags were in place in the html tag at the top of my template. The only thing I'm having doubts about is the "Connect URL" because the settings page never displayed one... I just guessed and used the URL for the root of my site.
Comment #59
mchelensubscribing
Comment #60
scthomps312 commentedsubscribing
Comment #61
Duck Whistle commentedsubscribing
Comment #62
BenK commentedFor those who need a module right away to integrate with Facebook on Drupal 7, you should check out the Janrain Engage module (http://drupal.org/project/rpx). There's already been one stable release for D7 and the development of new features is proceeding very quickly.
The Janrain Engage module supports integration with Facebook, Twitter, Myspace, Google, Yahoo!, and many other identity providers. (Currently, 18 different social networks and service providers are supported.) You can also choose to just use the Facebook integration features if you prefer.
The great thing about the module is that both authentication (logging in) and social sharing (posting content back to your social network) is supported if you enable those features.
Cheers,
Ben
Comment #63
philberndt commentedsubscribing
Comment #64
ryne.andal commentedsubscribing
Comment #65
itspriyank commentedsubscribing
Comment #66
h4ck3rm1k3 commentedSubscribing, will start to help test or write tests on a part time basis.
Comment #67
kidsil commentedsubscribing
Comment #68
stevetweeddale commentedRe-rolled the patch in #41 against the current 6.x-2.x branch head for further testing. Not done any testing myself though...
Comment #69
vectoroc commentedcommited to the 7.x-2.x branch
Comment #70
danimatielo commentedHello,
I've installed the 7.x-2.x dev version on my site and followed all the instructions (which also must be updated for a formal release of the module: the html tag, referred on the step 6 of the readme.txt, is not defined on page.tpl.php anymore: now it is defined on html.tpl.php, which can be found in the system folder).
Still, I could not make the module work: I get the same errors as #58. I've tried changing the theme, but still couldn't solve it. Any ideas of what could be happening?
Thank you in advance,
Comment #71
dmadruga commentedsubscribing
Comment #72
narayanis commentedI ran the module through Coder and saw that it still implements hook_footer(), which is deprecated for D7. I tried to convert it to hook_page_alter() per the D7 requirements. Attached is my first patch contribution to a Drupal module; please be gentle!
Comment #73
stevetweeddale commentedGood catch! Sorry I missed that. I'd recommend using git to create patches if you can - it's the future! The full system file paths at the top of your patch file are preferred to be relative paths to the project root - using the git workflow means you don't have to think about it.
Also, not totally sure, but I'd have thought it's worth looking into using drupal_add_js to add the js instead of hook_page_alter...there's a scope parameter that allows you to say it should be placed with the other footer javascript. sorry I've not time to work on the patch!
Comment #74
stevetweeddale commentedComment #75
Anonymous (not verified) commented#72 @narayanis I would keep the $footer array variable in the function, and not escape out parts of the script.
Then implode the script into the $page[page_bottom] variable at the end of the function.
Patch attached, includes workaround for D7 to render the auto connect form as well.
Comment #76
Anonymous (not verified) commentedRegarding the D7 readme.txt:
In D7 themes there is no
<html>tag in the page.tpl.php anymore, Drupal provides it from core. So how to update that html?Comment #77
tike012 commentedThe tag should be in html.tpl.php, I believe.
Comment #78
Anonymous (not verified) commentedRe: #76
In Drupal 7, there is a new hook called hook_rdf_namespaces which is perfect for inserting the required facebook attribute.
Something like this will do the trick and remove the need for people to manually edit template files:
Loving some of the new hooks in D7 :)
Comment #79
kirie commentedThank you everybody for your great work on getting this ported to 7 - much appreciated! Like #70 I'm also, unfortunately, not able to get it to work. I also used ausrick's excellent suggestion from #78 and verified that the correct rdf namespace does indeed render correctly.
Comment #80
mikgreen commentedHere's a working version. I'm sure there are some bugs still, but basic functionality works fine.
Comment #81
Anonymous (not verified) commented@#80 a patch file would be useful to establish what changes you have implemented from the current dev :)
Comment #82
wwwcitizen commentedUsing the last module from #80 I got :
Comment #83
mikgreen commented@ausrick give me a hint how to make a patch for whole module, e.g. multiple files. I'm too lazy to figure it out now. ;)
Comment #84
Anonymous (not verified) commented@mikgreen, git (http://git-scm.com/) is the best way to go and what Drupal uses for version control, so worth researching.
Follow the instructions at http://drupal.org/project/fbconnect/git-instructions to set up your local repository of the current dev. Then swap the files with your changed versions and prepare a patch following the instructions on the same page.
The result will be a patch of all the differences! :)
Comment #85
mikgreen commented@ausrick, thanks! I've created as clean a patch as possible. JS file is not changed that much, it's a big part of patch because of whitespace indentation.
Known issues:
- If you log out of Facebook (in other window), then refresh Drupal page a couple of times, fbconnect settings will lose connection information and ask again to login with Facebook to link your account (even though it is still linked in database). Somehow D6 version of fbconnect manages to keep that facebook session even if you log out of Facebook.
- Of creating account, fbconnect settings (fb_visible, fb_avatar) are not saved.
- If you choose to use fb avatar as your user image, user profile form still allows to upload image (pointless).
- Why store fbuid in both database mapping table and user object (second is redundant)?
Comment #86
sanyatuning commentedsubscribing
Comment #87
sanyatuning commentedHi all.
I don't see "Connect URL" in my settings screen, i found just a label, but value isn't there.
The connect button on User edit page do nothing.
Could you help me?
Comment #88
mikgreen commentedAnother version. Two first issues from #85 have been fixed.
Comment #89
jackhutton commentedsubscribing.
Comment #90
urbanfarmer commentedsubscribing
Comment #91
kirie commentedHey mikgreen - thanks for your work on this! I tried your extensive patch from #88, and could finally get it working! Thanks!!
Some misc feedback:
Settings pages:
On the settings page (admin/config/fbconnect) - the field "Connect url" is empty, and looking at the code (around line 62 in fbconnect.admin.inc) the form element "#type" is "item" and uses "#value" instead of "#markup" for displaying of the info (which resulted in nothing begin displayed).
On the "Apperance page" the setting "Disable linking accounts during registration" doesn't seem to do anything
The page at "admin/config/fbconnect/fb-app" is completely empty
User account FB settings page (user/UID/edit/fbconnect):
There's a link there to the "User settings" page - the whole thing should probably be removed if profile pics are disabled on the site
Again, thanks a lot for your work - its really appreciated!
Comment #92
KirstenLangholz commented... and for the noobs ....
Would it be possible to provide a new 7.x-2.x-dev version with all the patches included, so it is easier for me to update it?
Thanks in advance..
Comment #93
itaces commentedI second KirstenLangholz's post.
I am not having success patching the fbconnect 7.x-2.x-dev posted by vectoroc on March 16, 2011 at 4:56pm, and this module is really valuable to D7 sites, being that it's might more lightweight than Drupal for Facebook which is much more of a beast.
I've gotten the Drupal7_port_fix-795128-85.patch to work using:
patch -p1 -b < Drupal7_port_fix-795128-85.patch (no error messages)
But, I get errors with Drupal7_further_fixes_795128-88.patch file.
And, I'm probably not qualified to contribute to the development process, but here goes:
On line 124 of "fbconnect.pages.inc", there's an invalid function, "db_result" (D6 function replaced with fetchField() in D7), is used... shouldn't line 124 be:
Comment #94
AdrianB commentedSubscribing.
Comment #95
andrebonfanti commentedsubscribe
Comment #96
sorensong commented+1
Comment #97
robato commentedFor those who have successfully patched this file, could you post the working module somewhere on the internet for those of us that keep getting failed hunk messages?
Every single patch file in this thread gives me fail notices with the most recent version of the module.
Comment #98
cwsmith1701 commentedNotice: Trying to get property of non-object in fbconnect_user_identities() (line 174 of /home/content/46/7809246/html/sites/all/modules/fbconnect/fbconnect.pages.inc).
I'm getting this as I try to connect facebook to a preexisting account. Don't know if this bug needs to be addressed or if it's already been addressed currently.
Comment #99
d.holmen@gmail.com commentedSubscribing
Comment #100
Bahlool commentedsubscribing
Comment #101
walterswa commentedsubscribing
Comment #102
syodash commentedsubscribing
Comment #103
felipepodesta commented+1
subscribing
Comment #104
MacRonin commented+1 subscribe
Keeping an eye out
Comment #105
rlmumford*deleted*
Comment #106
geerlingguy commentedsubscribe
Comment #107
matthiashansal commentedsubscribe
Comment #108
blackdog commentedHere's a re-roll of #88.
Changes since #88:
Fixed the #markup form fields on the settings pages and moved the settings to config/people/fbconnect.
I'm not sure about all the JS changes, since they are all from mikgreens patch in #88.
Problems I'm seeing:
Can't create new account - email address isn't fetched.
Comment #109
blackdog commentedBetter patch that also fixes the issue with getting the email address.
Comment #110
aspilicious commentedPatch is full of tabs and traling whitespaces
Comment #111
mikeprinsloo commentedRemoved tabs and trailing white spaces.
Comment #112
Adibou commentedHi, I have patched fbconnect with the patch of #111 for peoples who don't use "GIT".
It work for me.
Version patchée avec le patch du #111 pour les personnes n'utilisant pas "GIT".
Fonctionnel.
Good look.
Comment #113
likewhoa commentedpatch applies cleanly. @Adibou unless you plan to maintain this, you shouldn't assign yourself to this bug as it requires further testing before a RTBC
Comment #114
jagermonster commentedI have been doing some work on this module to get it working.
Comment #115
narayanis commentedDo these patches ever get rolled into the dev build? There are a lot in this thread now and it may make sense to push them and work from latest.
Comment #116
jagermonster commentedI have been doing some more work on this module to get it working. navigate to fbconnect/register/prompt
to give it a test
This patch is to be applied to the 7.x-2.x head and includes the previous patch
Comment #117
jagermonster commentedI have been doing some more work on this module to get it working. navigate to fbconnect/register/prompt
to give it a test
This patch is to be applied to the 7.x-2.x head and includes the previous patch
Comment #118
jagermonster commentedOops wrong patch on previous post (it contains some bugs) please use this one
Comment #119
jagermonster commentedZip file with patch applied for people without git.
Comment #120
jagermonster commentedBeen doing some more to get this working on drupal 7. The facebook api that is being used is v2.1.1 this will need to be updated some time since v3 has been released. Put facebook.php v2.1.1 in the fbconnect module directory directly so it is available at fbconnect/facebook.php
Module now allows users to log into website using facebook, also allows users to link account on facebook with account on website.
find latest patch attached. This patch includes all patches and will need to be applied to the 7.x-2.x trunk
Comment #121
bnicoll commentedHi Jagermonster,
Is there a difference in the last patch and the zip file you posted a few hours earlier.
I'm still experiencing errors on connect and also the error:
Notice: Use of undefined constant BLOCK_NO_CACHE - assumed 'BLOCK_NO_CACHE' in fbconnect_invite_block_info() (line 66 of /var/www/vhosts/mysite.com/httpdocs/sites/all/modules/fbconnect/fbconnect_invite/fbconnect_invite.module).
Be great if we can get this running.
Appreciate your work
B.
Comment #122
Anonymous (not verified) commentedMany thanks for sharing your work on this, jagermonster.
7.x-2.x with patch at #120 working here with facebook.php v2.1.2. I only tested the basic auth functionality.
Comment #123
jagermonster commentedbnicoll at #121 yes this latest patch has some fixes mostly javascript fixes. i have attached a zip file, the facebook.php library is in the zip file.
Comment #124
bnicoll commentedThanks jagermonster,
I've ditched it for the time being and going to try using the janrain/rpx module as suggested in post #62.
Thanks
Ben.
Comment #125
jagermonster commentedgreat, just needed something functional for the time being.
Comment #126
Ashu commentedhi jagermonster,
I have used your given zip module in #123.with that many of the issues are solved.But on the login page
the fbconnect button is not still present.Please help...
Thanx in Advance.
Comment #127
bochen87 commentedAlso the takeover of the facebook profile picture doesn't work :-(
Comment #128
jagermonster commentedyes i know, only login and account creation.
will see if i get some more time i might have a look at the picture support
Comment #129
jagermonster commented#126 Ashu if you would like to add a link to the registration form use the hook_form_alter function to add it to the registration/login form
here is an example
/**
* Implements hook_form_alter().
*/
function YOUR_MODULE_NAME_form_alter(&$form, &$form_state, $form_id){
//add facebook login button to login form
if($form_id == 'user_register_form' || $form_id == 'user_login' || $form_id == 'user_login_block'){
//get facebook info
$conf = fbconnect_get_config();
//check if facebook api key and secret is set
if(!empty($conf)){
$reg_msg = t('Log in with Facebook');
$reg_attr = array();
if ($conf['fast_reg_mode']) {
$reg_attr = array('attributes' => array(
'onclick' => 'Drupal.fbconnect.DoFastRegistration(this); return false;'
));
}
$form['fb_login'] = array(
'#prefix' => '
'#markup' => l($reg_msg,'fbconnect/register/create',$reg_attr),
'#suffix' => '
',
);
}else{
drupal_set_message('Facebook api key and secret not set');
}
}
}
Comment #130
damienmckennaClosed #1200044: Does it actually work on 7.2? as a duplicate.
Comment #131
damienmckennaThis might be a slightly more sane version of _facebook_client_load_include() and would waste much less effort doing file checking:
Comment #132
damienmckennaSlight fix for the code in #131 that doesn't leave a watchdog message just because the file doesn't exist in sites/all/libraries. Also, the correct check is dirname(__FILE__), not dirname("__FILE__").
Comment #133
damienmckennaIt might be worth adding a link on the API settings page to the API registration page, e.g.:
I also included the "OAuth" field names, to help site builders identify what strings to add where.
Comment #134
damienmckennaMissing feature:
Some existing code is there, presumably from the 6.x branch, but it's commented out.
Comment #135
Ashu commentedthanx jagermonster for replying...
But i have done that on the same day Using This Patch
@@ -214,7 +222,7 @@ function fbconnect_form_alter(&$form, $form_state, $form_id) {
// Render fbconnect on login block.
case 'user_login_block':
- if (!empty($_GET['destination']) && ($_GET['destination'] != 'fbconnect/link') && facebook_client()) {
+ if ( ((!isset($_GET['destination']))||($_GET['destination'] != 'fbconnect/link')) && facebook_client()) {
#848354 : ask user for email permission when account linking is disabled
$attr = array();
@@ -225,8 +233,8 @@ function fbconnect_form_alter(&$form, $form_state, $form_id) {
$form['fbconnect_button'] = array(
'#type' => 'item',
'#description' => t('Sign in using Facebook'),
- '#value' => fbconnect_render_button($attr),
- '#weight' => 1,
+ '#markup' => fbconnect_render_button($attr),
+ '#weight' => 200,
'#id' => 'fbconnect_button',
);
}
Comment #136
mudtraining commentedSubscribing.
Comment #137
pcambraAs there is a D7 release for this module already published, shouldn't we treat the individual issues/improvements separately?
Comment #138
filip.baeke@gmail.com commentedHi, I'm having the same problem as mentioned in #98
Notice: Trying to get property of non-object in fbconnect_user_identities() (line 174 of /home/content/46/7809246/html/sites/all/modules/fbconnect/fbconnect.pages.inc).
Did anyone find a solution ?
Comment #139
mudtraining commentedIs anyone getting this after #129 and #135?
PDOException: SQLSTATE[42S02]: Base table or view not found: 1146 Table '.users' doesn't exist: SELECT COUNT(name) FROM users WHERE name = ':user_name'; Array ( [user_name] => ) in _fbconnect_get_username() (line 123 of ......sites/all/modules/fbconnect/fbconnect.pages.inc).
It seems like the answers are here in some form, a release would be so money. If a new release is provided, I'd be happy to test it out. (I'm not able to do any solid development yet.)
Comment #140
ktleow commentedSubscribe
Comment #141
jagermonster commentedresponce to #98 and #138, i created an account on the drupal site. then navigated to user/#uid/edit/fbconnect and used the fbconnect to connect my account with facebook. It worked fine. Try using the module attached to #123 and let me know if you still get the error and the exact steps you used.
Comment #142
pcambraHere's a patch with the changes suggested by Damien and also some fixes for stream module.
Comment #143
jagermonster commentedI have fixed the facebook profile picture support.
This patch includes 795128-Port_fbconnect_to_d7-142.patch and all previous ones by me on this page.
Comment #144
jagermonster commentedUpdated the README
This patch is applied to the 7.x-2.x-dev branch and includes all patches on this page
Comment #145
jagermonster commentedReadme.txt update patch
Comment #146
rlnorthcuttsubscribe - thanks for everyone's contributions!
Comment #147
cjs_ commentedWhat is the status of this?
I tried applying the patch in #144, a few of the attempts fail, but seemingly just for already present corrections.
However, site will not load after, b/c of error:
Call to a member function getSession() on a non-object in .../sites/all/modules/fbconnect/fbconnect.module on line 407
This isn't the typical getSession() error (using the correct 2.x version of the facebook php libs). It only occurs after applying the patch in #144.
Does anyone have this module in working condition under D7?
Comment #148
cjs_ commentedOkay, applying the later patches to the official 7.x-2.x-dev doesn't seem to work.
This is because one of the above patches moves the expected location of facebook.php, so either be prepared to move it into fbconnect/.
Grabbing the version in #123 gets fbconnect back up and running, but still doesn't seem to work, although it's the most fully working copy yet. Everything seems ready to go, except I never get prompted to authorize the app, and I'm not seeing a login button provided anywhere. Something still isn't complete, but I'm not sure whay.
Dead end again, for now.
Comment #149
bobooon commentedThe appropriate facebook SDK to use is here, https://raw.github.com/facebook/php-sdk/v2.1.2/src/facebook.php. Put this in sites/all/libraries/facebook/facebook.php and it should rid the getSession error.
Comment #150
ciscoweb01 commentedException thrown while using admin_setAppProperties : The method you are calling must be called with an app secret signed session
Notice: Undefined variable: res in fbconnect_fbapp_settings_submit() (line 289 of /modules/fbconnect/fbconnect.admin.inc).
Checking your facebook session, you are not allowed to change this application settings
This is my error, any clue?
Comment #151
jagermonster commentedPatch to fix an issue with users that have an account on the website and then afterwards try to create an account with fbconnect. Will have to manually apply this patch i did not create it with git
Comment #152
jagermonster commentedIgnore previous patch!! That solution dont work.
Find attached my latest version of the fbconnect module in zip format.
very busy atm will create patch when i have some free time.
Comment #153
jagermonster commentedPatch with all my changes and bug fixes from the current 7.x-2.x dev branch.
Comment #154
jagermonster commentedLast patch contained a bit of custom code
//remove fblogin button
unset($form['actions']['fb_login']);
that should not be in the module
this is the correct patch.
Comment #155
RaulOne commentedHi jagermonster,
When i enable the new fbconnect.zip you uploaded i get this.
Fatal error: Call to a member function getSession() on a non-object in /home/juegosp1/public_html/xxxxx.com.ar/sites/all/modules/fbconnect/fbconnect.module on line 434
Someone know what is/i'm doing wrong? Any idea? The entire site stop working. Work again only after deleting the module.
Comment #156
RaulOne commentedDisabled some other facebook modules and working now
Comment #157
jagermonster commented@RaulOne #155 - what version of facebook.php are you using? You have to use the version 2.1.1 or 2.1.2 facebook.php not the Facebook PHP SDK (v.3.1.1)
Comment #158
tgriswold commentedI have gotten past most of the errors (or at least I think I have), the last big hurdle was making sure the facebook.php was in the fbconnect directory and not in the src directory. At that point, (after clearing cashe) I got an “invalid URL” message when trying to connect to fb; the App ID and Secret code were correct. To get past this I had to go to My Apps on Facebook and set “Remove Deprecated Auth Methods” to disabled. This can be found under Edit Settings, Advanced migrations. After again clearing cashe and giving Facebook a few minutes to propagate the change, it linked up and I was able to log in using fb and set my picture from fb.
I am still getting a Notice: Undefined variable: preset in fbconnect_theme_user_picture_override() (line 889 … but I was able to log in using FB and link my FB picture. Progress but so painfully slow.
Comment #159
tgriswold commentedInstalled the version of fbconnect_4 from #152 on a clean D7 install.
Installed facebook.php from SDK 2.1.2 in the fbconnect directory.
Completed the html mod to the modules/system/html.tpl.php file ... it was moved from the theme templates/html.tpl.php file in D7
Set up a facebook app and added the ID and secret key to my fbconnect installation
After the "invalid URL" error (see #158 above), I set “Remove Deprecated Auth Methods” to "disabled" in fb my app
At this point I was able to link to fb and upload my fb image to my drupal account but continue to I get the following error:
Notice: Undefined variable: preset in fbconnect_theme_user_picture_override() (line 889 of /home/----------- /sites/all/modules/fbconnect/fbconnect.module).
I get this error when I added a blog to my test account and it shows 3 times when i view "My Account".
The image does show.
Comment #160
Donaldd commentedsubscribing
Comment #161
narayanis commentedThe error in #158 and #159 seems pretty literal. I don't think the $preset variable is being set by either of those if statements. In D7, should an empty variable be "" or NULL? Line 869 is checking if it's set, but may not be doing it the right way. I checked a couple other modules' code and they're all checking for NULLs when doing this kind of thing.
I haven't learned Git yet so I can't roll a patch, but a test to see if that's the cause is to change line 869 (of the version from #152) to this:
elseif (variable_get('fbconnect_pic_size', NULL)) {Comment #162
neskenazi commented'scribing
Comment #163
narayanis commentedAnyone have rights to commit patches? It would be good to get #154 committed so we can keep moving forward, and make it a bit less confusing to follow the thread. The last dev release was in March according to the project page...
Comment #164
MyNameIsCarl commentedSuscribing.
And hoping to get it working on my windows/easyPhp box.
Is fbconnect.zip attached to post 152 the definitive plugin to use, or do I have to apply the patch in post 154 on top of the zip.
I know it sounds fetchy but I can't get the whole thing working on my box, and I want to be sure.
Cheers
Comment #165
doka commentedIt is either/or. So either take the zip of #152 (http://drupal.org/files/issues/fbconnect_4.zip), or download the 7.x-2.x-dev version from March (http://ftp.drupal.org/files/projects/fbconnect-7.x-2.x-dev.tar.gz) and apply the patch of #154 (http://drupal.org/files/issues/more-bug-fixes-795128-153_0.patch) on it.
But for both cases you need an extra patch on fbconnect.module, to overcome the issues of #158 and #159, :
change the line 867 of fbconnect.module from that one:
elseif (variable_get('fbconnect_pic_size', '')) {to that:
else {or apply my patch attached.
And you have to use an old Facebook PHP SDK (2.1.2: https://github.com/facebook/php-sdk/tarball/v2.1.2), not the recent ones: download, untar it to /site/all/libraries, rename it to facebook-php-sdk, and copy/symlink the scr/facebook.php into your fbconnect module directory.
Comment #166
yogendrarampuria commentedsubscribing
Comment #167
drwierdo commentedWhy aren't the patches commited??
Comment #168
doka commentedI've setup a mirror at github for the 7.x-2.x branch, see: https://github.com/doka/fbconnect
The "drupal.org" tag reflects the last committed version of the 7.x-2.x branch, from here, at d.o.
The "7.x-2.x-alpha1" tag is the patched version of jagermonster at http://drupal.org/node/795128#comment-4817546
The "7.x-2.x-alpha2" tag contains a few patches of mine, on top of 7.x-2.x-alpha1, see changelog for more details. This is the last status working fine for me.
I'm happy to accept patches and pull request over there, as long as the 7.x-2.x" branch is not maintained here at d.o.
Comment #169
tim.plunkettI've opened #1263774: Offering to comaintain Facebook Connect in the hopes I can start committing this patch and further fixes, to avoid splintering over to github.
Comment #170
tim.plunkettI committed according to the instructions in #165, and then followed up with a coding standards fix. I'm closing this issue, if there are any further bugs, open new issues.
http://drupalcode.org/project/fbconnect.git/commit/7910e9d
http://drupalcode.org/project/fbconnect.git/commit/379a2ba
Comment #172
hadi farnoud commentedI still have problem
Notice: Undefined index: email in fbconnect_register_page() (line 97 of /home/iraniansociety/public_html/sites/all/modules/fbconnect/fbconnect.pages.inc
Comment #173
jagermonster commentedfile your issue as a bug report in a new thread under 7.x-2.x-dev
Comment #175
onegenius commentedsubscribing
Comment #176
mareks commentedI get the same error on /admin/config/people/fbconnect/fb-app
* The configuration options have been saved.
* Exception thrown while using admin_setAppProperties : This method must be called with an app access_token.
* Notice: Undefined variable: res in fbconnect_fbapp_settings_submit() (line 298 of /var/www/MYSITE/html/sites/all/modules/fbconnect/fbconnect.admin.inc).
* Checking your facebook session, you are not allowed to change this application settings
Comment #177
lennyaspen commentedsame issue as #176 comment above