Port sms framework project to D7

Hi @Ben,
I do not know of any work that has been done on the SMS Framework for Drupal 7. The Framework is in dire need of a revamp, and I think that 7.x will become the best reason to get this moving. I will have to investigate 7.x a bit more closely, methinks...

Subscribing

subscribing.

This is a dire need for D7 over here as well.

subscribing

Changing title for better use in the dashboard.

Subscribing...

D7 obviously very important now that its released, but I really would like to have a stable 6.x version that works well before attempting a port myself. If anyone would like to start this effort please do so.

I have not thought too much about the D7 port and whether there is anything new in D7 we can leverage like making sms numbers a field that you can add to any entity? I wonder if this would make sms functionality any more useful or flexible?

Even if it doesn't add any "extra value" to D7 or can take any new stuff from it, still is a good idea to port to d7. When I found out that we could have a fan club with text messages, I thought it was a good idea to use the module. If it isn't ported, it throws the entire plan off course. Unfortunately, I am just getting into php 5 coding and wouldn't know how to port it.

I wish to help in making a D7 module.

It would be nice to have a generic "Phone Number" field that has full validation (and possibly even *verification*), etc., that could be used by the SMS Framework, or by some VoIP module, or in Views, or whatever. The http://drupal.org/project/phone module might be a good candidate.

Then on top of this super-duper field (which is also smart enough to distinguish between mobile/cell phones and landlines), the SMS Framework can do its stuff.

If it turns out to be necessary to build a *new* "Phone Number" field, I'd suggest that it'd be better to build it separately than having it inside the SMS Framework.

That way, for example, it could be used alongside an "Address" field, at times when the SMS Framework isn't required, or by a VoIP module, or whatever..

I do like this idea, and exactly the type of thing I have been thinking about for D7 to take some load of this module and have it focus on the important sms stuff and not get bogged down with phone number fields and number validation which are features useful in other places not just sms.

Waiting for this

likewise. wish i could help, but this is beyond me.

Adding this to my must-have list

Subscribing: Can do some testing of D7 smsframework and cck_phone as part of an ongoing project.

Subscribing

Waiting for this

++

Subz

suscribing...

suscribing

subscribing

+1

subscribing

subscribing

Subscribe

subscribe

I too am subscribing, and in light of the above, I will be contributing to Phone Number project's Drupal 7.x port in order to progress this, as I have available time.

subscribing

subscribe++++

Me too.

According to #12 and #14, this is going to be more streamlined in the 7.x version, and thus this needs to wait for one of the projects mentioned in those posts to release a stable 7.x version at the very least, before cohesive work can begin on this...

Sorry guys, but what about this? This issue is one year old!
http://drupal.org/project/phone seems more active on older Drupal versions than D7.
http://drupal.org/project/cck_phone last commit for D7 is 2 months old, but it doesn't seems to have critical issues.
I don't want to put pressure, but I'd really like to see this module on D7.
I can provide some help, if needed.
TIA

Subscribing.

#37: Ditto! cck_phone seems most favorable, and I can also put in some effort if needed.

Subscribe.

subscribing.

I might be able to contribute some sponsorship to speed up the development, maybe others would be interested in chipping in too?

Cheers
Tom

subscribe! - yes I could potentially chip in..

Here is a working D7 port of the base sms module, but none of the other supporting modules it usually comes packaged with.

I have only tested this with the "log only" gateway and the Twilio gateway D7 dev port from here: http://drupal.org/node/1194626

I will update this issue once I have done more testing, but I figured I'd go ahead and get this posted since it is at least mostly working.

Hi folks - sorry for my confusion but this "port" is based on 6.x-1.x.

I will work on an updated port based on 6.x-2.x and post it here later this week.

Ok, attached here is a patch against 6.x-2.x-dev for a very early D7 port. I tested the admin GUI for the Gateway config, and tested the "log only" gateway and the Twilio gateway D7 dev port from here: http://drupal.org/node/1194626

Please ignore my comments #44 and #45 above.

That's it - I haven't tested the Rules integration at all yet. I haven't even tried to port ANY of the submodules. But, this IS working for me using sms_send().

Please don't be shy with feedback on what I can do to get this to a place it's ready for a 7.x-dev release.

Had a quick look at the patch and it generally looks good to me and can't really see any real reason why shouldn't atleast create a 7.x branch and use this as a start. I will do that shortly.

Patch #46 works for me - I am testing it against smsframework-6.x-2.x-dev. Also, you need to run the patch from INSIDE sites/all/modules/smsframework - I apologize if I got this wrong. I just tested okay by following these steps:
1) cd sites/all/modules
2) drush dl smsframework-6.x-2.x-dev
3) cd smsframework
4) patch < /PATH/TO/PATCHFILE
5) enable and test module as usual

If you still get a WSoD again, please include relevant snippets of your web server error log.

Be great to get the D7 branch up and running so it's a bit easier for people to test and patch against.
Any progress on that? :)

Cheers
Tom

Attached is a new patch against 6.x-2.x-dev for a D7 port.

I have:
* tested the admin GUI for the Gateway config
* tested and fixed the admin GUI for the Carrier config - the GUI works, but haven't tried to send SMS's with it
* tested "log only" gateway
* tested sms_send() with the Twilio gateway D7 dev port from here: http://drupal.org/node/1194626
* run this through Coder review

I have NOT:
* tested the Rules integration (sms.rules.inc)
* ported ANY of the submodules

univate, please let me know if there is anything I can improve in order to get this committed as a 7.x-dev release.

Attached is a new patch against 6.x-2.x-dev for a D7 port. I got the Rules and Token integration working.

I still have NOT migrated any of the submodules, but I think all the main SMS Framework stuff is ready for a 7.x-dev release.

Hi,

Here's another patch which includes:
- Patch #54
- upgrade of the sms_sendtophone sub module (all should work minus cck field, but I'm not sure that worked in the D6 version?)

Let's keep the ball rolling with the patches & get the module upgraded! :)

Cheers
Tom

Any status on the email gateway? Is the only way I use smsframework. Good work - still have to run the patch though. D7, I might be able to use you soon afterall

Looks like a good start, committed it and created a 7.x branch

The module plays well with the Clickatell gateway. I'm going to work on porting sms user tonight.

Phew!! I reduced it to minimum functionality, awaiting response from group discussion for more info. I've tested registration,get uid by number, added hook_sms_user_sms_incoming for other modules to handle sms after user registration(might change later with more settings added). All features were tested by myself through the Clickatell gateway. The uninstall isn't working properly because of a bug in fields core.
First ever commit so don't be too harsh :)

For the first one I think I need to do another pull before patching but I didn't see any other activity so I assumed I didn't have to. The second one I need to google. It's about installing the fields before activating the module. The field type declaration is in the module, the field instalation is in the install file. Do you think a require_once would be enough?

giorez: are you applying the patch to the latest 7x-dev branch? That's where my patch starts from.

Sorry I didn't see the upgrade patch in the thread when I posted this.

I've been trying to upgrade the SMS User sub module but I'm having some issues. I'm not very good with PHP so bear with me.

I've attached the zip from the SMS User which is against the 7.x-1.x-dev 2011-Aug-09.

It has a lot of extra code in it to try and go back for when something didn't work and I know that will have to be taken out.

I was able to get the SMS User tab to integrate into the framework admin page and the SMS Users to view the current users but I cannot for the life of me get it to add the forms to the users page for adding/editing their phone number.

Any help with this would be greatly appreciated.

sub

When I tested the patch I was using the Clickatell gateway(which worked) so I assume the problem is with the simple gateway.

There is a huge confusion about this... I propose we split all module upgrades in their own bug threads so people can follow them by interest. Only add comments here when there's a patch accepted.

Task thread for SMS User http://drupal.org/node/1247538

I split out the Rules integration update to this issue: http://drupal.org/node/1304276

Combined with VBO, I believe that you can use Rules to completely replace sms_user. Even if sms_user gets ported, I think this Rules integration will be very useful. Is there anyone that's willing to review and test that patch?

Hi, here is my configuration:

Drupal: 7.12
SMS Framework: 7.x-1.x-dev
Clickatell: 7.x-1.x-dev

Is Clickatell module working with SMS Framework on d7. I've installed both and I keep receiving the following messages:

........
Notice: Uninitialized string offset: 0 in sms_clickatell_command() (line 249 of /home/subnetcat/public_html/workspace/danfisk_ubercart/sites/all/modules/sms_clickatell/sms_clickatell.module).
Notice: Undefined property: stdClass::$error in sms_clickatell_command() (line 319 of /home/subnetcat/public_html/workspace/danfisk_ubercart/sites/all/modules/sms_clickatell/sms_clickatell.module).
.......

Hey guys,

Sorry to intercede here, but I've made SMS, SMS User, Twilio API, and SMS Blast D7 compatible independently of all of this, however I notice you've all made changes as well and have some kinda workflow going on. Do any of you have recommendations on how I should proceed with helping getting this up to par? I'd be happy to chat on IRC or skype with any of you, please email me at james@thetechscouts.com if any of you just want to get this done.

James

Alright so I went through this issue queue and basically it sounds like smsframework is D7 compatible, but sms_user is not. I actually am going to close this issue, upon the direction of comment #74, and move it to #1247538: Port SMS User to 7 since thats why it was created in the first place and now theres a separate issue for that. Feel free to reopen it if you feel otherwise.