Make revisioning compatibile with other modules overriding node view menu callback.

Ok.
I feel I may be able to help you out.
Watch this space.

Note that simply recording page callback and invoking it wouldn't always work. Tricky part is callbacks also can have different arguments.

Really sorry but currently snowed under...

I'll assess this weekend and will get back to you.

Darn... still haven't had time to look at this one.... sorry.

Holy moly... it's been 5 months....
The will is there, but the time is not....

This is also an issue for anyone utilizing the node_view Panels Page, which overrides the node/%node path.
Therefore, important by my standards :)

Any news?

It'd be nice to use Revisioning with PURL :)

@RdeBoer: Would you consider something like something like Chain Menu Access API?

@scott, #17
Chain menu API looks like the way to go. Thanks for pointing it out to us! I hope to have some time later this month for this and some porting work.

I'm also anxiously awaiting a nodecomments compatible revisioning module. Thanks for all your hard work!

I'm also running into this problem. I need to use Revisioning and also Node Comments.
Any progress? Any testing I can help with or info I can provide on my configuration?

I will look into this this weekend....

Sorry I need a bit more time. Hopefully next weekend.

To get around this for now, I created a module with a heavier weight than either nodecomment or revisioning. In that module, I used hook_menu_alter to override node/% to point to a new implementation that merges both of their functions into a single implementation. It's not the best answer, but works for me. Here is the key fragment (obviously replace MODULE with your module name, and don't forget to change the module weight):

/**
 * Implement hook_menu_alter - to override the node/% callback when both node comment and revisioning are used, because
 * they conflict with each other.  This version merges the code from each of them into a unified view.
 */
function MODULE_menu_alter(&$items) {
	// are we using both node_comment and revisioning?  If so, change the node/% callback to point to us
	if (module_exists('nodecomment') && module_exists('revisioning'))
	    $items['node/%node']['page callback'] = 'MODULE_node_view';
}


/*
 * Implement a version of node_view (called on all node/% pages) that merges the logic of nodecomment and revisioning
 * to resolve a compatibility issue they are having.  Only used when both modules are enabled.
 */  
function MODULE_node_view($node, $cid = NULL) {
  if (_revisioning_load_op($node, 'view') == REVISIONING_LOAD_LATEST) {
    $vid_to_load = revisioning_get_latest_revision_id($node->nid);
    $node = node_load($node->nid, $vid_to_load);
  }
  
  drupal_set_title(check_plain($node->title));
  $output = node_page_view($node, FALSE, TRUE);

  if (!empty($node->comment)) {
    $output .= comment_render($node, $cid);
  }
  else if (!empty($node->node_comment)) {
    $output .= nodecomment_render($node, $cid);
  }

  // Update the history table, stating that this user viewed this node.
  node_tag_new($node->nid);

  return $output;
}

Hope this helps...

- Chris

@ #24
Thanks for all this Chris.
Sorry I didn't get round to spending any time on it so far.
Rik

Looks like Chris' solution in #24 does the job with any change necessary to Revisioning.