Drag & Drop ordering not retained on Save [#797254]

I'm at /nodeorder/term/56/order and drag & drop the nodes into my new order.

Click "Save Order" and it saves (or says it does), but the order is still the same as before I saved.

The links on /nodeorder/term/56 that allow you to move up and down in the list work fine.

Value of weight_in_tid is not changing. I've tried turning ordering off and back on for the Taxonomy, but I still can't get ordering to stick.

Comment	File	Size	Author
#5	nodeorder.zip	13.96 KB	arlmedia

Comments

Comment #1

webnation commented 28 May 2010 at 16:15

I'm having the same problem. It's strange - I've used this module on other sites and it has worked perfectly but now it doesn't seem to do anything at all. Maybe I'm forgetting something but I can't think what.

Comment #2

webnation commented 29 May 2010 at 10:42

I've just realised I hadn't read all the installation instructions, especially:
"Please note that the node order is only respected when visiting links that begin with "nodeorder" -- if you visit links that begin with "taxonomy" they will appear in the generic taxonomy order. Since the module implements hook_term_path, the taxonomy links that get printed per node will correctly point to the "nodeorder" space when they are in orderable vocabularies."

I'd added ordering to taxonomy/term/6 and the taxonomy/term/6 page showed an 'order nodes' tab that didn't actually order the nodes when changes were saved. But if I went to nodeorder/term/6 the same node teasers were displayed but this time they were orderable.

Comment #3

benklocek commented 12 June 2010 at 00:55

I'm having the issue when on the /nodeorder/ url.

Comment #4

arlmedia commented 20 November 2010 at 11:32

Title:	Drag & Drop ordering not retained on Save	» Quick-Fix for presumed Java Script Bug in the order userinterface : Drag & Drop ordering not retained on Save
Issue tags:		+submit, +quickfix, +nodeorder

We had the same problem on several Drupal 6.x installations: the revised nodeorder could be submitted after reordering in the "order" user interface by "dragging" the nodes: It was not saved. The submit button was deactivated.

Our analysis: The submit button is deactivated by default if no reordering of nodes has occurred. However after reordering the submit buttion should be activated. The Javascript providing this switch function seems to be buggy.

Our quick fix: In the nodeorder mdoule we switch of the "disable" function for the submit button in a permanent quick fix.

File: nodeorder.admin.inc Line 79

before:
#disabled' => true
now:
'#disabled' => false

So we have forked the default nodeorder module and will continue to work with our fork until a more permanent solution is provided upstream by the module maintainer. The reorder function now works in all instances. However it is also possible to save an unchanged noderorder, But that does not do any harm so far.

Comment #5

arlmedia commented 20 November 2010 at 11:37

Status	File	Size
new	nodeorder.zip	13.96 KB

please find the revised module of nodeorder mentioned in comment-3733544

Comment #6

benklocek commented 20 November 2010 at 23:43

Title:	Quick-Fix for presumed Java Script Bug in the order userinterface : Drag & Drop ordering not retained on Save	» Drag & Drop ordering not retained on Save
Category:	support	» bug

Thanks @arlmedia, that did not seem to work for my install. I'm able to submit the changes, and I even get a "Success" message, but the nodes return to the old order.

I've tracked it down even more, and it seems that the Javascript re-ording may not be getting the array right to send to the form.

I get this error in Firebug: $(this.element)[directions[d]] is not a function.

From tabledrag.js line 1019:
var checkRow = $(this.element)[directions[d]]();

That javascript is beyond me.