base.js line 67 chrome, variable pairs[i] sometimes contain functions and not only stings

I am receiving this error as well, luckily I found this issue!

Could you please make a real patch out of it?

Same problem with IE8 / IE7, but this work for me.

Thanks man!!!!

Here is my new Helper Function:

Drupal.Views.parseQueryString = function (query) {
  var args = {};
  var pos = query.indexOf('?');
  if (pos != -1) {
    query = query.substring(pos + 1);
  }
  var pairs = query.split('&');
  for(var i in pairs) {
    /*var pair = pairs[i].split('=');
    // Ignore the 'q' path argument, if present.
    if (pair[0] != 'q' && pair[1]) {
      args[pair[0]] = decodeURIComponent(pair[1].replace(/\+/g, ' '));
    }*/
		if(typeof(pairs[i]) == 'string'){
			var pair = pairs[i].split('=');
			// Ignore the 'q' path argument, if present.
			if (pair[0] != 'q' && pair[1]) {
				args[pair[0]] = decodeURIComponent(pair[1].replace(/\+/g, ' '));
			}
		} else if (typeof(pairs[i]) == 'function') {
			eval(pairs[i]);
		}
  }
  return args;
};

[]´s

Attached is a patch of the above slightly reworked to only look at elements of pairs[i] that are of type 'string'.

I'm a little too green with drupal. I'm having this same issue I believe. Could someone give me a clue how to apply this patch? I get that it goes in the views/base.js file, but which line, etc. Thank you :)

Nevermind, i see where to do it..and i'll have to figure out how to get into core files to do so.

As it turns out the error I get which is just like this one is because i'm using twitter widget code in a module. it is conflicting with drupal views javascript. Does anyone know if this patch will correct that conflict? Is anyone above also experiencing this along with a twitter widget?

#4 works for me

It seems there is a very similar issue with admin-module (admin.toolbar.js and twitter's widget.js = fatal error in Chrome, Safari and IE, but not Firefox or Safari).

It has been driving me nuts for a while.. but I guess this patch can be implemented for admin too.

I created an issue for that here: #797492: Toolbar won't open in Safari or Chrome. JS error in admin.toolbar.js

To fix the same error in admin-module, I just added:

	    if(typeof(query[i]) == 'string'){
			var values = query[i].split('=');
		}

patch seems to fix a bug on my project as well

thanks :)

Just confirming that applying the patch also resolved my problem in IE8. Under chrome and firefox, there was no issue.

In IE, I had 2 areas that had AJAX pagination on and when I clicked on the next item in either area, it would refresh the entire page including the other AJAX pagination area. After the patch, each area paginated correctly independent of the other section.

setvik's patch is completely identical to a patch I made to resolve this issue. Since I came up with it independently, I think it's perfect :)

The issue is that for some reason the basic array object produced from calling the split function on a string has a function associated with it in some versions of IE. I'm not sure if this is a result of IE doing something weird or of another js library modifying the structure of the basic array object. Either way, the solution of checking each element to make sure it's a string before parsing it is effective and safe. It's a good solution until someone can get to the bottom of where the indexOf function is coming from.

I also independently created a similar patch. +1 for reviewed & tested. Hope to see this committed soon.

I have just tested the patch in #4 and it applied fine, and solved the problem I was having (described here: http://drupalbin.com/15283?nocache=1) with a function ending up as a "pair" causing a fatal error in webkit-based browsers.

RTBC++

I also independently created a similar patch. +1 for reviewed & tested. Hope to see this committed soon.

Hoping for a soonish commit too, since I hate patching important modules like views.

Even if the twitter-widget js is to blame for this incompatibilty, the problem is very avoidable. This small patch at #4 avoids JS conflicts without adding unnecessary complexity.

Ok, guess we can consider this one fixed.

Er. COmmitted to all branches.

This fix works but I don't think it's the correct way to fix this.

The problem is the use of the for...in loop syntax, which loops over all properties of an object (except built-ins) and shouldn't really be used to iterate over arrays. For example, IE doesn't implement Array.indexOf so some javascript libraries may add an implementation to the Array prototype, which means that indexOf is now a user-defined property and will show up when using a for...in loop.

The proper fix is never to use this syntax to iterate over arrays, instead of

for (var in pairs)

you should use

for (var i=0; i < pairs.length; i++)

and you'll only iterate over the strings created by split.

Why not even use:

$.each(pairs, function (var) {
});

That's not the point :)

No need to bring jQuery into this when a for loop is perfectly fine. I'm just advocating the correct for loop synatx.

I second the vote from ianivs #20, IE doesn't like this very much: http://drupal.org/files/issues/js-error_views.png

Proposed: http://drupal.org/files/issues/798764-views-base.js_.patch

-  for(var i in pairs) {
+  for (var i = 0; i < pairs.length; ++) {

Thanks also to stuartEngelhardt

Corrected patch (forgot the 'i'): http://drupal.org/files/issues/798764-2-views-base.js_.patch

-  for(var i in pairs) {
+  for (var i = 0; i < pairs.length; i++) {

From #25
re-rolling against 6.x-2.11

Changing status

this is not working for me. =(

I did this and it says that there is an invalid argument in jquery.

Any ideas?

I'm also getting the Invalid argument error in jquery.min.js (I'm using the jquery_update module if that makes any difference).

Just to update, this error wasn't related to the original problem, the patch worked for the initial error but my new problem was with using jquery ui.

@acondiff, @rolandcarney

Can you provide more info about the error you are getting? Patch works for me and more ppl, there must be another module doing funny things with your js. Is it happening in eery browser?

@rolandcarney
Please open a new issue with your problem is it is caused by a different module. Specially if the patch was working before, or provide more details on how it relates to this case.

It is only in Internet Explorer. I also found it only throws the base.js error when the Shadowbox module is on. There must be some module causing your error because there is not an error in IE without this module on. There is probably a script or function that is causing this that is in several different modules.

After running the IE development tool it gave me the error that jQuery was undefined and it was caused by this line:

jQuery.extend(Drupal.settings, { "basePath": "/", "views": { "ajax_path": [ "/views/ajax", "/views/ajax" ], "ajaxViews": [ { "view_name": "home_posts", "view_display_id": "panel_pane_1", "view_args": "", "view_path": "front_page", "view_base_path": null, "view_dom_id": 7, "pager_element": 0 }, { "view_name": "home_district_standings", "view_display_id": "default", "view_args": "356", "view_path": "front_page", "view_base_path": null, "view_dom_id": 9, "pager_element": 0 } ] }, "beautytips": { "calendar-tooltips": { "cssStyles": [  ], "cssSelect": ".mini-day-on a", "contentSelector": "$(this).next().html()", "trigger": [ "mouseover", "mouseout" ], "list": [ "cssStyles", "contentSelector", "trigger" ] } } });

It is a line contained in a script tag that seems to be printed into my html page. It contains all of my views that use ajax ("home_posts" -uses ajax pager, and "home_district_standings" - uses ajax sorting). Any ideas?

@acondiff
Which patch did you apply? What version of views are you using?
Hard to tell what prob is. I suggest you open a new issue with support request, otherwise it might end up highjacking this issue, which seems resolved.

Cheers

My new issue is created here: http://drupal.org/node/951494

Thanks.

Before reporting an error please make sure you apply patch from #798764-26: base.js line 67 chrome, variable pairs[i] sometimes contain functions and not only stings, the one in #4 breaks in IE.

Cheers

This patch is a dup of #514128: Use of 'for (i in my_array)' javascript array iteration causes issues when used with Prototype -- however, that patch broke things when it was committed and was reverted.

Sorry to revive old issues, but I don't believe this issue is a duplicate.

#514128 deals with use of the for(var x in y) structure. This issue is in the following line, which is trying to perform split() on a non-string. Nothing to do with the for loop.

Unless the "pairs" variable has been strongly ensured to only contain strings, this issue still exists in 6.x-2.12 and 6.x-3.0-alpha3.

Looks like it's been fixed in 7.x-3.0-beta3, with the if (typeof(pairs[i]) == 'string') { fix as presented in the patch in #4 (no else {eval(pairs[i])} clause). Therefore I'm guessing all this needs is to be rolled against the current version and committed.

Setting "to be ported" as the patch exists, and the code is in use in the D7 branch, but it doesn't look as though it'll work as is on the current release.

This has been fixed in 2.x-dev and 3.x-dev using the typeof operator

Ah, sweet, I didn't think to check dev. Thanks!

#25 worked perfectly for me, thanks ChrisRut

Has this patch been commited?
I still have this issue in 6.x-2.12

Here's the function :

/**
 * Helper function to parse a querystring.
 */
Drupal.Views.parseQueryString = function (query) {
  var args = {};
  var pos = query.indexOf('?');
  if (pos != -1) {
    query = query.substring(pos + 1);
  }
  var pairs = query.split('&'); //line 67
  for(var i in pairs) {
    var pair = pairs[i].split('=');
    // Ignore the 'q' path argument, if present.
    if (pair[0] != 'q' && pair[1]) {
      args[pair[0]] = decodeURIComponent(pair[1].replace(/\+/g, ' '));
    }
  }
  return args;
};

EDIT : sorry, I just realized my version was prior to this patch.