CVS edit link for attila.fekete

Developing Soundcloud module for Drupal.

I want to create a module that covers the following functions:
- soundcloud filter: soundcloud URL-s will be converted into embed code; the filter format is [soundcloud:URL] (additional parameters supported)
- soundcloud CCK field - a CCK widget to customize the player
- these functions will work with both tracks and sets.
- using oAuth to get private content from Soundcloud (if possible)
- uploading tracks from Drupal to Soundcloud account
- using Soundcloud API (http://wiki.github.com/soundcloud/api/) to get additional information from tracks

CommentFileSizeAuthor
#4 soundcloud_filter.zip2.56 KBattila.fekete
#1 soundcloud_filter.zip2.78 KBattila.fekete

Comments

attila.fekete’s picture

attila.fekete commented
Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new soundcloud_filter.zip2.78 KB

Only the filter is available at the moment. Module attached to this comment. If the colorpicker module is installed and enabled (http://drupal.org/project/colorpicker), it's easier to pick a player color.

The earlier version (http://drupal.org/node/755092) has been fixed.

Thank you for your review!

wadmiraal’s picture

wadmiraal commented
Status: Needs review » Needs work

Hi,

I installed your module, but nothing happened. Don't see any settings, went to filters and didn't see a new filter in the list, created a node with a [soundcloud] tag (which shouldn't work anyway, not having enabled the filter) and it didn't work (as expected).

So I looked closer at your code. You're module is called "soundcloud_filter". So each hook should be prefixed with soundcloud_filter and not just soundcloud.

function soundcloud_filter($op, $delta = 0, $format = -1, $text = '') {

}

won't work.

function soundcloud_filter_filter($op, $delta = 0, $format = -1, $text = '') {

}

will. Check the rest as well.

And BTW: http://drupal.org/coding-standards. Not a biggy, but I must point it out ;-)

wadmiraal’s picture

wadmiraal commented

I changed that line of code (was the only one that was not correct) and now the module does work. But the music won't play. But that is not an issue with the module, because when I tried embedding directly from Soundcloud (with their code), it didn't play either. I'm no expert with Soundcloud, only made an account to test your module.

Cheers

attila.fekete’s picture

attila.fekete commented
Status: Needs work » Fixed
StatusFileSize
new soundcloud_filter.zip2.56 KB

Hi,

Thank you for your review! I have fixed 2 hooks that were prefixed badly: hook_filter() and hook_filter_tips(). I checked the module, and now it works.
I have included examples on the filter tips page, so you can check with those.
But here are some soundcloud tracks to test:(copy the entire row)

[soundcloud:http://soundcloud.com/chillou/tiefblau]
[soundcloud:http://soundcloud.com/vladkris/carbon-based-lifeforms-photosynthesis]
[soundcloud:http://soundcloud.com/blumarten/blu-mar-ten-she-moves-through-asc-remix]

And a filter configuration page is also available, where the player default setting can be changed (this is where the colorpicker module is recommended, but not required :) )

Thank you again, for the review!

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Fixed » Needs review
wadmiraal’s picture

wadmiraal commented
Status: Needs review » Reviewed & tested by the community

Ok,

This time everything's seems fine.

(The music still doesn't play, but I must check my server or firewall I guess, I don't think it has anything to do with this module.)

I don't know how picky the top guys are when it comes to coding standards (http://drupal.org/coding-standards), but maybe you should consider cleaning your code up a bit. You commented some lines that are no longer necessary, so you might as well delete them. You might also consider documenting your functions a bit, in case someone else wants to patch your code.

Nice work

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.