Upgrade Notifications to 6.x-4.x

Maybe it's too late for 4.x but I think that since notifications is using OOP, other modules can benefit from it, and simply implement a plugin.

As an example see #787644: Export UI - unified ui for exportables , which is not related to notifications, but has some conceptual similarities:
With the above patch modules such as Context and Message will not need to define their own UI, but simply implement a CTools plugin, which will do most of the heavy lifting. The same thing I imagine in OG + notifications. Rather then having og_notifications we will have og.notifications.inc

Benefits:
1) One less module to fiddle with. If notifications is installed, it's integration simply works.
2) Using the power of OOP, custom modules may extend og.notifications.inc and add their own business logic.

Whenever I try to install this patch, I get the following error:

I'm using beta6, and I've tried with both the stable branch of og, and with the dev branch from June 7, 2010.

Any thoughts?

patching file og_notifications.pages.inc
patching file og_notifications.module
Hunk #6 FAILED at 244.
Hunk #7 succeeded at 366 (offset -7 lines).
Hunk #8 succeeded at 424 (offset -7 lines).
Hunk #9 succeeded at 488 (offset -7 lines).
Hunk #10 succeeded at 500 (offset -7 lines).
Hunk #11 FAILED at 523.
2 out of 11 hunks FAILED -- saving rejects to file og_notifications.module.rej
patching file og_notifications.install
patch unexpectedly ends in middle of line
Hunk #1 succeeded at 158 with fuzz 1.

Subscribing... OG compatibility is the only thing blocking my upgrade to Notifications 6.x-4.x . Sorry I can't test this patch, as my dev site needs to stay on 6.x-2.x for some other development work going on.

Subscribing... OG compatibility is -for me too- the only thing blocking my upgrade to Notifications 6.x-4.x.

subscribe

subscribing

@Jose Reyero - just wondering how this is progressing? I would love to use Anonymous Notifications on a project I'm working on but require OG Notifications. I may have to look for an alternative module unless you have an ETA?

I can get the patch posted in #1 to apply (manually). If people want me to re-diff it so they can apply it more easily then let me know.

It seems to work except for an annoying bug:

If a user is subscribed to node type foo, and also subscribed to node type foo withing group bar, then they will receive 2 emails when a node of type foo is posted to group bar. I don't know if this was present in previous versions but it isn't desirable.

subscribe.

about comment #3: og notifications definitely needs some own ui,

1. user could have an option to turn off notifications about each new post in his group, (enabled by default),
and he could have an option to choose which content type from group posts is interesting for his and he want to receive notifications.

2. It could be easy to find, so it could be e.g. block "Og notifications" with checkbox/javascript link - subscribe/unsubscribe of watching new posts of this group, and link something like "more tuning" which can goes to og notifications page. (the best if submitting can be done by ajax)

3. The other thing for og notifications ui is new tab "organic groups" in user notifications where will be all og where user is it's member , and he can turn off/on notifications for any of them (useful if user is member of 20 groups e.g.)

4. admin settings for og notifications could have button "subscribe all og members for watching their groups for all content types"
without this function only new og members would be automaticaly watching their groups, which doesn't make sense. Mass subscribing could be done by Batch api or whatevere else.
It is really important to have an option to subscribe all existed users to their groups.

thanks
Igor

Attached is a patch that you can use with drush make, no changes from comment #1

My 2 cents as far as UI goes; I think what we get with the notifications_ui module is great and doing anything else would not be useful for me.

subscribing

@jmiccolis

> My 2 cents as far as UI goes; I think what we get with the notifications_ui module is great and doing anything else would not be useful for me.

Sorry, I don't understand to what you refer to.

Anyway, although I'm still not familiar enough with the 4.x of notifications I decided to commit it, so more people will be exposed to it and be able to test it, while I learn the code more carefully.

Follow ups should be opened in new issues.

Testing the patch and Notifications 4.x yesterday and noticed that the patch is committed to og 6.x-2.x-dev today.

Just a simple question, does this patch still allow og to work with notifications 2.x or just notifications 4.x ?

Thanks.

@izmeez,
> Just a simple question, does this patch still allow og to work with notifications 2.x or just notifications 4.x ?

just notifications 4.x.

@Amitaibu, Thanks for the clarification.

With this now committed to og 6.x-2.x-dev developers will need to be alerted to the need to upgrade from notifications 2.x to 4.x -- I wonder if this might get missed by some, especially when the next og release version occurs.

@izmeez,

I have written some explanation in OG's frontpage.

@amitaibu, Thanks.

subscribing

subscribing

Not sure this actually works. I am using messaging and notifications 4.x and the new committed OG 6.x-2x-dev and notifications are not going out at all. Not when someone joins a group, not when new group posts are created and I have made sure my settings make new group members automatically subscribed to group content. Is anyone else still having issues? Maybe I missed something.

Having the same issue here. When I visit mysite/user/%/notifications/group, that page does not exist? Has anyone managed to get this combination running properly?

Raul

[edit] I can confirm this appears to be fixed.

On an existing site to upgrade to Notifications 4.x found it was necessary to remove the messaging and notifications modules completely in order to be able to enable Autoload module. Then the messaging module must be added to the sites/all/modules and enable Text templates. Then add Notifications and enable NotificationsUI and Notifications lite. Finally check that og_notifications in enabled.

Also check user permissions.

Thanks.

Sorry, my comment in #25 may have been premature and not completely correct.

I am able to upgrade to notification and messaging 4.x using the approach described in #25.

The email broadcast is going out but new content is not triggering notifications, the same problem described in #23.

Gone is a lot of time in testing this, but not much to show.

When reverting back from notifications 4.x to 2.x just disabling the 4.x modules and renabling 2.x modules with update.php failed. Not overly surprising considering the changes.

Uninstalling the 4.x modules before enabling 2.x modules resulted in loss of all users subscriptions but thank fully the script in http://drupal.org/node/460518 saved my sanity.

Before all this happened I was creating a make-file using og-6.x-2.1 and just the patches required for notifications and see both patches are required:
http://drupal.org/files/issues/521446_og_notifications_play_nice_2.patch
http://drupal.org/files/issues/799856_og_notifications_4x_02.patch

With og notifications 2.x setup working correctly again I'll need to find time to explore upgrade to 4.x further but not right now.

Just thought I'd add my comment and the link to the script file in case others may find it useful.

subscribing

I need clarification, is this a bug one user is facing, or is this issue in fact incomplete?

I wonder whether OG should standardize on 6.x-4.x branch of notifications or 6.x-2.x. I know 6.x-4.x is "improved everything" but if it's really better why is it in beta status?

I don't think OG should switch from 6.x-2.3 to 6.x-4.0-beta7 as its suggested integration point. I think we should just work toward compatability with 6.x-2.x branch of notifications.

I think the commit that changed OG's Notifications integration to work with Notifications 4.x should be reverted because:

- The 4.x branch of Notifications is not maintained
- Notifications is listed as "Maintenance fixes only" and "Seeking new maintainer" status. This is confirmed by Jose Reyero in comment #31:
- The 4.x branch of Notifications has a non-trivial amount of bugs, including critical bugs with the upgrade path from 2.x. This is reflected in the present issue where several folks have said that their site no longer sends notifications.
- The 2.x branch of Notifications has > 13,000 site installs while the 4.x branch has ~1,000.

If we want to provide 4.x support, let's do so after 4.x is more stable and has developer heft behind it. Until then, having this functionality be broken seems like a release blocker for OG.

this note from Ezra sounds really good and reasonable to me.

Yes, this is my intent. I am concerned that we will end up reverting and find some bugs/feature requests that were punted in favor of a 4.x upgrade, but 4.x is simply not stable enough for OG 2.2.

subsribe

@RJL - Please do not post subscribe comments; use the 'follow' button at the top of the page instead.

Updating issue title and assigned field to reflect comments #31+.

Updating priority and adding the "Release blocker" tag.

@ezra-g appreciate the help, but I decided to split reverting to #1340638: Revert Notifications 4.x upgrade so this issue can remain focused on any further efforts at an upgrade.

resetting priority per 39.

So, this seems to be quite the spaghetti of complex inter-relations, and the activity has dropped off on OG+Notifications+Messaging in D6. Can anyone explain where this is left off, and what the best possible, stable-enough combination of these modules on D6 currently is?

Most of the attention is going to 7 so hard to tell what the best combination is for 6 at the moment. I can post my working combination on a couple of my old 6 sites a little bit later

OG 6 currently supports Notifications & Messaging 2.x. This issue is what you should pick up if you want to drive toward stable 4.x compatibility.

This is my current working combination in all of my D6 sites:

OG 6.x-2.1
Messaging 6.x-2.4
Notifications 6.x-2.3

If moving between versions some tables get messed up and the templates for OG notifications might not work properly.

Cheers,

Raul

After more than 2 years, any hope this will be solved anytime soon?
Maybe the branch 4 of Notifications is intended to be dropped if no more care is dedicated on OG integration?

I created a patch to fix OG_Notifications to work better with Notifications 6.x-4.x

#2646394: Support latest Notifications 6.x-4.x-dev

Current status is emails now send, but the template is not working correctly (it's using notification-event template instead of the og-notifications templates, but my understanding is that this has always been a bit of a problem. I wonder if this actually works on the notifications 6.x-2.3 setup mentioned in comment #44.

This version of Drupal is not supported anymore. If this is still an issue in the 8.x-1.x branch, please open a new up-to-date ticket. Closing.