Drupal 7 introduces a better library management in core, see http://engineeredweb.com/blog/10/5/3-tips-using-external-libraries-drupal

The existing integration with Drush should be updated to account for this, so that Drush knows where to download the library.

See also the contrib module http://drupal.org/project/libraries

CommentFileSizeAuthor
#2 rdfx-801690.patch1.7 KBRemon
#1 rdfx-801690.patch1.49 KBRemon

Comments

Remon’s picture

Remon commented
StatusFileSize
new rdfx-801690.patch1.49 KB

Hi scor,
I've attached a patch that enabled downloading arc2 in sites/all/libraries, if libraries module is enabled.

Remon’s picture

Remon commented
Status: Active » Needs review
StatusFileSize
new rdfx-801690.patch1.7 KB

Re-rolled the patch to work with latest RDF module.

scor’s picture

scor commented
Status: Needs review » Needs work 
+++ drush/rdfx.drush.inc	18 Oct 2010 17:34:57 -0000
@@ -69,20 +69,28 @@
+  elseif(module_exists('libraries')) {
+    $path = 'sites/all/libraries';

The libraries API includes a libraries_get_path() function, using this function would avoid to hard code the path sites/all/libraries

Remon’s picture

Remon commented

function libraries_get_path takes library's name as an argument, I think that it is not meant to return libraries path but a specific library path

scor’s picture

scor commented
Status: Needs work » Active
Issue tags: +Libraries

Remon: you're totally correct!. I've committed your patch #2 at http://github.com/scor/rdf/commit/a9b453663cdced68f31e4531602c45f637713af7 which takes care of the download at the correct location for Libraries.

I'm keeping this issue open and marking it Libraries so it can be continued to describe the ARC2 library for other modules to use.

Remon’s picture

Remon commented

Actually, hook_requirements should be implemented as well, since ARC2 is dependency for almost all RDFx functions. a REQUIREMENT_ERROR status should be returned as long as arc2 library is not downloaded.

Remon’s picture

Remon commented
Assigned: Unassigned » Remon
scor’s picture

scor commented

Remon, would you like to create a separate issue for the hook_requirements? It's not really related to libraries... but necessary nonetheless.

Remon’s picture

Remon commented
Assigned: Remon » Unassigned

I totally agree with this, will be creating another issue.

Anonymous’s picture

Anonymous (not verified) commented

scor, is this still active? It seems like this was committed.

scor’s picture

scor commented
Title: Streamline library support for ARC2 » Integrate the Libraries API
Status: Active » Closed (fixed)

you're right, this is fixed.

milesw’s picture

milesw commented
Project: Resource Description Framework (RDF) » RDF Extensions