CVS edit link for josegabriel.st

I've created a module which allows WYSIWYG editor to work on Panels. You can see the issue here http://drupal.org/node/235764. I would like to upload this module. Thanks!
CommentFileSizeAuthor
#1 wysiwyg_panels_2.1.zip1.91 KBruloweb

Comments

ruloweb’s picture

Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new1.91 KB

I've attached the module.

Thanks!

--
José Sánchez.

avpaderno’s picture

Status: Needs review » Needs work

Hello, and thanks for applying for a CVS account. I am adding the review tags, and some volunteers will review your code, pointing out what needs to be changed.

As the feature report for the module is still open (and its status is needs work), I wonder why you didn't attach the code to that queue. What would happen if somebody provide a patch for WYSIWYG, and the current maintainer applies it to the module? The new module would duplicate the code provided by the main module.
I would like to see more cooperation.

avpaderno’s picture

Issue tags: +Module review

I forgot the review tags.

sun’s picture

Hm. I have no idea what to do with this. Truth is, it's impossible to properly tackle the referenced issue in Drupal 6. Only Drupal 7 will hopefully allow us to lazy-load JS/CSS on demand.

The code that has been attached here is the same code of the issue. However, it's a dirty hack, which first of all, only implements custom code and support for particular editors (fckeditor/ckeditor), and secondly, will very likely trigger bugs and incompatibilities in other modules and scripts.

But then again, some people seem to report that this code might work.

Fact is, it's a custom workaround for a problem that cannot be solved easily in a generic way (until D7). The workaround is limited to certain editors, and also limited to support a certain contributed module only (Panels).

The code does not deserve an own project/custom module on d.o. And the code most probably also won't make it into Wysiwyg module (as is).

avpaderno’s picture

I take that even if the module would be created, it would simply move the issues from Wysiwyg to this new module without to resolve them completely (or for all the users).

I agree with sun about the module not deserving its own project. As the code is simply taken by the code reported in an issue queue, the user didn't show he understood how a module must be coded.

ruloweb’s picture

Hi all,

make a lot of sense, I applied to CVS account because some people ask me to create the module.

Thanks for the review!

--
José Sánchez

avpaderno’s picture

Status: Needs work » Closed (won't fix)

As per previous comments, I am changing the status of this application.

xtfer’s picture

If anyone is looking for this *not* module, its available on github...

http://github.com/jbylsma/wysiwyg_panels

harking’s picture

@xtfer: Thanks for putting it up in some sort of VCS.

jcisio’s picture

Component: Miscellaneous » miscellaneous

Now it's time to move it back to drupal.org if someone has the courage!

avpaderno’s picture

Component: miscellaneous » new project application
Issue summary: View changes
avpaderno’s picture

Status: Closed (won't fix) » Closed (duplicate)
Related issues: +#1047156: josegabriel.st [josegabrielst]