Closed (duplicate)
Project:
Drupal.org CVS applications
Component:
new project application
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
19 May 2010 at 22:28 UTC
Updated:
18 Apr 2019 at 20:17 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
ruloweb commentedI've attached the module.
Thanks!
--
José Sánchez.
Comment #2
avpadernoHello, and thanks for applying for a CVS account. I am adding the review tags, and some volunteers will review your code, pointing out what needs to be changed.
As the feature report for the module is still open (and its status is ), I wonder why you didn't attach the code to that queue. What would happen if somebody provide a patch for WYSIWYG, and the current maintainer applies it to the module? The new module would duplicate the code provided by the main module.
I would like to see more cooperation.
Comment #3
avpadernoI forgot the review tags.
Comment #4
sunHm. I have no idea what to do with this. Truth is, it's impossible to properly tackle the referenced issue in Drupal 6. Only Drupal 7 will hopefully allow us to lazy-load JS/CSS on demand.
The code that has been attached here is the same code of the issue. However, it's a dirty hack, which first of all, only implements custom code and support for particular editors (fckeditor/ckeditor), and secondly, will very likely trigger bugs and incompatibilities in other modules and scripts.
But then again, some people seem to report that this code might work.
Fact is, it's a custom workaround for a problem that cannot be solved easily in a generic way (until D7). The workaround is limited to certain editors, and also limited to support a certain contributed module only (Panels).
The code does not deserve an own project/custom module on d.o. And the code most probably also won't make it into Wysiwyg module (as is).
Comment #5
avpadernoI take that even if the module would be created, it would simply move the issues from Wysiwyg to this new module without to resolve them completely (or for all the users).
I agree with sun about the module not deserving its own project. As the code is simply taken by the code reported in an issue queue, the user didn't show he understood how a module must be coded.
Comment #6
ruloweb commentedHi all,
make a lot of sense, I applied to CVS account because some people ask me to create the module.
Thanks for the review!
--
José Sánchez
Comment #7
avpadernoAs per previous comments, I am changing the status of this application.
Comment #8
xtfer commentedIf anyone is looking for this *not* module, its available on github...
http://github.com/jbylsma/wysiwyg_panels
Comment #9
harking commented@xtfer: Thanks for putting it up in some sort of VCS.
Comment #10
jcisio commentedNow it's time to move it back to drupal.org if someone has the courage!
Comment #11
avpadernoComment #12
avpaderno