Posted by serbanghita on May 20, 2010 at 6:39pm
| Project: | Drupal.org CVS applications |
| Component: | Miscellaneous |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
| Issue tags: | module review |
Issue Summary
I'm actively using Drupal (check http://ghita.org). I'm planning all my website projects only on Drupal and i need to take initiative on some new module ideas that i have discussed with the community.I've worked with Drupal first time in 2001 when it was called Drop.
Thanks!
Comments
#1
I have attached the module which extends Feeds module.
I am planning on working with moonray http://drupal.org/user/68275 on this project.
Thanks!
#2
Hello, and thanks for applying for a CVS account. I am adding the review tags, and some volunteers will review your code, pointing out what needs to be changed.
As per http://drupal.org/cvs-application/requirements, the motivation message should be expanded to contain more details about the features of the proposed module/theme; for modules it should include also a comparison with the existing solutions, while for themes a screenshot is also required.
#3
Here is my motivation for this module:
-----------------------------------------------
Feeds Social
Agregate feeds from popular social networking sites directly into nodes.
Module name: Feeds Social
Dependecies: Feeds, CCK
Utility/Goals: Adds 'Twitter Parser' and 'Facebook Parser' to 'Select a parser' section in Feeds configuration. Lets user select the appropiate parser and then map the fields available.
-----------------------------------------------
alex_b the maintainer of http://drupal.org/project/feeds suggested that i should create a module which extends Feeds to do this. When this module reaches maturity we might propose integrating it directly into Feeds.
@kiamlaluno thanks for your reply!
PS: i will create a README.txt with the description of the project.
#4
Thanks for the reply.
#5
Please review, me and moonray would like to work directly on Drupal CVS.
Thanks!
#6
subscribe.
#7
- added views support; it automatically installs a new view for the Twitter nodes created from feed
- will add INSTALL documentation and README this weekend
#8
Subscribing.
#9
This is looking good by and large, I'd like to see a solid README file explaining the purpose of the module and how to install it...
#10
Thanks @alex_b!
I am going to write a README, i delayed this because i wanted to make sure that this module is really useful, and i wanted to think at the direction it has to go.
Meanwhile i've written a little intro at http://ghita.org/drupal-feeds-social.html and updated the module with Facebook Importer.
We need testers from the community, i will deliver the README at the beginning of the next week.
Thanks!
#11
#12
- bugfixes, added TODO, README, LICENSE
#13
Interesting module, will this be added to d.o. soon?
#14
Strange, I used the module from #12 and right after I enable the module I get 2 notices:
-"Missing Feeds plugin FeedsTwitterParser. See feed_twitter. Check whether all required libraries and modules are installed properly."
-"Missing Feeds plugin FeedsFacebookParser. See facebook. Check whether all required libraries and modules are installed properly."
When I add a twitter feed, I get an error:
"Importing
An error has occurred.
Please continue to the error page"
The "Error" page just shows the same notices again. I would supposer I'm indeed missing the libraries.
Thanks in advance for the help, and thanks for sharing your code!
UPDATE:
So I got thru that issue now I'm getting
Error: "Serialization of 'SimpleXMLElement' is not allowed" on import.
UPDATE#2:
Seems like I've figured out my problem, but I think I opened this ticket in the wrong place (This seems to be a ticket applying for CVS account.), and for that I apologize. I'll withhold posting my findings here because of that. If anyone is curious, please contact me, or tell me where to move/repost this issue.
#15
@Hanno what is d.o. ? I noticed you called this contribution 'Social Parser'. I find this a good name for the module. I gave it 'Feeds Social' name so i can have all the files starting with feeds_*.
@jguffey please share here your solution to the problem. What version of Feeds are you using? My application is directly related to this module and you are on topic. Thanks!
I like that people are starting to give attention to this module proposal, i will work at Picasa and Flickr integration and post them soon.
#16
@serbanghita I'll try to walk you thru my issue.
I am using Feeds 6.x-1.0-beta4, and the Feeds Social plugin-module you rolled in #12. After trying different versions of Feeds and the Feeds Social plug in, (I tried Feeds 6.x-1.0-beta1, and Feeds Social modules in comments #12, #10, and #7) I finally decided to edit the Feeds Social module directly.
All this was running on my PHP Version 5.3.2-1 ubuntu4.2 server.
I pin-pointed my problem to FeedsTwitterParser.inc lines 21 thru 36 (the for loop that loops thru each XML entry). While the $items array was being built, for some reason SimpleXMLElement Objects were being put in the array. After casting each value as a string before storing it as the key in the $items array, I was getting the expected results from the plugin.
Before casting the items as strings, The parser would only import 1 tweet, and that tweet was missing fields. I think what was happening was the parser was putting SimpleXMLElement Objects into the items array, and so the parse function handed off an array that was useless to the next steps.
I've included the modified FeedsTwitterParser.inc. I'm not using it, but I i assume the Facebook parser was suffering the same problem.
#17
d.o is drupal.org.
Let's remember this is not a debugging session, but a CVS application. The purpose is to verify the proposed code follows the coding standards, the code doesn't have security issues, and it correctly uses Drupal API.
#18
Yeah, Sorry for putting the bug here.
This thread is 4 months old now, how long until this guy gets his CVS account so we can make a proper page for this module? So far it's the best solution I've found for adding twitter streams into Drupal IMHO.
#19
I gave the code a look over and it's well commented and readable and follows Drupal coding standards. I'm not very good at the security checking part but I don't see anything jumping out at me. It looks like the author put a lot of work into it, the code looks good, and there's already people wanting to use this module. Account approved.
Michelle
#20
@jguffey - thanks a lot for your debug, i will apply fixes tonight
@kiamlaluno - sorry man but where else could we discuss about this module :)
@Michelle - thanks for the review!
#21
http://drupal.org/project/feeds_social - please post any bugs and requests there. The first dev snapshot will be available in couple of hours.
#22
Great, this module is now added to the Feeds documentation.
#23
Automatically closed -- issue fixed for 2 weeks with no activity.