[owner] = [poster] ?

I can't reproduce this, and I find it very difficult to believe that this is happening. The values for the owner and poster are directly pulled right out of the {facebook_status} table in the database for all tokens in the Activity templates, so if the status is recorded correctly, what you're reporting shouldn't be possible. And it sounds like the status is recorded correctly.

I don't understand what you mean by this:

Maybe this info helps. The same tokens used in Fbsmp template works.

By the way, you should be using [status-unformatted] instead of [status-raw]. [status-raw] is unfiltered and could contain dangerous output.

Still can't reproduce this. Will think some more about why it might be happening.

Yeah, I'm going to chalk this up to a translation error. I talked to publicmind, who I'm mentoring for the FBSMP project, and he can't reproduce it either; plus FBSMP actually uses FBSS' own tokens so the values should be exactly the same unless they were translated differently.

Those records are correct. The pattern just has to do with which field you're using (module-dependent) and the s:199 stuff just means "a string with 199 characters."

The title should have nothing to do with it.

It may well not be related to translation, but whatever it is, it's not something that happens in a standard install. I don't know what to tell you to do other than try reinstalling, clearing caches, and reconstructing your Activity templates.

I'm not using the very latest Activity dev at the moment, but I really doubt that's the issue.

This just happened to me as well so I can verify it has nothing to do with translation.

template is "You posted on [owner]'s wall" and the result is saying I posted on my wall.

shows that way on both the maintenance page as well as my page and block views

I'd be happy to help troubleshoot but not sure where to start. Just downloaded the mod tonight.

I mean, look, here's the code that gets the value for the token:

$owner = _facebook_status_user_load($status->uid);
$values['owner'] = theme('username', $owner);

If the status appears on the correct profile, then the value for UID is correct, and that value represents the owner, and the [owner] token is populated using the owner variable.

The only way I can think of that this wouldn't be the case is if some other module was overriding the [owner] token, which I'm not even sure is possible.

If you'd like to debug, you can edit facebook_status.module and add drupal_set_message("Owner UID: $owner->uid"); after line 1983 (assuming latest dev). Then try posting a status on someone else's profile and see what it says.

(Also -- make sure you're using the fbss_submitted_other template. If you're using the fbss_submitted template, then [owner] and [poster] will be the same.)

ok I deleted the old template and started a new one making sure I selected fbss_submitted_other

In the poster message the template is "You posted on [owner]'s wall"

when I posted on another user's wall the activity reads that I posted on my wall.

entering code above after line 1983 $owner = _facebook_status_user_load($status->uid); when I post on a users wall I get the following output (i am user 24)

* Owner UID: 24
* Owner UID: 24
* Owner UID: 24
* Owner UID: 33

seems odd to have 4 entries. btw when I delete a status it tells me twice that it was deleted.

Both FBSS and Facebook-style Micropublisher have default status deletion messages through Rules, which is probably why you would see two delete messages. That's a minor bug in FBSMP -- you can just disable one or both of them.

The 4 messages would be from 4 different times values were retrieved for tokens -- probably for your rule, an FBSMP rule, Pathauto analysis... I'm not sure what else, but not anything FBSS causes by default and not anything to worry about.

Try putting drupal_set_message("Owner UID: $status->uid"); on line 1761 of facebook_status.module.

done and when I posted on another user's wall the message is "Owner UID: 35" which is the uid of the person I posted on.

Well I don't know what to tell you then. FBSS literally passes $status (which worked correctly for you) directly to the Trigger/Action system which should feed it unchanged right back to the Token integration. Whatever is causing the change in between is very weird, and not due to FBSS, and honestly I have no idea how to debug it, but I definitely can't reproduce it.

Thanks for trying ICY I will pass this forward to the activity maintainers.

Thanks to IceCreamYou for having redirected me to this issue.
I have the same problem as in the title and I described it here: http://drupal.org/node/831296

Apologize for not having being able to find this issue earlier.

Now, I am eagerly waiting for a solution to this problem.

Cheers.

A.M.

I am having the same issue with no solution.

I posted it here http://drupal.org/node/861662 (marked as double post).

I have the same issue on my D6 installation: I am using italian language, and poster seems to be shown as owner every time, even when I try post with one user on another's wall.

Baff, I don't see your message here, but I read it via the notification email.

I am at number #20 and I do HAVE English as the first language.

Thanks.
AM

I will define the problem and share the source.

Activity module assumes that each object in the $context array has a uid tied to it and that uid corresponds to the user to get the message. It also assumes that the primary object's uid (in this case facebook_status) is the person who did the thing. Unfort, it actually corresponds to the persons wall which is not what Activity assumes. And thus it adjusts that uid to be GLOBALS[user]->uid because, unless it was specified, the person 'doing' the activity is the GLOBAL user. And the only time it is really specified is when its rebuilding the activity from scratch.

And of course, to throw another wrench, Activity2 also makes sure that the 'actor' that was specified (or GLOBAL user) is the uid on the primary object.

All of this comes down to the fact, that the primary object's uid does not match the excepted uid (GLOBALS user) and thus it is adjusted to match.

This is the ugliness I am trying to address in the next version just because unless people are intimate with Activity code, they won't understand. Its a DX fail of epic proportions.

Thanks for your insight Scott.

The thing is, this problem doesn't happen for most people. I personally haven't been able to reproduce it. Are you saying it's a bug in the Activity API where it assumes the wrong UID under certain circumstances, even when the right one is passed?

Also, is there an issue I can follow so I can keep track of when this change is made to the Activity API, or will you update here?

Nothing wrong with the Activity API other then its aweful DX. The object has a uid property, but when the owner isn't the poster, Activity 'fixes' the object which in turn breaks the token. It will happen 100% of the time if you do a template like so for Facebook status other submit: http://skitch.com/supermanscott/d21h2/edit-contrib-d6

Well it's been too long since I worked with the Activity API so I don't grok for sure what's going on there, but it looks to me like FBSS always passes in the right UID. I mean, obviously something is wrong somewhere, and it may very well be on the FBSS side, but I'm just not seeing it.

Scott, how do you suggest moving forward? Is it worth waiting for the next iteration of the Activity 2 API, or is there a simple fix now?

Hi-just wondering if there was any work around in place for this yet?

THANKS

any update on this yet?

is this put on hold until the release of the new API> or is there a workaround yet for this?

Any news?

Any update on this? I am also having the same issue

I have the same problem!
Anyone has a solution for this yet?

Hi there,

Here's a small fix/workaround for those (like me) who need this solved asap:

On facebook_status.module file line # 1878 in function facebook_status_activity_info(), change this line:

<?php

$info->objects = array('Owner' => 'facebook_status', 'Poster' => 'poster');

?>

with this one:

<?php

$info->objects = array('Owner' => 'owner', 'Poster' => 'poster');

?>

Then add the following hooks on a custom module of yours:

<?php

function mymodule_activity_objects_alter(&$token_objects, $activity_type) {
	if ($token_objects['facebook_status']) {
		$token_objects['facebook_status']->uid = $token_objects['owner']->uid;
	}
}

function mymodule_activity_record_alter(&$record, $context) {
	if ($record->type == 'facebook_status') {
	  $record->uid = $context['owner']->uid;
	}
}

?>

That should get you going until something better is available.

I suspect that it breaks other things, but if other people can confirm the solution in #35, I will try to translate it into a fix.

Again, Scott, it would be great if you could chime in here...

You were right IceCreamYou, it does break other things...

Forget the change to facebook_status.module. I think I've got it working with just the two hooks:

<?php

function mymodule_activity_objects_alter(&$token_objects, $activity_type) {
	if ($token_objects['facebook_status']) {
		$token_objects['facebook_status']->uid = $token_objects['facebook_status']->owner->uid;
	}
}

function mymodule_activity_record_alter(&$record, $context) {
	if ($record->type == 'facebook_status') {
	  $record->uid = $context['owner']->uid;
	}
}

?>

I will keep testing, if all is good maybe they can be incorporated into facebook_status somewhere. Any improvements are welcome.

Great job 5t4rdu5t! I believe you have fixed the problem.

Interesting. I don't see a way to solve this that doesn't involve using alter hooks, so if I can get one more person to confirm that the solution in #37 works, I'll just go ahead and commit that code to the module.

I was experiencing the same problem. I made a custom module with the code from #37 and it fixed the problem for me as well!! Very glad I found this post.

where do I put the code from #37? or how do I quickly create a custom module to put the code into?

Committed #37 to dev. I haven't tested it, so please try it and report if it doesn't work or causes any other problems.

I'm not marking this "to be ported" because I suspect that the changes in FBSS 3.x should already fix this problem.

I checked out this post to create my custom module: http://drupal.org/node/416986. All in all it only took about 20 minutes to test this out.

IceCreamYou, I'm seeing Feb 1 as the latest dev. Am I not looking in the right place? Thanks

Whoops, my bad. I made the change but forgot to commit it. (Committed now.)

To be clear, when using the (new) latest dev, you shouldn't need a custom module to make this work.

Got rid of my custom module and updated to the latest dev, works like a charm. Thanks again.