Posted by Bobby 76 on May 24, 2010 at 10:56am
5 followers
| Project: | Views Slideshow |
| Version: | 6.x-2.1 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
Hi
I upgraded from 2.0 to 2.1 and started to get problems with javascript not running properly. I had a slideshow in a block in the footer so it would also show on a node edit page and I found the javascript would not work preventing me from making updates to the content on the node edit page ie publish it etc. Also the slideshow was not functioning properly. This was not universal and only occurred on certain pages.
Looking at the error console in Firefox I noticed "Settings.advanced.split is not a function"
var advanced = settings.advanced.split("\n");
Sorry can't give much more info than this as don't really know Javascript.
My solution to fix the problem was to revert back to 2.0
Comments
#1
Try resaving your slideshow settings. If that doesn't work send me your settings output from the page source.
#2
I am having the same issue and had to revert to 2.0.
Tried page flush/disable caching, resaving vews options for the slideshow. Nothing helped.
The slideshow works, if it is running alone on a single page. However, I have 4 instances of the slideshow on a single page in a setup like: panels->4xviews (uses slideshow with different arguments for source data)
What do you mean by "send me your settings output from the page source"?
#3
I tried resaving my slideshow settings and switching them to unordered but this made no difference.
I also have more than one slideshow running on a single page but this was not a universal problem. I could have some pages with multiple slideshows running and working perfectly whilst other pages had multiple slideshows running and not working properly.
#4
So in the header of your source you will see something like this in between script tags. If you could post that here that would be awesome.
<!--//--><![CDATA[//><!--jQuery.extend(Drupal.settings, { "basePath": "/vs/", "viewsSlideshowSingleFrame": { "#views_slideshow_singleframe_main_slideshow-page_1": { "num_divs": 10, "id_prefix": "#views_slideshow_singleframe_main_", "div_prefix": "#views_slideshow_singleframe_div_", "vss_id": "slideshow-page_1", "timeout": "5000", "sort": 1, "effect": "fade", "speed": "700", "start_paused": 0, "delay": "0", "fixed_height": "1", "random": "0", "pause": "1", "pause_on_click": "1", "remember_slide": 0, "remember_slide_days": "1", "controls": "1", "pager": "2", "pager_type": "Thumbnails", "page_hover": 2, "pager_click_to_page": 1, "image_count": "2", "nowrap": "0", "sync": "1", "advanced": "", "ie": { "cleartype": "false", "cleartypenobg": "false" }, "pager_hover": "1" }, "#views_slideshow_singleframe_main_slideshow-block_1": { "num_divs": 2, "id_prefix": "#views_slideshow_singleframe_main_", "div_prefix": "#views_slideshow_singleframe_div_", "vss_id": "slideshow-block_1", "timeout": "5000", "sort": 1, "effect": "fade", "speed": "700", "start_paused": 0, "delay": "0", "fixed_height": "1", "random": "0", "pause": "1", "pause_on_click": "0", "remember_slide": 0, "remember_slide_days": "1", "controls": "0", "pager": "0", "pager_type": "Numbered", "page_hover": 2, "pager_click_to_page": 0, "image_count": "0", "nowrap": "0", "sync": "1", "advanced": "", "ie": { "cleartype": "true", "cleartypenobg": "false" }, "pager_hover": "1" } } });
//--><!]]>
#5
here it goes:
jQuery.extend(Drupal.settings, { "basePath": "/", ...[other modules settings]..., "viewsSlideshowSingleFrame": { "#views_slideshow_singleframe_main_slideshows-block_2": { "num_divs": [ 10, 10, 10, 10 ], "id_prefix": [ "#views_slideshow_singleframe_main_", "#views_slideshow_singleframe_main_", "#views_slideshow_singleframe_main_", "#views_slideshow_singleframe_main_" ], "div_prefix": [ "#views_slideshow_singleframe_div_", "#views_slideshow_singleframe_div_", "#views_slideshow_singleframe_div_", "#views_slideshow_singleframe_div_" ], "vss_id": [ "slideshows-block_2", "slideshows-block_2", "slideshows-block_2", "slideshows-block_2" ], "timeout": [ "5000", "5000", "5000", "5000" ], "sort": [ 1, 1, 1, 1 ], "effect": [ "fade", "fade", "fade", "fade" ], "speed": [ "700", "700", "700", "700" ], "start_paused": [ null, null, null, null ], "delay": [ "0", "0", "0", "0" ], "fixed_height": [ "1", "1", "1", "1" ], "random": [ "0", "0", "0", "0" ], "pause": [ "1", "1", "1", "1" ], "pause_on_click": [ "0", "0", "0", "0" ], "remember_slide": [ 0, 0, 0, 0 ], "remember_slide_days": [ 1, 1, 1, 1 ], "controls": [ "0", "0", "0", "0" ], "pager": [ "0", "0", "0", "0" ], "pager_type": [ "Numbered", "Numbered", "Numbered", "Numbered" ], "page_hover": [ 2, 2, 2, 2 ], "pager_click_to_page": [ 0, 0, 0, 0 ], "image_count": [ "0", "0", "0", "0" ], "nowrap": [ "0", "0", "0", "0" ], "sync": [ "1", "1", "1", "1" ], "advanced": [ "", "", "", "" ], "ie": { "cleartype": [ "true", "true", "true", "true" ], "cleartypenobg": [ "false", "false", "false", "false" ] }, "pager_hover": [ "2", "2", "2", "2" ] } } });
#6
Ok are you using the same block multiple times on the same page?
edit: ahh I see you do. Well this is a predicament. On the one hand if I keep it the same I save some caching issues. On the other hand if I change it, it will fix the multiple blocks on the same page.... I'll have to really think about this.
#7
#8
Can you please try this patch? It should take care of your issue.
#9
i'm getting the same error. Applied patch but still have the error:
TypeError: Result of expression 'settings.advanced.split' [undefined] is not a function.
views slideshow.js : 100
I have a gallery page with thumbnail hover breakout's for selecting which image to display. The slideshow isn't playing and onclick events not working
#10
@hixster Do you have multiple of the same slideshow on the same page? Can you send your settings like notabenem did above? Are you doing any special theming code changes? Do you have a test site I can look at?
#11
Hey redndahead, just one slideshow per page, the slideshow is created out of CCK multi image field on the page node, and embedded into the page using NID argument with Node ID from URL. Other than that, no theming mods.
An example can be found at: http://lightflows.co.uk/projects/web-design/tatlock-design
#12
Hi, I have applied the patch and it seems that it works. Will double-check it within a day or two. Thanks for the patch.
Update: it still works! Good job. :)
#13
Any update on this, my site is currently broken. I tried switching the slideshow to singleframe, but still no joy.
It's strange because the slideshow on my homepage is working just fine
#14
Sorry for taking so long. With the patch above it should make it darn near impossible to have the same weird settings you are reporting. I'm going to commit this patch sometime soon with another and then maybe you can try the latest dev release. Make sure caches are clear.
I'll post here when the new dev release is out.
#15
o.k., cool thanks for the update
#16
This has been committed and I am marking as fixed.
@hixster can you please open a new issue if you continue to have issues with tomorrows dev release.
Thank you and don't worry I'm sure we'll figure out your issue. :)
#17
Automatically closed -- issue fixed for 2 weeks with no activity.