Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.
I've reviewed and located the cause of this issue
right now I can provide a patch that will make BUEditor work
but this is only temporal, I should come with something else
(if you check the patch, you'll see that there is only a line being commented out, to avoid switching back ids)
This works for me too, thanks. However, the patch isn't general in it's current form - there should be some check if BUeditor is used and only then should _comment_driven_restore_ids be skipped. Or _comment_driven_restore_ids needs to be reviewed - is there a bug?
@arhak: Just for the record, the reason I wrote "the patch isn't general in it's current form" was to justify that I changed status from "reviewed & tested by the community" to "needs work". Your patch/comment is very clear about not being a permanent fix.
fyi , The patch causes breaks Notifications posted from comments. Once you disable the line , selection of notifying users don't work ( e.g. everyone who uses OA). I suspect that it can cause issues with other modules that their data interfere with driven comment. It took me a while to figure it out so if anyone faces similar behavior, just revert.
Comments
Comment #1
ManyNancy commentedThis is a little strange since BUEditor works on any textarea via JS.
Comment #2
arhak commentedit might be related with #747616: Compatibility with WYSIWYG
Comment #3
ManyNancy commentedI can't follow the discussion on the WYSIWYG issue. Will there be a change to this module?
Comment #4
arhak commentedI wasn't expecting you to follow the other issue, just taking a note for myself.
I hope so, but I haven't reviewed this yet.
Comment #5
ManyNancy commentedOK, thanks a lot. :)
Comment #6
arhak commentedI've reviewed and located the cause of this issue
right now I can provide a patch that will make BUEditor work
but this is only temporal, I should come with something else
(if you check the patch, you'll see that there is only a line being commented out, to avoid switching back ids)
Comment #7
ManyNancy commentedThis works for me, thanks.
Comment #8
hansfn commentedThis works for me too, thanks. However, the patch isn't general in it's current form - there should be some check if BUeditor is used and only then should _comment_driven_restore_ids be skipped. Or _comment_driven_restore_ids needs to be reviewed - is there a bug?
Comment #9
arhak commentedit is a temporal workaround (as noticed in the patch's filename)
indeed, it needs to be revisited
Comment #10
arhak commentedif I recall correctly, _comment_driven_restore_ids was born as a proposal for #733354-8: parents' names should be form_clean_id compliant (i.e. no colon) and there is no other (known) purpose for it
(see also #928812-11: Compatibility with CKEditor)
more likely the proper answer lies behind #747616-5: Compatibility with WYSIWYG
Comment #11
hansfn commented@arhak: Just for the record, the reason I wrote "the patch isn't general in it's current form" was to justify that I changed status from "reviewed & tested by the community" to "needs work". Your patch/comment is very clear about not being a permanent fix.
Comment #12
charos commentedfyi , The patch causes breaks Notifications posted from comments. Once you disable the line , selection of notifying users don't work ( e.g. everyone who uses OA). I suspect that it can cause issues with other modules that their data interfere with driven comment. It took me a while to figure it out so if anyone faces similar behavior, just revert.