Closed (fixed)
Project:
Syntax Highlighter
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
11 Jun 2010 at 16:16 UTC
Updated:
6 Dec 2010 at 23:30 UTC
Jump to comment: Most recent file
Comments
Comment #1
twiik commentedI refuse to believe you are using that port all the time in its current form. :)
Because it didn't work at all for me until I made these changes according to this http://drupal.org/node/224333#drupal_add_js_options :
Removed
, 'module':Before I removed 'module' no styles were added and I received no syntax highlighting. Now it works perfectly.
Great port btw. :)
Comment #2
ao2 commentedsubscribe
Comment #3
scw commentedthx it works...
had to remove line #322
Comment #4
tancThanks for the port atchijov. It works great with the modifications in #1 and #3. Attached is a patch with both the changes. I found the module worked fine with css aggregation off but when it was turned on the styles weren't being added. #1 fixes that particular issue. #3 fixes compatibility with Drupal 7 beta 1, although I don't know if there are implications with removing file_directory_path() in line 322 (not sure what it does).
Everything seems to be working nicely now. Any chance of pushing out a 7.x-1.x-dev release?
Comment #5
kostajh commentedI applied the patch from #4 to the original files in this thread and it works fine. The zip file attached here includes the patch from #4. Seems like it is ready for a dev release.
Comment #6
teiko commentedDoes someone adopted this Module, or is it allready stopped here ?
Greetings Chris
Comment #7
mattyoung commentedThe port to D7 involve more than just changing the call to
drupal_add_js(). Several other things need changing like the file api,file_scan_directory(), javascript behaviors etc. I would help me a lot if you make any change, make it against cvs head and give me patch file instead of zip file.Comment #8
mattyoung commentedD7 port is released