Add permission to edit comment settings

Very nice patch!

I have just updated the new permission name so that it becomes:

override NODE_TYPE comment settings option

Just to respect module's permissions naming conventions :-)

It's up to maintainers to decide.
Anyway, I hope one of these 2 patches get committed soon!

I have just committed this to the 6.x-1.11 release.

(Will patch D5 and D7 versions this week)

+    // Add access to the 'Comment settings' fieldset.
+    if (module_exists('comment') && isset($form['comment_settings']) && !user_access('administer comments')) {
+      $form['comment_settings']['#access'] = user_access('override ' . $node->type . ' comment settings option');
+    }

This should likely be using a bit-wise boolean operation instead of re-assigning #access since comment.module already assigns $form['comment_settings']['#access'] = user_access('administer comments'). So in the case the user has that base permission but not the override permission, their fieldset will go missing, when it should still be visible.

So in summary, the third line in the above code be:

$form['comment_settings']['#access'] |= user_access('override ' . $node->type . ' comment settings option');

Ah, hah I missed that condition, but I think we can just simplify it with an OR anyway. That's how we're currently using it. If a user does not have the 'override comment options' permission but does have some other permission or module that shows this setting it shouldn't clobber it; cooperation and not competition.

Hi, This is the patch for the D7 release - I've simply rewritten patches above for D7-dev

#9 works for 7.x-1.12

Hello,

I've used the last patch in comment #9 and I've solved a problem. If you apply this patch, sometimes this patch doesn't work because form comment settings is called before the others forms (for example before publishing options).

The solution is to modify call order of form with hook_module_implements_alter like that :

/**
 * Implements hook_module_implements_alter().
 *
 * Make sure that our form alter is called AFTER the same hook provided in xxx
 */
function override_node_options_module_implements_alter(&$implementations, $hook) {
  if ($hook == 'form_alter') {
    $group = $implementations['override_node_options'];
    unset($implementations['override_node_options']);
    $implementations['override_node_options'] = $group;
  }
}

After that, this patch is called normally.

Best regards.

Softwar

The patch is #9 doesn't apply to the latest 7.x-1.x version of ONO, so it will need re-rolling.

Hi,

I've created a patch to apply modifications in comment #9 in order to answer at comment #15.

Enjoy.

The patch in #16 works, although the module weight needs to be adjusted in order for it to do so.

As per #1090696: Reduce module weight, the default module weight is set to -1 so that it does not interfere with Date Popup Authored module, but I think if it's blocking ONO's core functionality, it should be set back and people can adjust module weights as per their own requirements.

The patch in #16 has been committed, along with some whitespace clean-up, and the module weight amendments.

I've added a new issue, #2561447: Add tests for comment settings, to add tests for this new option.