Hi,

Right after installing/enabling the module, if I set the "Form Type" option to "form" (in 'administer>settings>forward'), no forward elements appears near/in any node, even if in 'administer>settings >content types' admin section the 'Show forwarding link/form' is enabled for all node types, by default.

After studying the code, I think that line 361 in forward.module :
if (variable_get('forward_form_type', 'link') == "form" && !$node->in_preview && variable_get('forward_display_'. $node->type, '0') == 1){
should be:
if (variable_get('forward_form_type', 'link') == "form" && !$node->in_preview && variable_get('forward_display_'. $node->type, '1') == 1){

(in order to be uniform with the logic in other code-zones of the module ; i.e. consider a default value of 1, for 'forward_display_'-like variables not initialized in DB).

Please review this change and tell me if that's correct.

CommentFileSizeAuthor
#1 forward_form_fix.patch563 bytesdesignerbrent

Comments

designerbrent’s picture

StatusFileSize
new563 bytes

In the current version of the code that I downloaded this morning the line mentioned is actually line number 383. So far, this fix seems to have worked for me. I have attached a patch file for it.

john.oltman’s picture

Status: Needs review » Closed (won't fix)

4.x version no longer supported.