Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.The code defines the function theme_comment_preview, but it's never invoked. Looks like a small code oversight, fix appended.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | comment_preview_1.patch | 811 bytes | pasqualle |
| #1 | comment.patch_0.txt | 547 bytes | adixon |
| comment.previewfix | 506 bytes | adixon |
Comments
Comment #1
adixon commentedAnd here it is again in proper format.
Actually, since my original submission of this patch, I've been working on a theme to display the comments in the modern trendy way with collapsible fieldsets so you can hide the ones you don't want, etc. In the process, it looks to me like the core comment.module code could use some updating - the themeing functions are a bit of a confusing rats nest of interdependent functions. If anyone's interested, I'd be happy to submit them as theme snippets, or even as a replacement to the current set of defaults.
Comment #2
drummComment #3
bdragon commentedAutopatch Results for comment.patch_0.txt:
patching file comment.module
Hunk #1 FAILED at 1455.
1 out of 1 hunk FAILED -- saving rejects to file comment.module.rej
Comment #4
pasquallereroll
Comment #5
dvessel commentedI don't see how this fixes anything. What calls theme('comment_view').?
Comment #6
pasqualleI made a mistake in the reroll: the theme('comment_view') is removed in original patch. that should be the problem?
Comment #7
dvessel commentedI took a deeper look and theme_comment_preview no longer exists. It's automatically invoked from the form data. It's not idea and confusing but for now this is how it is.
Read here on how to override in situations like this. I'm pretty sure it should apply.
http://drupal.org/node/173880#theme-registry-register-manually