Closed (fixed)
Project:
Project
Version:
4.7.x-1.x-dev
Component:
User interface
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
8 Sep 2006 at 19:08 UTC
Updated:
26 Dec 2006 at 17:00 UTC
Jump to comment: Most recent file
For e.g. a page like http://drupal.org/project/Modules/category/61 provides no indication to the user as to which category he/she is browsing.
-K
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | project_browse_category_title.patch.txt | 2.31 KB | dww |
Comments
Comment #1
dwwsince we reuse the
$termvariable in this function, i renamed the main one (module vs. theme, etc) to$typeto match "project type", which is how we tend to refer to this particular taxonomy. this way, down in the function when we need it, we still have this object, instead of having clobbered it in the mean time.Comment #2
Zen commentedWhy does $type->name use filter_xss instead of check_plain?
Looks fine visually otherwise.
-K
Comment #3
dwwre:
filter_xss()vs.check_plain():at first, the answer was going to be "since that's what the code used to do and i'm just changing the variable name". however, it's a very good question, so i did a little CVS archeology and found this:
clearly this was intentional, and it's just as safe, so i'm not going to undo this...
thanks for keeping me honest, though! ;)
cheers,
-derek
Comment #4
dwwcrap, this breaks the regular http://drupal.org/project/Modules/name page. :(
Comment #5
dwwfound, fixed, committed to DRUPAL-4-7--2 and DRUPAL-4-7, and installed on d.o.
Comment #6
Zen commentedI was asking about $type->name, not description.
-K
Comment #7
dwwahh, sorry, i missed that (clearly stated) bit of info when i read this before. good point. ;) committed the change to DRUPAL-4-7--2 as revision 1.239.2.13.2.22.
thanks!
-derek
Comment #8
dwwgrr, i managed to break browsing by category now. :( it's currently displaying all modules, not just the ones from the category you select. i have a hunch, stay tuned for a patch.
Comment #9
dwwbug fixed via http://drupal.org/cvs?commit=47875 and installed on d.o.
Comment #10
(not verified) commented