Make hook_apachesolr_update_index() more generic so it can be used e.g. for file attachments, etc [#832118]

ideally we should have a more generic hook that can alter documented created from or related to a specific node.

For 6.x-1.x I'm not sure sure a change is in scope - we could basiclaly use hook_apachesolr_update_index() if we indicate that modules implementing it may need to check $document->entity to decide whether to act, and maybe pass $entity as an optional third parameter?

Comments

Comment #1

nick_vh

he/him

Ghent

commented 4 February 2011 at 16:20

I vote in favor and to change the apachesolr_entity_to_document while supplying this function with the name of the entity type.
The hook should be able to catch which entity type it is handling to properly get the fields which it needs to index.

This would make a more reusable approach.

function apachesolr_search_apachesolr_document_handlers($type, $namespace) {
  if ($type == 'node' && $namespace == 'apachesolr_search') {
    return array('apachesolr_node_to_document');
  } else if($namespace == 'apachesolr_search') {
    //somehow add this parameter of the entitytype
    return array('apachesolr_entity_to_document');
 }
}

(code example for D7)