OG Notifications Not Saving Subscriptions

I'm having this problem too. I just came here to find out if anyone else had the same problem, although I hadn't looked into the code yet to try to figure out what was happening. Subscribing.

From what I can tell by puttering around on my site, the "og_notifications_content_types" is, in fact set. In my case, it's set to:
Array
(
[blog] => 0
[og_user_roles_subgroup] => 0
[articulation] => 0
[blogpost] => 0
[story] => 0
)

when I was testing. However, since they're all set to 0, the array_filter gets rid of them all. I'm too new at this to know what that means - I don't know where that particular list came from (it doesn't correspond to the content types that are in use in my groups) or why they're set to 0.

Just checking back. Has anyone looked into this? Does anyone know if there are any plans to fix it? It's a pretty important bug that's keeping me from upgrading OG to the newest version.

+1 subscribe

> I will be digging in to this one within a few weeks.

Great, any help will be appreciated, as I'm dealing most of the time with getting OG7 ready.

+1 Subscribe

looking for resolution. I'm going to try and find a solution.

line 90 of og_notifications.module

      $form['group']['og_notifications_content_types'] = array(
        '#type' => 'checkboxes',
        '#title' => t('Allowed content types'),
        '#default_value' => variable_get('og_notifications_content_types', array()),
        '#options' => $select,
        '#description' => t('Select specific content types which should be <em>allowed</em> for subscriptions to <em>group + content type</em>.'),
        '#multiple' => TRUE
      );
      break;

found by find/replace. This is version 6.21 of OG.

/admin/messaging/notifications/subscriptions/content allows you to pick from content types that are group posts.

The subscriptions show up in the account page. However none of my notifications are sending now. Going to try and troubleshoot.

thats fantastick, thanks so much!

Not seeing any content types to choose in user/uid/notifications/add/grouptype and selecting 'all content types' (only option) does not save any subscriptions.

and yes, the redundancy is odd. in theory it will be a problem because it will send 2 notifications (one for thread and one for group)?

@mikesteff-

The og notifications fieldset in /admin/messaging/notifications/subscriptions/content is no longer there with the patch, so I cant select them. Sorry!

Thanks, I did read what you wrote, and doing that makes sense. However, with global settings and with the og notifications selected there are no post type options in user/#/notifications/add/og. I don't know how to explain the problem more clearly.

of course og notifications must be selected, I did that. It still doesn't work, sorry.

using user 1. I'll try again fresh and let you know.

I think that I know what the problem is, let me test and then get back.

Here is what I've found:

1) i stuck a dprint_r under line 50 of og_notifications.pages.inc to print out $node_types and it gives an empty array
2) since $node_types is filled by og_notifications_node_types() I did the same in that function to print out $group_types and $allowed. og_notifications_node_types() returns the array based on logic between these 2 arrays. $group_types was an array with the expected data (types that are posted into groups), but $allowed was an empty array.
3) $allowed is filled by notifications_content_types('names', 'grouptype'). However, that function takes only 1 argument ($subs_type). So I think that the correct call is notifications_content_types('grouptype'). However, that call simply returns all content types not those that are 'grouptype'.

I'm not sure when or where the 'grouptype' option is saved.

I think that this fixes it, updated patch for og_notifications.module (only) attached.

one other problem I've found:

selecting 'all content types' in /user/#/notifications/add/grouptype seems to only save the topmost content type in the list...not all. I think that was there before the patch though, and might be a separate issue.

mikesteff, I don't know what to say here. Did you look at the code?

EDIT: Maybe we're using different versions of notifications? I'm using 4.0 Beta 7. I wonder if og_notifications is written for an earlier version? I don't remember reading anything about that though...

/**
 * Get content types available for subscriptions to content type
 * 
 * @param $subs_type
 *   Optional type of subscription for which to find allowed content types.
 *   If none, return all content types for which any subscription type is enabled.
 */
function notifications_content_types($subs_type = NULL) {
  // Get list of available node types, all of them will be allowed by default
  $types = array();

  foreach (notifications_content_type_name() as $key => $name) {
    if (notifications_content_type_enabled($key, $subs_type)) {
      $types[$key] = $name;
    }
  }

  return $types;  
}

I see only 1 argument.

I seem to have this part fixed to my satisfaction thanks to your work and my fix. Whether you agree that it is a fix or just suspect that I don't know anything is of no consequence to me. I'll go with what I have.

btw, same problem on a fresh install. good idea though!

Thanks!

Indeed I see that this is my issue most likely. The 6.x-dev patches for notifications/messaging 4x have not been in a stable release yet.

I'll try the -dev version of og and see how that works. Thanks for the patience.

-Ted

mikesteff: I'm fighting with your same issue (you can find my new code here: https://github.com/thePanz/og/tree/DRUPAL-6--2).
it works with notifications 4.x (you can find my patches in my GitHub too).
Few works need to be done for:
1. per-group subscription settings
2. remove subscription duplication for grouptype and nodetype
3. if I enable "all post in group" i MUST also enable "post-type in group", in such case the user, when he/she subscribes to a "all group content" will see also the grouptype subscriptions..

Comments and suggestions are welcome..

ok, I missed the OG version your patch was against.
Maybe my code can help others (using Notifications 4.x)

OG6 is now on Notifications 2.x for releases and dev. Skimming the issue, looks like we are in Needs Review.

#14: og_notifications-subscriptions-not-saving-835030.patch queued for re-testing.

I am experiencing this issue with 6.x-2.2 with Commons 6.x.2.4. Old subscriptions remain in place and notifications based on node type, etc. are working, so I know it's related to OG. How can I help test this? Should I apply the patch in comment 25?

@RightSizedView - yes, that's the next step. Thanks for helping!

Just make sure that at least some nodes have the Content type in group subscription enabled

Well, this is embarrassing, but @mikestefff's comment made me check my og_contenttype settings. They were, in fact, all turned off. I'm wondering if something in upgrading OG to 6.x-2.2 turned them off? Ah well.

I can report that this is working as expected in Organic Groups Notifications 6.x-2.2 using Drupal Commons 6.x-2.5.

OG Notifications was barely touched between 6.x-2.1 and 6.x-2.2. In between it was partially upgraded for Notifications 4.x compatibility then reverted because of that "partial" bit.

There should have been no upgrade path pain on this. That said, there are a lot of bugs with OG Notifications, and some other zany interaction might be buggy enough to drop settings. I do not use OG Notifications, so I look to the community of users that do to identify problems and drive solutions.

Someone needs to reproduce this problem. Marking needs work in hopes of some more attention.

This version of Drupal is not supported anymore. If this is still an issue in the 8.x-1.x branch, please open a new up-to-date ticket. Closing.