Fixes for binary polls, write-in's, js and theming

Without testing it, i think that's the right direction.
Additionally here some comments.

+++ advpoll-display-binary-form.tpl.php
@@ -0,0 +1,27 @@
+    <?php if (isset($writein_choice)) { ?>
...
+    <?php } ?>

usual notation for theming .tpl.php files for conditions use different markup like

<?php if (isset($writein_choice)): ?>
...
<?php endif; ?>

+++ advpoll-display-binary-form.tpl.php
@@ -0,0 +1,27 @@
+  <br clear="left" />
+++ advpoll-display-ranking-form.tpl.php
@@ -12,29 +12,24 @@
+  <?php print $form_submit ?>
+  <br clear="left" />

I don't think there's a clear="left" according to w3c stds. is it?

+++ advpoll-vote.js
@@ -165,7 +152,7 @@ Drupal.behaviors.rankingDragAndDrop = function(context) {
+          Drupal.attachBehaviors($existingChoicesTable);

this might be already fixed in current dev if i remember correctly.

+++ advpoll.module
@@ -1661,6 +1658,13 @@ function advpoll_theme() {
+    'advpoll_voting_binary_form' => array(
+      'template' => 'advpoll-display-binary-form',
+      'file' => 'modes/binary.inc',
+      'arguments' => array(
+        'form' => NULL,
+      )

regarding pseudo-pluggability of modes folder (see many parts of the module) it is pretty strange to see this binary-mode specific theming in the main file...

+++ advpoll.module
@@ -1661,6 +1658,13 @@ function advpoll_theme() {
+    ),    ¶

...
+++ modes/ranking.inc
@@ -171,28 +171,27 @@ function advpoll_voting_ranking_form(&$form_state, &$node, $teaser, $page, $stat
+ ¶

note/remove trailing spaces

+++ modes/ranking.inc
@@ -171,28 +171,27 @@ function advpoll_voting_ranking_form(&$form_state, &$node, $teaser, $page, $stat
+  drupal_add_tabledrag($form['#id'] . '-table', 'order', 'self', 'advpoll-choice-order', NULL, NULL, FALSE);

Generally - if you load js in hook_form or form_alter this only gets executed in build process. In case of any form_validation error those won't be loaded correctly in further loading cycles. If there's never a potential validation fail - this might be OK. In any other case you should add such js/css things in something like a #after_build..

This looks pretty clean to me.

I'd prefer delaying commit for someone else to review it also and confirm it.

Since currently we're focussing on bugfixes only i'm perfectly OK in doing this in the 1.x branch (dev).

My most concerning issue is the ahah/ajax implementation.
I've checked the code (and added some improvements) and it IS very ugly.
Since ahah has also many issues in drupal and some codes are very inefficient i'm thinking about adding ctools as a dependency and use those tools. That's where we could use help very well.

Looking forward to commit this ASAP.

Since i want to keep pushing things forward i've reviewed it again, found no issues with it and committed it unchanged.

Looking forward to see more cleanups. :-)

Added the file. Forgot to cvs add... Thanks!

The "advpoll-display-binary-form.tpl.php" file will be taken into account when it is residing in the module's directory, but NOT when I copy it to my theme's directory! Anybody else having this issue?

So is there something missing in advpoll_theme() or do we need to update the theme call?

Good to know what this problem caused. Could you maybe attach a patch? Thanks.

It is Drupal standard that a module provided *.tpl.php file can be copied *as is* into the theme directory, without the need to rename it to something else. Don't you agree this should be fixed within the module?

thanks! solved it for me too.