This patch lets the data taxonomy module deal with incoming GeoRSS info. Intended for use with Feeds, related patch here: http://drupal.org/node/836876

Also works best with, but doesn't require, the GeoTaxonomy module.

CommentFileSizeAuthor
#13 836878-13.patch4.51 KBalex_b
#12 836878-12_support_complex_terms.patch2.6 KBalex_b
#11 836878-11_support_complex_terms.patch1.94 KBalex_b
#8 836878_7.patch7.87 KBWill White
#6 836878_6.patch7.87 KBWill White
#5 836878_5.patch7.86 KBWill White
#4 836878_4.patch7.58 KBWill White
#3 836878_3.patch7.06 KBWill White
#2 836878_2.patch3.24 KBWill White
#1 data_taxonomy_term_creation.patch3.75 KBrsoden
data_georss_support.patch1.91 KBrsoden

Comments

rsoden’s picture

rsoden commented
Status: Needs review » Needs work
StatusFileSize
new data_taxonomy_term_creation.patch3.75 KB

Updated this to be slightly more generic. Still needs work and testing.

Will White’s picture

Will White commented
StatusFileSize
new 836878_2.patch3.24 KB

Here's an update to this patch to incorporate the changes made by the non-serial ID patch. Apply this first:
http://drupal.org/node/868740#comment-3266232

Needs more work.

Will White’s picture

Will White commented
StatusFileSize
new 836878_3.patch7.06 KB

This patch introduces more complete support.

Will White’s picture

Will White commented
StatusFileSize
new 836878_4.patch7.58 KB

Fixed some SQL query formatting.

Will White’s picture

Will White commented
StatusFileSize
new 836878_5.patch7.86 KB

Adjusted term creation code to handle terms meta data passed in as an array. This is required for copying metadata provided by extractor + geotaxonomy to the new term.

Will White’s picture

Will White commented
StatusFileSize
new 836878_6.patch7.87 KB

New version where data_taxonomy_lookup_tids() passes the tids through array_unique() before returning them.

alex_b’s picture

alex_b commented

Looking good, minor issues:

1. "Map to term ids to @vocabulary vocabulary" should be "Map term ids to @vocabulary vocabulary".
2. Code style - add a space between elseif and (: elseif(

Any other reasons why this patch is NW and not NR?

Will White’s picture

Will White commented
Status: Needs work » Needs review
StatusFileSize
new 836878_7.patch7.87 KB

Thanks for the review and feedback. Updated the patch.

alex_b’s picture

alex_b commented
Issue tags: +6.x-1.0-alpha13

To be released with 6.x-1.0-alpha13.

alex_b’s picture

alex_b commented
Status: Needs review » Needs work

NW with recent changes to #868740: Support exportable vocabularies.

alex_b’s picture

alex_b commented
Title: GeoRSS support for the data taxonomy module » Support mapping of complex terms
Status: Needs work » Needs review
StatusFileSize
new 836878-11_support_complex_terms.patch1.94 KB

I've done some cleanup in data_taxonomy module - this functionality is now vastly simpler to implement.

alex_b’s picture

alex_b commented
StatusFileSize
new 836878-12_support_complex_terms.patch2.6 KB

Previous patch did not accept complex terms at all if the target vocabulary was not a tags vocabulary.

alex_b’s picture

alex_b commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 836878-13.patch4.51 KB

This is tested, debugged and vastly simplified. I did away with the weird catch-all data_taxonomy_save() function and replaced it with a data_taxonomy_save_array() and data_taxonomy_save_name() function.

alex_b’s picture

alex_b commented
Status: Reviewed & tested by the community » Fixed

This is committed, thank you http://drupal.org/cvs?commit=418108

Status: Fixed » Closed (fixed)
Issue tags: -6.x-1.0-alpha13

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +6.x-1.0-alpha13

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.