add removeMappings() to test suite and more extensive addMapping testing [#837922]

Comment	File	Size	Author
#7	feeds-expand-mapping-tests-837922-7.patch	4.77 KB	twistor
#6	feeds-expand-mapping-tests-837922-6.patch	4.61 KB	twistor
#4	837922-mapping-testing.patch	5.05 KB	andrewlevine
	feeds_mapping_testing.patch	3.35 KB	andrewlevine

Comment #1

alex_b commented 27 June 2010 at 18:27

Status:

Needs review

» Fixed

I get 4 fails for "RSS import to data records":

All on 'mapping exists after addition'.

Using HEAD of http://drupal.org/project/issues/feeds_test.

Log in or register to post comments

It looks like this is because FeedsDataProcessor overrides addMapping and modifies the target field. I'm going to add an optional $test_mappings paramater to addMappings() and removeMappings() so FeedsRSStoDataTest can avoid testing mappings (because it does it itself in the test anyway).

Sound good?

Log in or register to post comments

Comment #3

alex_b commented 27 June 2010 at 19:20

Sounds good.

Log in or register to post comments

Comment #4

andrewlevine commented 28 June 2010 at 13:48

Assigned:	andrewlevine	» Unassigned
Status:	Needs work	» Needs review

Status	File	Size
new	837922-mapping-testing.patch	5.05 KB

Attached is the patch with the mentioned changes. All tests pass except for in Filefield (but this is something unrelated to this patch on my machine)