My humble patch adds a theme() hook to allow theming of outgoing mail messages.
Simple yet effective!

CommentFileSizeAuthor
simplenews_theme.patch.txt1.75 KBeeejay

Comments

eeejay’s picture

eeejay commented
Status: Active » Needs review

Just changed the status

tobiass’s picture

tobiass commented

Does this patch work well? Im not a programer and cant help you review this code, so i wonder if this patch works before i try out.

Thanks

sutharsan’s picture

sutharsan commented
Status: Needs review » Closed (won't fix)

eeejay thanks for the effort to make a patch. Please mind the coding standards when you make a patch!
But my problem real with the patch is a conceptual one. For Drupal 5.x we have now the Simplenews template module. I do not like to do functionality twice. Even a simple change like this one is a step into the wrong direction. I don't want to go there.
You made the patch against 4.7.x-1.x-dev. Adding the patch to 4.7 is no option either since in Drupal 4.7 no features will be added and only bugs will be fixed.
For these reasons I mark this issue 'Won't fix'.

malcolm’s picture

malcolm commented

Since I can't get images to appear in emails, using Drupal 6, and latest versions of Simplenews and Mimemail, I thought I'd try this, but I'm getting "patch unexpectedly ends in middle of line
patch: **** Only garbage was found in the patch input." Can anyone help me?

Thanks,