Download & Extend

add query string to make safari refresh for non-js 1click voting

Project:Decisions
Version:6.x-1.x-dev
Component:Selection mode
Category:feature request
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

When someone clicks on the voting controls with JS disabled with 1click voting, they are supposed to be redirected via drupal_goto() with a query string parameter of refresh=1 added so that the Safari will refresh the page and show the voting results, instead of the cached page with the voting controls.

Currently, we put this query string in the wrong place so it doesn't really do anything ;).

Stay tuned for a patch to fix this.

Comments

#1

Component:Code» Selection mode
Category:bug report» feature request
Status:active» needs review

Actually, my memory is incorrect and we don't set this at all ;) So, here's a patch for this *feature request*.

AttachmentSize
842170.patch 815 bytes

#2

[dupe comment]

AttachmentSize
842170.patch 815 bytes

#3

This version has better code comments.

AttachmentSize
842170.patch 951 bytes

#4

Title:&refresh=1 query string is in the wrong place.» add query string to make safari refresh for non-js 1click voting
Status:needs review» fixed

This is committed.

#5

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here