When someone clicks on the voting controls with JS disabled with 1click voting, they are supposed to be redirected via drupal_goto() with a query string parameter of refresh=1 added so that the Safari will refresh the page and show the voting results, instead of the cached page with the voting controls.

Currently, we put this query string in the wrong place so it doesn't really do anything ;).

Stay tuned for a patch to fix this.

CommentFileSizeAuthor
#3 842170.patch951 bytesezra-g
#2 842170.patch815 bytesezra-g
#1 842170.patch815 bytesezra-g

Comments

ezra-g’s picture

ezra-g commented
Component: Code » Selection mode
Category: bug » feature
Status: Active » Needs review
StatusFileSize
new 842170.patch815 bytes

Actually, my memory is incorrect and we don't set this at all ;) So, here's a patch for this *feature request*.

ezra-g’s picture

ezra-g commented
StatusFileSize
new 842170.patch815 bytes

[dupe comment]

ezra-g’s picture

ezra-g commented
StatusFileSize
new 842170.patch951 bytes

This version has better code comments.

ezra-g’s picture

ezra-g commented
Title: &refresh=1 query string is in the wrong place. » add query string to make safari refresh for non-js 1click voting
Status: Needs review » Fixed

This is committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.