FE Nodequeue should ignore ordering of elements in 'roles' and 'types' arrays [#842458]

I had a couple of Nodequeues added to a feature and was finding that they were showing up as 'Overridden' even though I hadn't really made any changes. Reverting the feature didn't affect this status. It turns out that the entries for a queue in the nodequeue_roles and nodequeue_types tables maybe stored in a different order to what's specified in the features's default settings. The order in which the data is stored doesn't really affect functionality but it does affect the Feature's status because Features module uses MD5 hashes (of the code required to create each nodequeue) to work out what has and hasn't changed.

To fix this issue we simply need to ignore the ordering of the items in the 'roles' and 'types' arrays. We do this by sorting these arrays once loaded in the the fe_nodequeue_queue_features_export_render() method.

Patch attached.

Comment	File	Size	Author
#4	fe_nodequeue_842528_array_ordering_update.patch	878 bytes	wizonesolutions
#2	fe_nodequeue-array-ordering-update.patch	1.16 KB	13rac1
#2	fe_nodequeue-array-ordering-879588-769660.patch	796 bytes	13rac1
	fe_nodequeue-array-ordering.patch	1018 bytes	hiddentao

Comments

Comment #1

hiddentao commented 1 July 2010 at 17:14

Status:

Needs review

» Patch (to be ported)

Comment #2

13rac1 commented 27 August 2010 at 00:07

Status:

Patch (to be ported)

» Needs review

Status	File	Size
new	fe_nodequeue-array-ordering-879588-769660.patch	796 bytes
new	fe_nodequeue-array-ordering-update.patch	1.16 KB

Patch fixes broken "Overridden" status on features supplying Nodequeues. Two files attached:

fe_nodequeue-array-ordering-update.patch - Updated version of the original patch to work with the current 2010-Jul-10 dev
fe_nodequeue-array-ordering-879588-769660.patch - Updated version of the original patch to work after recent patches from #879588: Wrong syntax order for features_get_default() breaks all Features Extra modules and #769660: expecting T_STRING or T_VARIABLE or '$' in sites/all/modules/features/features.export.inc(590) are applied. Note: Apply 8795588, then 769660, and lastly 842458 to have no failures or fuzz.

Applying all three to current dev:

user@dev:/var/www/sites/all/modules/features_extra$ patch -p0 < features_extra-features_get_default.patch
patching file fe_block.module
patching file fe_nodequeue.module
patching file fe_taxonomy.module
user@dev:/var/www/sites/all/modules/features_extra$ patch -p0 < features_extra-769660.patch
patching file fe_block.module
patching file fe_nodequeue.module
patching file fe_taxonomy.module
user@dev:/var/www/sites/all/modules/features_extra$ patch -p0 < fe_nodequeue-array-ordering-879588-769660.patch
patching file fe_nodequeue.module