drupal-org.make makefile for Cod

Just noting that we want to Flag 6.x-2.0-beta3 which has exportables. I'll re-post with any other tweaks I find.

This patch removes the content type stuff (since they are now provided by cod_support features), adds a make file and also fixes up a few minor issues in the profile file.

Also this is for the 6.x branch, if you can you add a 6.x release under this project I can properly tag this a 6.x instead of 5.x which is not correct.

Sorry, use this patch instead.

And if you would like to build it from scratch to test.

Create a make file with the following and hit "drush make [filename]", it will pull down the above patch and apply to the current dev version.

; Required version of Drupal core.
core = 6.x
projects[] = drupal

; Conference Organizing Install Profile
projects[cod][type] = profile
projects[cod][download][type] = "cvs"
projects[cod][download][module] = "contributions/profiles/cod"
projects[cod][download][revision] = "DRUPAL-6--1"
; http://drupal.org/node/844558
projects[cod][patch][] = "http://drupal.org/files/issues/cod_2.patch"

Hi univate. Your patch includes a lot of changes which makes it harder to review. This issue is really about the makefile and not the cck/*.txt files. I've deleted those to make it easier to do the other patches.

Can you re-roll with just changes specific to the make file and create a new issue for the profile changes?

Also, the initial file is now committed - http://drupal.org/cvs?commit=401562 - to make it easier to roll patches.

And here's the issue for the profile. #872096: fixups to the cod.profile

I'm actually not sure what/why we need to change things. I guess you made those changes for alphabetical order? And it seems that you enabled profile (I mostly agree with that) but we should discuss these things separately.

We needed some more modules. Also, I created http://drupal.org/node/872120 so we can use that for the cod_support part of this.

The previous patch as everything I did to get a working make file (ie: a distribution that didn't give any errors).

Here is a patch just against make file, it is mostly just re-ordering modules alphabetically, so you can easily see which ones are being included.

Also is drupal-org.make a drupal distrubution filename? I have always used the [install_profile_name].make as the filename. I bring this up because now the things doesn't build recursively like it did in my previous patch when I create/run a master make file like the one below.

; Conference Organizing Install Profile makefile

; Required version of Drupal core.
core = 6.x
projects[] = drupal

projects[cod][type] = profile
projects[cod][download][type] = "cvs"
projects[cod][download][module] = "contributions/profiles/cod"
projects[cod][download][revision] = "DRUPAL-6--1"
; http://drupal.org/node/844558
projects[cod][patch][] = "http://drupal.org/files/issues/cod_profile.patch"
projects[cod][patch][] = "http://drupal.org/files/issues/cod_make.patch"

My understanding is that to host a distribution on drupal.org we need to create this file as drupal-org.make - http://drupal.org/node/642116 has the details.

We can potentially ship two files: one for folks who want to run "drush make" directly and the drupal-org.make file for people who want to download the whole thing from drupal.org. For now, I would rather focus on the drupal-org.make file since that is the file used by our main audience and it is probably simpler for the .profile to have one file than two.

Cool, looks like the advanced suggestion on that page might be a good way to go here, that is have another make file without all the version detail (only where its actually required), that would make it easy to regenerate drupal-org.make files for each new each release as well. I have to admit that I don't really support the idea of major and minor version for the drupal version information, I think that when theres a new security release, d.o distributions should get repackages with that latest code - thats obviously a discussion for a different place though.

Advanced: maintaining multiple .make files
Due to some legal and technical hurdles, the drush make that runs on drupal.org itself only allows a subset of all the possible commands that drush make supports. If your profile includes 3rd party code or other disallowed features, you won't be able to include those in the releases on drupal.org. If you'd like, you can maintain a {profilename}.make with everything (so that people who have drush make installed locally can get the whole thing) and a separate drupal-org.make file with the subset of your .make file that the drupal.org packaging system will allow.

The other reason to have two .make files in your installation profile directory is to deal with the problem of specific versions explained above. If you want, you can just maintain a list of the projects included with your profile in {profilename}.make, and then use the drush convert makefile command to automatically generate a drupal-org.make file with specific versions (using the latest recommended releases of all your included projects) that you can test and use as a basis for an official release of your profile.

Looking at our release it seems that we're out of date on ubercart and features modules. I think we can probably use the latest without any concerns.

Other than that, your patch looks good except I don't think patches are allowed either.

Care to reroll with those updates and without the patch? Maybe just leave a comment that we want that patch.

Regarding which strategy to follow, I care the most about making cod useful for direct download from drupal.org so I'm less interested in maintaining both sets of files. If you (or someone else on the project) were interested in maintaining both that seems good to me.

The following patch has been run through the convert make file on drupal.org so should work.

I would also like to see a cod.make file added which has all the version information stripped out and easily allows the ability to create new versions based on whatever the current releases of each module is.

Now fixed http://drupal.org/cvs?commit=408654

Thanks, Univate!