I have put some considerable work into making a patch for this module due to my own needs for a client's site and would like to contribute it back as well as request that I be added as a co-maintainer to further the development.

Here is what the attached patch does:

  • Cleans up a lot of code formatting to conform to the drupal coding standards (comment format, soft tabs and etc).
  • Fixes the uninstall hook so it actually deletes the variables set in the variables table.
  • Adds option to show a specified node within the age validation page.
  • Use input buttons, instead of a date widget on the age validation page.
    • Specify the text to be used for each button.
  • Specify the age validation page's title.
  • Fixes issue #753710: @site variable is wrong

Other features I would plan on implementing:

  • Integration with other profile based modules, such as core profile or content profile birthdates
  • Assigning role to user, based on age validation

May be other things as well. Let me know about issues with this patch and status of co-maintainer, Thanks.
--
Nicholas

CommentFileSizeAuthor
#2 validateage-845900-2.patch27.82 KBnicholas.alipaz
#1 validateage-845900.patch18.66 KBnicholas.alipaz

Comments

nicholas.alipaz’s picture

nicholas.alipaz commented
StatusFileSize
new validateage-845900.patch18.66 KB

adding patch

nicholas.alipaz’s picture

nicholas.alipaz commented
Title: Add various configuration options and make me a co-mainatainer » Co-maintainer application for validateage module
Project: Validateage » Drupal.org site moderators
Version: 6.x-1.x-dev »
Component: Code » Project ownership
Category: feature » task
StatusFileSize
new validateage-845900-2.patch27.82 KB

Module in question: Validateage

I have attempted contacting the maintainer of the module as well as posting this ticket in the issue queue. The developer does not seem to be responding or maintaining the module.

If anyone knows this developer (last seen in August from what I can tell), can you confirm I can get access to add changes and get to a stable release?

Attached improved patch:

  • Cleans up a lot of code formatting to conform to the Drupal coding standards (comment format, soft tabs and etc).
  • Fixes the uninstall hook so it actually deletes the variables set in the variables table.
  • Adds option to show a specified node within the age validation page.
  • Option to use input buttons, instead of a date widget on the age validation page.
    • Specify the text to be used for each button.
  • Specify the age validation page's title.
  • Fixes issue #753710: @site variable is wrong
  • Remove usage of cookies for storing information about anonymous user's set birthdate, now using sessions.
  • Making hook_user and the page form use the same function for outputting labels so that there is more ease in translating and consistency
  • Adding status arguments to drupal_set_message instances
  • Setting the date form element to have a range of today minus 100 years rather than the drupal default range for default elements
  • Setting default value of date form element on registration to be populated with the anonymous user's birthdate as stored in their session, if they have already confirmed it

Please see my attached patch as part of my application to maintain this module. Thanks.

nicholas.alipaz’s picture

nicholas.alipaz commented

Anyone else want to weigh in on this? I have received no responses from the module author, despite attempts to contact (email, public post in validateage issue queue, and looking for her in IRC).

This application was originally posted in the module's issue queue in July 2010.

hongpong’s picture

hongpong commented

subscribing - thanks for the work on this, someone should address it already OK?

nicholas.alipaz’s picture

nicholas.alipaz commented

I think maybe the person who reviews these apps is out for a bit. All the project ownership tasks from recently are still pending.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: Co-maintainer application for validateage module » Offering to co-maintain Validateage
Project: Drupal.org site moderators » Validateage
Version: » 6.x-1.x-dev
Component: Project ownership » Code
Category: task » support

I am changing the title of the report as per procedure; I will write a message to the current maintainer in the next minutes.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

I sent a message to gwen.

Hello, gwen. I am writing you because nicholas.alipaz is willing to co-maintain the project.

Please reply to http://drupal.org/node/845900. If you don't reply before two weeks, nicholas.alipaz will probably make co-maintainer of the project.

Best regards,
kiamlaluno.
Drupal.org site maintainer
Drupal.org contribution CVS maintainer

nicholas.alipaz’s picture

nicholas.alipaz commented

Thanks for doing that, I did write one as well quite a while back. I would however prefer to have gwen's blessing if possible.

gwen’s picture

gwen commented

Sorry for the looong lag on this. I've been entertaining this fantasy that one day I'll get back to doing work on this module but none of my recent projects have required it, so it's been totally back-burnered.

Nicholas, thanks so much for your patch and your offer to help maintain this module! I just gave you full privileges as a maintainer, so you're free to go to town . One of these days maybe I'll get back to it, but until then, the module's in your capable hands.

nicholas.alipaz’s picture

nicholas.alipaz commented
Status: Active » Fixed

Thanks gwen, I really appreciate you coming along to approve this. I will push along with the patch I wrote and try to see about incorporating some of the other patches that have been submitted. This is quite good news.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.