Would it be possible to include the ExplorerCanvas library through the Drupal Libraries API http://drupal.org/project/libraries ?

CommentFileSizeAuthor
#15 include-excanvas-via-libraries-api-d7-849232-15.patch5.24 KBdharizza
#13 include-excanvas-via-libraries-api-d7-849232-13.patch5.18 KBacouch
#11 849232-beautytips-libraries-api.patch1.77 KBmrfelton
#9 README.patch938 bytessleeping_at-work-
#2 beautytips-librariesAPI_support.patch586 bytessleeping_at-work-
#1 beautytips-librariesAPI.patch411 bytessleeping_at-work-

Comments

sleeping_at-work-’s picture

sleeping_at-work- commented
Version: 6.x-2.0 » 6.x-2.x-dev
Status: Active » Needs review
StatusFileSize
new beautytips-librariesAPI.patch411 bytes

Would it be possible to include the ExplorerCanvas library through the Drupal Libraries API http://drupal.org/project/libraries ? This will bring all the advantages of the Libraries API. I'm adding a patch which needs to be tested.

sleeping_at-work-’s picture

sleeping_at-work- commented
StatusFileSize
new beautytips-librariesAPI_support.patch586 bytes

I'm adding a new patch which is aimed just to support the Drupal Libraries API, without compromising the usability of the module for who's not implementing Libraries API in his system. It lacks testing.

kleinmp’s picture

kleinmp commented

Thanks for the patch!

I didn't know about the Drupal Libraries API, and it's a good idea. I'll test out the patch and commit it the next chance I get.

intyms’s picture

intyms commented

subscribing...

sleeping_at-work-’s picture

sleeping_at-work- commented

thanks :)

Anonymous’s picture

Anonymous (not verified) commented

subshcribing.

kleinmp’s picture

kleinmp commented
Status: Needs review » Fixed

Committed to the dev version.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

sleeping_at-work-’s picture

sleeping_at-work- commented
Status: Closed (fixed) » Needs review
StatusFileSize
new README.patch938 bytes

In order to grant consistency, please consider to review the README
Here's a patch

mrfelton’s picture

mrfelton commented
Status: Needs review » Needs work

This patch is not in the latest 2.x-dev branch.

mrfelton’s picture

mrfelton commented
Status: Needs work » Needs review
StatusFileSize
new 849232-beautytips-libraries-api.patch1.77 KB

Here is a patch that reincorporates this fix as well as the update to the README.txt file into the latest 2.x-dev branch

socialnicheguru’s picture

socialnicheguru commented
Version: 6.x-2.x-dev » 7.x-2.x-dev

Will this be ported to D7?

acouch’s picture

acouch commented
StatusFileSize
new include-excanvas-via-libraries-api-d7-849232-13.patch5.18 KB

Here is a D7 patch. This was necessary for us because we are trying to include this in a distro which makes it hard to package the excanvas library in the beautytips module and the "WARNING!" message is fired upon install which makes it look like the install was unsuccessful.

Only local images are allowed.

pifagor’s picture

pifagor commented
Issue summary: View changes
Status: Needs review » Closed (outdated)
dharizza’s picture

dharizza commented
StatusFileSize
new include-excanvas-via-libraries-api-d7-849232-15.patch5.24 KB

Re-rolled patch to apply cleanly in latest dev version.