Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
There is a conceptual problem with Feeds defaults: enabling depending node types and views is tied to enabling specific importer configurations. This is awkward. What we should do is provide a couple of Features instead:
- Import feature with node and user import.
- News aggregation feature with RSS/Atom aggregation and OPML import.
We should keep importer, views and node type names the same and feeds.install can disable feeds_defaults module and enable successor modules.
Comment | File | Size | Author |
---|---|---|---|
#1 | 851194-1_featurize.patch | 48.82 KB | alex_b |
Comments
Comment #1
alex_b CreditAttribution: alex_b commentedIntroduces feeds_news, feeds_fast_news and feeds_import as three example features.
- All tests passing.
- Missing upgrade path from feeds_defaults
- Introduces dependency on Features due to use of nodes, may be avoidable.
- I've created this patch with Git. patch with patch -p1
- Does not yet remove feeds_defaults.
- Contains view posted at #617486-36: Create link to original source, view of items on feed nodes
Comment #2
alex_b CreditAttribution: alex_b commentedThis is committed now.
Needs
- more testing of upgrade path.
- Remove empty feeds_default directory.
Comment #3
alex_b CreditAttribution: alex_b commentedUpgrade path tested. Open new issues for related adjustments/bugs.
Comment #4
mcaudy CreditAttribution: mcaudy commented@alex_b: I don't quite follow this. is this a rough idea for a "Featurize" module?
Where does "feeds_fast_news" come from?
I was following: http://drupal.org/node/617486, which linked to this page, but I do not follow this.
Comment #5
andrewlevine CreditAttribution: andrewlevine commented@mcaudy
I asked alex_b the same question before, and if I remember right, this is the gist of it: Before this issue we had the feeds_defaults module inside of feeds which implemented a bunch of feeds importers which we could use to clone and use as defaults. After this issue, instead of manually putting together a bunch of hooks in a single module (without a nice interface like features module provides), there are a few separate features modules that should be easier to manage, both for developers and Feeds users.
Anyone feel free to correct me if any part of that is wrong.
Comment #6
alex_b CreditAttribution: alex_b commented#5: That's it. I add: feeds_default had the very backwards behavior of turning on / off content types (e. g. feed and feed_item) when enabling/disabling feeds importers. This is straightened out now by providing feature modules for these importers.