There is a conceptual problem with Feeds defaults: enabling depending node types and views is tied to enabling specific importer configurations. This is awkward. What we should do is provide a couple of Features instead:

- Import feature with node and user import.
- News aggregation feature with RSS/Atom aggregation and OPML import.

We should keep importer, views and node type names the same and feeds.install can disable feeds_defaults module and enable successor modules.

CommentFileSizeAuthor
#1 851194-1_featurize.patch48.82 KBalex_b
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alex_b’s picture

Status: Active » Needs review
FileSize
48.82 KB

Introduces feeds_news, feeds_fast_news and feeds_import as three example features.

- All tests passing.
- Missing upgrade path from feeds_defaults
- Introduces dependency on Features due to use of nodes, may be avoidable.
- I've created this patch with Git. patch with patch -p1
- Does not yet remove feeds_defaults.
- Contains view posted at #617486-36: Create link to original source, view of items on feed nodes

alex_b’s picture

Status: Needs review » Needs work

This is committed now.

Needs

- more testing of upgrade path.
- Remove empty feeds_default directory.

alex_b’s picture

Status: Needs work » Fixed

Upgrade path tested. Open new issues for related adjustments/bugs.

mcaudy’s picture

@alex_b: I don't quite follow this. is this a rough idea for a "Featurize" module?

Where does "feeds_fast_news" come from?

I was following: http://drupal.org/node/617486, which linked to this page, but I do not follow this.

andrewlevine’s picture

@mcaudy

I asked alex_b the same question before, and if I remember right, this is the gist of it: Before this issue we had the feeds_defaults module inside of feeds which implemented a bunch of feeds importers which we could use to clone and use as defaults. After this issue, instead of manually putting together a bunch of hooks in a single module (without a nice interface like features module provides), there are a few separate features modules that should be easier to manage, both for developers and Feeds users.

Anyone feel free to correct me if any part of that is wrong.

alex_b’s picture

#5: That's it. I add: feeds_default had the very backwards behavior of turning on / off content types (e. g. feed and feed_item) when enabling/disabling feeds importers. This is straightened out now by providing feature modules for these importers.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.