I'm using content profile for my page and ImageField Avatar.

It would be great if I could use Avatar Approval (http://drupal.org/project/avatarapproval) as well but when I submit it through the imagefield it never shows up in the approval queue.

Thanks in advance for the consideration!

Comments

crea’s picture

crea commented
Category: bug » feature

Bug report ? Really ? You can't simply assume random modules not working together is a bug.

tomdisher’s picture

tomdisher commented

I tagged it as feature request... It'd be great if they did work together. If there is no chance then I'll have to change the way we do things.

dalad’s picture

dalad commented

I've given a first look on Imagefield Avatar code.
Main issue in integrating with avatar approval is that in imagefield_avatar_nodeapi() there is a direct database query to update the user avatar. Given this approach, nothing can be done in order to give moderation features.

IMO a better approach would be faking a user profile edit form submission programmatically. This would trigger avatar approval module (and every other modules that work on user profile update) using the form API. I'm thinking something like:

$form_state = array();
$form_state['values']['picture'] =  $file;
drupal_execute('user_edit', $form_state);

Do you agree?

dalad’s picture

dalad commented

By the way why do you remove the user picture upload field from user_profile_form (imagefield_avatar.admin.inc line 23) ?
I would not expect this behaviour...

tomdisher’s picture

tomdisher commented

The Approve Avatar also will not with with Avatar Crop.

My end goal is to get cropping feature so all avatars are the same size and then put it into the approval queue. Both modules work great on their own but when I use either Imagefield Avatar or Avatar Crop it bypasses the approval queue completely.

Edit: I'd be willing to pay to find a solution, as well. Imagecache Avatar is kind of clunky because it doesn't let you choose which part of the photo you'd like. Avatar Approval is a showstopper for my site - I have to use it. If anybody is interested let me know.

dalad’s picture

dalad commented

Integration of avatarapproval with CCK is not straightforward. There are issues with validators that I'm not able to manage alone. I think that a better strategy to solve the issue is faking an user edit form submit, but I'm not going to solve this issue and I leave it to the will of ImageField avatar maintainer.

Different story when it comes to form API. As Avatar Crop is using forms, you will find that it's now possible to moderate avatars submitted using avatar crop, just by using latest avatar approval dev it should work out of the box.

tomdisher’s picture

tomdisher commented

I upgraded to the latest dev version and it is working great for the first time that an avatar is uploaded. If a user uploads a second avatar it goes into the approval queue again. When the second avatar is approved it reverts to the first avatar on the profile page.

dalad’s picture

dalad commented

Ok. But this thread is regarding ImageField Avatar module; please open a new issue for avatarapproval module about this behaviour. I'll take a look at it and reply you there