Notice: Undefined variable: is_done in tvi_get_default_view() (line 362 of /var/www/vhosts/drifire.devsn.com/httpdocs/sites/all/modules/tvi/tvi.module).

Patch coming.

CommentFileSizeAuthor
#3 tvi-fix-tvi_get_default_view-function-856326-3.patch1.57 KBb-prod
#2 tvi-notice-856326-2.patch1.96 KBDanaRoseRoss
#1 tvi-notice-is_done-856326-1.patch750 bytesDanaRoseRoss

Comments

DanaRoseRoss’s picture

DanaRoseRoss commented
StatusFileSize
new tvi-notice-is_done-856326-1.patch750 bytes

Patch attached.

DanaRoseRoss’s picture

DanaRoseRoss commented
StatusFileSize
new tvi-notice-856326-2.patch1.96 KB

Roll-up of previous patch and other notices we were getting while error reporting was set wide open.

b-prod’s picture

b-prod commented
Title: Log getting filled with undefined variable notices » Simplify and correct the tvi_get_default_view() function
Version: 6.x-1.1 » 6.x-1.x-dev
Status: Active » Needs review
StatusFileSize
new tvi-fix-tvi_get_default_view-function-856326-3.patch1.57 KB

The named function contains some errors and can also be really simplified. It is called only one time, using list(). From this point there are some useless parts of codes and when there are no matching view, the function returns an empty array, which is not compatible with the list() procedure.

Tjhe patch below corrects the tvi_get_default_view() function.

derekwebb1’s picture

derekwebb1 commented

I will be releasing a patched version soon. I have it patched on my localhost however I am trying to figure out a few other things as well before I release a new version.

derekwebb1’s picture

derekwebb1 commented
Status: Needs review » Fixed

Thanks for the cleanup! I really appreciate the patches.

Status: Fixed » Closed (fixed)
Issue tags: -notice, -log

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +notice, +log

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.