I was scanning the code for implementations of on-behalf target mappers to apply the same techniques to other modules we were hoping to extend with this functionality, and noticed that filefield.inc link.inc were not passing $target by reference in their hook_feeds_node_processor_targets_alter() hooks, as its cousins content.inc and taxonomy.inc were. I could not find a duplicate issue in the queue, so I wrote a trivial patch to correct this.

Review and feedback welcome.

CommentFileSizeAuthor
#1 856408-feeds_filefield_link_mappers-1.patch1.06 KBdavidwatson
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

davidwatson’s picture

davidwatson CreditAttribution: davidwatson commented
FileSize
856408-feeds_filefield_link_mappers-1.patch1.06 KB

Patch attached.

evNN’s picture

evNN CreditAttribution: evNN commented

Reviewed and tested patch in #1 for "link" module as "filefield" was not in use at the time.

alex_b’s picture

alex_b CreditAttribution: alex_b commented
Status: Needs review » Fixed

Committed, thank you: http://drupal.org/cvs?commit=394468

How did that ever work?

Hanno’s picture

Hanno CreditAttribution: Hanno commented

Great! This issue also fixed an issue for the node_multisource module.
#857240: cck date fields of the parent feed become empty

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.