joined user e-mail address not becoming link to profile [#85708]

In the status description on the Invite page, it says that joined users will appear in your invite list and that you can "Click on the email address to take you to their profile page."

When users are invited and registered, while their status changes to "joined" in my list, it doesn't create a link back to their user profile page.

I have non-standard user profile pages--they are simply "www.mysite.com/username" Is that causing the problem?

Comment	File	Size	Author
#10	invite_patch08	10.39 KB	ajk
#9	invite_patch07	7.87 KB	ajk
#8	invite_patch06	7.5 KB	ajk
#7	invite.module_r1_9_2_4_patch05	5.35 KB	ajk
#6	invite.module_r1_9_2_4_patch04	2.9 KB	ajk
#5	invite.module_r1_9_2_4_patch03	2.67 KB	ajk
#4	invite.module_r1_9_2_4_patch02	1.82 KB	ajk
#3	invite.module_r1_9_2_4_patch01	1.75 KB	ajk

Comments

Comment #1

budda

English

Cheshire

commented 25 September 2006 at 00:23

Priority:

Critical

» Normal

I've got a fresh out of the box Drupal 4.7 install and the same non-clickable email address issue exists.
I wouldn't say this issue is critical though, it doesn't stop the website from working.

Comment #2

sinker commented 25 September 2006 at 01:34

it's not critical in that it doesn't stop the site from working, but it also breaks a lot of the social-networking functionality of this module (people can't find the friends they've invited easily without being able to click through to their profile). It seems pretty critical in terms of the module actually being, you know, useful.

Comment #3

ajk commented 27 November 2006 at 23:53

Status:

Active

» Needs review

Status	File	Size
new	invite.module_r1_9_2_4_patch01	1.75 KB

Here's a patch that does this. Note also, the ternary within a ternary within..... and on, is broken in other ways also. This patch not only fixes that brokeness, adds in what asked for here but it also makes the code readable by humans as well as computers ;)

Comment #4

ajk commented 28 November 2006 at 00:06

Status	File	Size
new	invite.module_r1_9_2_4_patch02	1.82 KB

This patch does the same as the patch in #3 above but also incorporates this issue http://drupal.org/node/85174

Comment #5

ajk commented 28 November 2006 at 00:26

Status	File	Size
new	invite.module_r1_9_2_4_patch03	2.67 KB

I'm on a roll. This patch combines all the above and!.....

http://drupal.org/node/70619

There's a extra site wide admin checkbox in settings to enable this feature. But it allows a user to delete a record for a previous joiner. See the above issue as to why this is needed.

Comment #6

ajk commented 28 November 2006 at 00:31

Status	File	Size
new	invite.module_r1_9_2_4_patch04	2.9 KB

I'm still at it.... all teh above plus

http://drupal.org/node/84251

change ctype_digit() to is_numeric()

The ctype_*() functions only came in with PHP4.4.2 and beyond. is_numeric() has always been there, that's why Core uses is_numeric() in preference to the slightly faster (but not noticable outside large loops) ctype_digit() equiv