Move the 'Location' fieldset out of the default fields (a.k.a support Vertical Tabs & Vertical Tabs Default Tab)

Heh yes this is definitely an annoyance and yes I'd like it fixed... what I've done is a form_alter on node forms and move $form['locations'] to $form['location']['locations'], then unset the $form['locations'] and it works. But... it would be very nice if this could happen by default.

subscribe

I have given up. Was a big Fan of Vertical Tabs, but a bigger fan of Location module. Now I use nodecolums.module to style my node form to make location look better. But vertical tabs would be nice

+1 for this. It sounds like it could be a straightforward fix from this comment on #354920: Support for location module (a.k.a Move the 'Location' fieldset in its own vertical tab):

it seems that if you select a max number of locations greater than 1 (on the content type edit page), it will add the locations fieldset to vertical tabs.

i'm using the form module, and once i changed the max number, the locations fieldset appeared on the form configuration page.

this seems to have something to do with the double fieldsets that the locations module uses when there are multiple locations.

(http://drupal.org/node/354920#comment-2438850)

Looking through the codebase, the following pseudocode modifications in location_form() would "fix" Location for Vertical Tabs. Try adding && !module_exists('vertical_tabs') twice in the two if statements as follows:

/* ... */
  // If there is only one form, hide the outer fieldset.
  if ($settings['multiple']['max'] == 1 && !module_exists('vertical_tabs')) {
    $form['#type'] = 'markup';
  }
/* ... */
  // Tidy up the form in the single location case.
  if ($numforms == 1 && !module_exists('vertical_tabs')) {
/* ... */

Note: I don't recommend this as the actual contrib fix, although it will work for you if you're happy hacking your own copy of the module! But these are the two "pinch points" where what Location does is just not correct for what Vertical Tabs wants to see.

The problem is that the UX suffers a little bit as a result, but maybe that's OK. Can anyone on the Location or Vertical Tabs projects help with suggesting the most reasonable behaviour for this code, without introducing a cross-dependency between the two modules? I hate using module_exists() if I can avoid it.

Thanks for your work jp.stacey, I will use your hack for the interim. +1 For a proper fix.

per #5 adding a tag

I came across this as well. Thanks to jp.stacy for his pointer. It led me onto this following solution for me. The locations key doesn't appear to get populated into the $form array at the point of a regular form_alter(), but it is after the form has been fully built- therefore I needed to enter the #after_build to perform the action I needed:

/**
 * Implementation of form_alter().
 */
function {my_module}_form_alter(&$form, &$form_state, $form_id) {
  // For all node forms, change location to a fieldset so it'll
  // be picked up by vertical tabs
  if (isset($form['type']) && $form['type']['#value'] .'_node_form' == $form_id) {
    $form['#after_build'][] = '{my_module}_put_location_in_vertical_tabs';
  }
}

function {my_module}_put_location_in_vertical_tabs($form, &$form_state) {
  if($form['locations']) {
    $form['locations']['#type'] = 'fieldset';
    $form['locations'][0]['#type'] = 'markup'; // I also wanted to remove the child fieldset as I only have one location element set
  }
  return $form;
}

Hope that helps.

Barry

Tkanks for solutions #5 and #8. My method is different. No module_exists() but pure CSS is enough when code is modified a bit. I am attaching the patch.

I've tested #10 and found one mistake. Class 'location' should be also add to single-location fieldset. Without this, some css rules don't work. I am attaching new patch.

subscribing

Seems like patch in #12 does not add support for Vertical Tabs.
It may work for adding support for Vertical Tabs Default Tab, but I do not use that module.

I am successfully working with Vertical Tabs and Vertical Defaul Tab after applying #12 for long time. Did you test this or just saying that it doesn't support Vertcal Tabs?

Hi here is a small module to put location in vertical tabs

vlooivlerke's module works beautifully, thanks!!

@vlooivlerke

Can you please make this module available for Drupal 7?

I need this fix as soon as possible.

Thanks,

For D7 with this module you can move Location-Fieldset to vertical Tabs from "Field Group"

https://drupal.org/project/rel

Closing old D6 issues as D6 is end of life