Closed (fixed)
Project:
Homebox - Individual user dashboards
Version:
6.x-3.x-dev
Component:
User interface
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
22 Jul 2010 at 10:15 UTC
Updated:
19 Mar 2011 at 04:11 UTC
Comments
Comment #1
Michsk commented...
Comment #2
Michsk commentedMikestefff: any time / plans to get this done?
Comment #3
mstef commentedI'm working with the Drupal.org redesign team to get Homebox ready for the launch. There is a very long list of changes being made. Once all that architecture is set and finished, I'll be able to get to this. Sorry!
Comment #4
Michsk commentedOk but this is one of the drupal.org dashboard things. That saving is done automatically, no loading text, trobblers or other things, just autosave. So fixing this would already be a step ahead.
Comment #5
drummComment #6
Michsk commentedyes
Comment #7
drummCommitted my work for this. It is a page option since different types of pages and situations call for different save rules.
Comment #8
mstef commented??
Comment #9
drummPersonal dashboard - good idea to always auto-save.
Group dashboard that a lot of people see - good idea to preview and save when done.
Comment #10
mstef commentedDo we have homeboxes where one setting persists for all yet (group)?
Comment #11
mstef commentedI was the one who stripped auto save. I personally don't like it. Ideally, it wouldn't just be an option per page, but for the user while viewing the home box - perhaps a checkbox or something.
Comment #12
itsnotme commentedMoved comment to a better fitting place :)
Comment #13
Michsk commentedMike: really autosave is the best option for this. I cant get it that you dont see it. You want to give the user a option to check if he wants to autosave or not? Then well also have to explain 1)what auto save is and 2)what it autosaves. This is really not a good idea.
Personal dashboards just need to autosave.
The group dashboards, sure, those will need some 'thinking' to get it working for a group.
Comment #14
Michsk commentedIm going to install latest dev right now, time to test all the new development on this module.
Comment #15
Michsk commentedThis works good for personal dashboards. I can not test for groups, since i don't use groups.
My personal preference would be to make the ajax saving and getting quicker tough... When you now move a bock, drop it, and press F5 you get a error.
Comment #17
bryancasler commentedOn my site I am having the same problems as #15
On drupal.org/dashboard I do not have these problems
Comment #18
mstef commentedComment #19
brianV commentedBumping this to 7.x-2.x-dev.
Any fix will be backported to 6.x-2.x-dev.
Comment #20
brianV commentedmarked #961364: Saving partially broken in 6.x-2.x-dev ? as a duplicate.
Comment #21
brianV commentedComment #22
brianV commentedAlso, this is a bug.
Comment #23
brianV commentedAutosave and regular save have now been fixed in 7.x-2.x-dev.
Can someone confirm this is still a problem in the current D6 version? I don't have a copy of that running to check against, but the code doesn't have the same bug that broke it in the D7 port.
Comment #24
brianV commentedActually, I am looking at what it was re-opened on for Drupal 6. The #15 issue happens simple when you change the page before an AJAX request completes. It in no way indicates that autosave is broken, it just means that not enough time was given.
Unfortunately, AJAX only moves at the speed of the connection between you and the server, so not much we can do about it.
Marking as fixed, re-open if autosave is still problematic
Comment #25
rhymeswithcamera commentedI just upgraded to 6.x-3.0-beta2 (from 6.x-2.1). I apologize for my ignorance, but how should the Auto Save feature be behaving? Should I still be seeing a "Save" button with the "Unsaved" text when changes are made? I was assuming that it would work similarly to drupal.org where the saving happens automagically. Is there a setting I need to set somewhere?
Comment #26
brianV commentedYou will need to go to the edit' page for your homepage. There will be a checkbox there to enable autosave.
Comment #27
rhymeswithcamera commentedHmm, okay. I have two Homeboxes and the Autosave feature is checked for both. By checking this feature, is it supposed to hide the Save button, etc.?
Comment #28
drummYes, the idea is the save just works and doesn't need UI clutter.
(There could probably be better reporting of connectivity issues, but that's another issue.)
Comment #29
rhymeswithcamera commentedThank you. I got it working. I had to disable the Autosave feature, save, and then enable it again for each Homebox. Now it's working as expected. A much cleaner UI experience.
Comment #30
jcl324I have enabled/disabled autosave several times, and the autosave still does not work. The save button does appear and does save when clicked. What else might I be missing to get autosave to work?
Comment #31
drummSounds like some JS on the page, not necessarily from homebox, is failing and bringing all the other JS to a halt. Load the page with your browser's JS console on and find the source of the error.
Comment #32
drummOr your theme is causing some jQuery selector(s) to miss.
Comment #33
Michsk commentedno, it's got to do with the load. I thought that there was some kind of timeout in the homebox module, but guess there's none.
Comment #34
k3vin commentedIn my case i had this issue because i overided some form-classes in my template.tpl.php. After removed the overide function homebox saved the block settings as it should.
thanks for the hint drumm.
Comment #35
pkkelly commentedHi All
My issue is that the auto save is working when items are closed or added, but when items are moved to other columns the autosave is not being triggered.
Any pointers anyone?
I havent changed any form-classes in my template and have flushed all user settings and re-enabled the auto-save feature a few times now!
Comment #36
zazinteractive commentedI got:
An HTTP error 0 occured at /homebox/js/dashboard/save
When I click on add block, close a block on dashboard and then click on the same block in the add block menu
Comment #37
brianV commentedThat is not related. That error is generated when you try to perform an action (changing the page etc.) before an AJAX request is finished.