Closed (fixed)
Project:
Project
Version:
6.x-1.x-dev
Component:
ApacheSolr integration
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
23 Jul 2010 at 01:23 UTC
Updated:
3 Jan 2014 at 01:42 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
mikey_p commentedSince this is in the drupalorg namespace, I'm switching this to the that project, and tagging it. I'll try to review this and see if there are any duplications with the current code in drupalorg.module and if there is anything that needs cleaned up before committing.
I suppose it'd also be worth reviewing to see if there is duplicate code with project_solr, or if anything here should live in project_solr itself as well.
Comment #2
mikey_p commentedOkay, this module contains a version of the main D&E page that is found at /download. This partially duplicates what is in drupalorg.module HEAD right now, and also is perhaps part of the code that will be needed at: #666120: Provide API to get the top N projects for various categories(which I'll be linking to here).
Comment #3
mikey_p commentedComment #4
mikey_p commentedI spoke briefly with Damien that other day, and he mentioned that he saw this issue and that this code is somewhat out of date and that somewhere there is a newer version that he worked on.
Comment #5
csevb10 commentedThis was the latest code out of the staging5 repository. It's possible that there is a newer version somewhere, but this was the latest version in version control on the staging sites.
Comment #6
dwwMost of this module should die, or is duplicate with #868794: Add an apachesolr_result_block module to render solr facet results as blocks. However, if there's anything of value in here that's not related to the theme template for the /download page itself (which really is d.o-specific) it should become a patch for project_solr, not its own module in drupalorg.
If it turns out we already have all the facets we need, just set this to "by design". ;)
Thanks!
-Derek
Comment #7
csevb10 commentedComment #8
csevb10 commentedSmall additions to expose a sorting facet for most installed.
Comment #9
hunmonk commented'Most Installed' should be 'Most installed' to be consistent with the project browsing form, no? other than that this looks pretty straighforward. has it been tested?
Comment #10
dwwI'm not super familiar with the workings of this hook, but it seems like this should be wrapped within one of these:
Comment #11
csevb10 commentedGreat call. It wouldn't break anything, but it's useless without project_usage.
I changed to Most installed to match the casing of other facets, but we'll need to make sure we change the casing administratively when we launch _if_ we want to match the casing in the comps.
Comment #12
hunmonk commented#11 looks good. committed to 6.x-1.x-dev
Comment #13
hunmonk commentedper csevb10, this issue is complete.