This code comes from staging5. I need to review it and figure out what we need to keep/lose.

Comments

mikey_p’s picture

Project: Drupal.org Redesign » Drupal.org customizations
Component: Download and Extend » Code
Issue tags: +drupal.org redesign

Since this is in the drupalorg namespace, I'm switching this to the that project, and tagging it. I'll try to review this and see if there are any duplications with the current code in drupalorg.module and if there is anything that needs cleaned up before committing.

I suppose it'd also be worth reviewing to see if there is duplicate code with project_solr, or if anything here should live in project_solr itself as well.

mikey_p’s picture

Okay, this module contains a version of the main D&E page that is found at /download. This partially duplicates what is in drupalorg.module HEAD right now, and also is perhaps part of the code that will be needed at: #666120: Provide API to get the top N projects for various categories(which I'll be linking to here).

mikey_p’s picture

Title: D & E: Home » Provide D&E project listing blocks from solr queries
mikey_p’s picture

I spoke briefly with Damien that other day, and he mentioned that he saw this issue and that this code is somewhat out of date and that somewhere there is a newer version that he worked on.

csevb10’s picture

This was the latest code out of the staging5 repository. It's possible that there is a newer version somewhere, but this was the latest version in version control on the staging sites.

dww’s picture

Title: Provide D&E project listing blocks from solr queries » Provide additional solr facets for advanced project browsing
Project: Drupal.org customizations » Project
Version: » 6.x-1.x-dev
Component: Code » ApacheSolr integration

Most of this module should die, or is duplicate with #868794: Add an apachesolr_result_block module to render solr facet results as blocks. However, if there's anything of value in here that's not related to the theme template for the /download page itself (which really is d.o-specific) it should become a patch for project_solr, not its own module in drupalorg.

If it turns out we already have all the facets we need, just set this to "by design". ;)

Thanks!
-Derek

csevb10’s picture

csevb10’s picture

Status: Active » Needs review
StatusFileSize
new867 bytes

Small additions to expose a sorting facet for most installed.

hunmonk’s picture

Status: Needs review » Needs work

'Most Installed' should be 'Most installed' to be consistent with the project browsing form, no? other than that this looks pretty straighforward. has it been tested?

dww’s picture

I'm not super familiar with the workings of this hook, but it seems like this should be wrapped within one of these:

    if (module_exists('project_usage')) {
csevb10’s picture

Status: Needs work » Active
StatusFileSize
new970 bytes

Great call. It wouldn't break anything, but it's useless without project_usage.
I changed to Most installed to match the casing of other facets, but we'll need to make sure we change the casing administratively when we launch _if_ we want to match the casing in the comps.

hunmonk’s picture

#11 looks good. committed to 6.x-1.x-dev

hunmonk’s picture

Status: Active » Fixed

per csevb10, this issue is complete.

Status: Fixed » Closed (fixed)
Issue tags: -drupal.org redesign, -drupal.org redesign solr, -drupal.org redesign sprint 1

Automatically closed -- issue fixed for 2 weeks with no activity.