Hi,
I had a problem with lucene searching indexing, which uses nodeAPIs of other modules. With the help of the Luceneapi creator we narrowed it down to nodemap module, which appears to cause a problem with the way it implements parameter 3 of the nodeapi.

Is this right? Please check this post for further info - http://drupal.org/node/860248

Thanks, Joe

CommentFileSizeAuthor
#1 nodemap-862514-1.patch627 bytescpliakas

Comments

cpliakas’s picture

cpliakas commented
Status: Active » Needs review
StatusFileSize
new nodemap-862514-1.patch627 bytes

As per the hook_nodeapi() documentation at http://api.drupal.org/api/function/hook_nodeapi/6, the third parameter should not be passed by reference. This causes fatal errors in any module that invokes hook_nodeapi() passes a value directly as the parameter. The most notable modules that are effected by this bug are Apache Solr Search Integration and Search Lucene API. The attached patch fixes the issue, and was rolled against the DRUPAL-6--1-3 tag.

Thanks in advance for any time you can give to this post,
Chris

joecanti’s picture

joecanti commented

Thanks Chris! I was going to put a link on the lucene post which addressed this, but you got there first... I will apply and test, and post back here.

Thanks for your time, Joe

joecanti’s picture

joecanti commented

Looks like that works great - not sure if that has any side effect on general node map function, but works great when being indexed by luceneapi.

Thanks Chris - perfect!!

Joe