Why is tvi_get_term_info() getting called with an invalid $tid? Who knows! But it should fail more gracefully without Notice: Trying to get property of non-object in tvi_get_view_info() (line 247...

CommentFileSizeAuthor
#3 tvi-graceful-862712-2.patch687 bytesDanaRoseRoss
#1 tvi-invalid_tid-862712-1.patch420 bytesDanaRoseRoss

Comments

DanaRoseRoss’s picture

DanaRoseRoss commented
StatusFileSize
new tvi-invalid_tid-862712-1.patch420 bytes
DanaRoseRoss’s picture

DanaRoseRoss commented
Status: Active » Needs review
DanaRoseRoss’s picture

DanaRoseRoss commented
StatusFileSize
new tvi-graceful-862712-2.patch687 bytes

Additional patch to make another part of TVI handle the NULL now coming out of tvi_get_term_info()

derekwebb1’s picture

derekwebb1 commented

Thanks. We will review these items soon!

Cheers, Derek

jdanthinne’s picture

jdanthinne commented
Priority: Minor » Normal

Patch #1 working for me (on 7.x version)… no more notices. Please commit.

duaelfr’s picture

duaelfr
he/him
Primary language French
Location Montpellier, France
commented
Status: Needs review » Closed (fixed)