As a follow up to #694382: Remove cosmetic cruft from module's css files and along with the patch for the aggregator #749530: Clean up aggregator css styles here's a patch for block module css file.
I just left a declaration in the that makes draggable rows work properly by hiding the empty text (I wonder if the javascript code can take care of it so that we can remove this last declaration and ship without a css file)

#blocks tr.region-populated {
  display: none;
}

and deleted the following

#blocks tr.region-title td {
  font-weight: bold;
}
#blocks tr.region-message {
  font-weight: normal;
  color: #999;
}
.block-region {
  background-color: #ff6;
  margin-top: 4px;
  margin-bottom: 4px;
  padding: 3px;
}

More css clean-ups are coming. Let me know if you think this is the right approach and if there's time to have this changes in Drupal 7.

CommentFileSizeAuthor
#2 block.jpg26.58 KBdodorama
#2 block2.patch1.52 KBdodorama
block.patch686 bytesdodorama

Comments

jacine’s picture

jacine
she/her
Location New York
commented
Component: block.module » markup
Status: Active » Needs work

We need to either add a heading or strong tag for the region title, since we are removing the CSS here. A better tag makes more sense semantically anyway. Not sure about the JavaScript, but I think it's worth a shot.

dodorama’s picture

dodorama commented
StatusFileSize
new block2.patch1.52 KB
new block.jpg26.58 KB

A softer approach as suggested by Jacine with a strong tag added to the region title. The only visual difference is the region message. I think the emphasis is enough, no need to change color.

Jeff Burnz’s picture

Jeff Burnz commented
Status: Needs work » Needs review
jacine’s picture

jacine
she/her
Location New York
commented
Version: 7.x-dev » 8.x-dev

Unfortunately, I think it's too late for this one too. We'll definitely revisit this as soon as we can start working on D8.

droplet’s picture

droplet commented

TH is more right if this is possible.

jacine’s picture

jacine
she/her
Location New York
commented
Status: Needs review » Needs work
Issue tags: +Front end

Tagging, and marking CNW, per #5. Also:

  • This could easily be made to use <th>, and should. See block-admin-display-form.tpl.php.
  • We should be separating admin vs. front end styles here. Everything that's in block.css is administrative, so belongs in a file called block.admin.css. When this is done, there shouldn't be a block.css file at all.
  • Also, let's stop styling ID's here. I suggest adding a class block-admin-display-form or something similar to the table and styling against that instead.
cosmicdreams’s picture

cosmicdreams commented

I don't know if I'm doing something wrong but I can't apply this patch I keep getting the following error:

fatal: corrupt patch at line 36

yesct’s picture

yesct commented
Issue summary: View changes
Issue tags: -Front end +frontend

correcting the tag to the more common one.

Bojan Zivkov’s picture

Bojan Zivkov commented
Status: Needs work » Closed (fixed)

I think this is covered by #1216950: Clean up the CSS for Block module. Please reopen if I'm mistaken.

Bojan Zivkov’s picture

Bojan Zivkov commented
Status: Closed (fixed) » Closed (duplicate)