(This was mentioned in my other report when I thought it was another symptom of the same problem. Opening another bug report now I know it's not)

Initial description of steps to reproduce:

1) Create a new mini panel with the panany theme installed (not sure panany is significant, but I'm using one of its styles below).
2) Use the flexible layout style but don't worry about modifying the layout (it doesn't make a difference).
3) Seek to change the style for the 'Center' region to "Panany gradient background" and click next.
4) Regardless of whether you select to surround panes or panels, when you cliick the Save button, you get a popup error message:

Unable to complete operation. Fatal error in panels/plugins/display_renderers/panels_renderer_editor.class.php on line 1669: Function name must be a string

panels_edit_style_settings_form gets called once when going from the initial ajax form to the Style Settings form. On that occasion, $style contains an array containing the details of the new style that has been chosen, and all is well with the world.

When you click 'Save' to actually store the change, however, panels_edit_style_settings_form is called again. This time, however, $style matches the old style. If the old style was 'Default', $style is empty, resulting in the above error.

I don't understand enough of Drupal yet to understand how the setting for $style is supposed to be retained across the two ajax submissions, so I'm going to stop here and hope the above is of some help to you.

CommentFileSizeAuthor
#13 Capture.PNG55.32 KBVote_Sizing_Steve
#11 minipanel.jpg52.52 KBusa2k
#10 ctools.jpg37.16 KBusa2k
#9 fatal_error.png38.35 KBmalc0mn
#3 865704-mini-panels-style-edit-fail.patch2.3 KBmerlinofchaos
#2 865704-mini-panels-style-edit-fail.patch1.92 KBmerlinofchaos
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

smoothify’s picture

smoothify CreditAttribution: smoothify commented

I am getting this issue too, with a couple of different styles (panels_tabs & one of my own)

I noticed the same behaviour as Nigel, in that the $style variable is correct when the settings form loads, but shows the previous style when you press save.

When doing the same on a panel page, it works just fine and retains the correct $style information after saving.

merlinofchaos’s picture

merlinofchaos CreditAttribution: merlinofchaos commented
Status: Active » Needs review
FileSize
865704-mini-panels-style-edit-fail.patch1.92 KB

Ok, this one is due to accidentally losing some portions of a cache.

This patch fixes it for me. Can I get a confirmation?

merlinofchaos’s picture

merlinofchaos CreditAttribution: merlinofchaos commented
FileSize
865704-mini-panels-style-edit-fail.patch2.3 KB

Cough. Last patch will wreck your mini panel if you hit save. This one seems to not do that. =)

smoothify’s picture

smoothify CreditAttribution: smoothify commented

Thanks Merlin

The second patch fixes it for me - works on both region and mini-panel basis, and saves with out borking the mini panel too!

merlinofchaos’s picture

merlinofchaos CreditAttribution: merlinofchaos commented
Status: Needs review » Fixed

Great. Committed!

AH28’s picture

AH28 CreditAttribution: AH28 commented

I am new to this and am having the same problem. Can you tell me how to apply the patch? Thank you!

smoothify’s picture

smoothify CreditAttribution: smoothify commented

The drupal handbook page for applying a patch is here:

http://drupal.org/patch/apply

malc0mn’s picture

malc0mn CreditAttribution: malc0mn commented

Hmz, patch applied succesfully but does not seem to work for me. Still get the same error...

Applied to 6.x-3.7 ...

malc0mn’s picture

malc0mn CreditAttribution: malc0mn commented
FileSize
fatal_error.png38.35 KB

A screenshot now...

Error is the same, though on a different line thant the subject in this thread. Line number was always different though, prolly because I don't use the dev version, like him/her: #869414: Fatal error in panels_renderer_editor.class.php on line 1674: Function must be a string

usa2k’s picture

usa2k CreditAttribution: usa2k commented
Status: Fixed » Needs work
FileSize
ctools.jpg37.16 KB

@merlinofchaos in #5 said committed.

So the dev version is the fix, but then says the version of ctools is too old to use! :(
(Even though ctools is current. Chaos tool suite 6.x-1.7)

UPDATE:

I edited panels.module to look for version 1.7 of ctools, not 1.8, then ran update.php.
admin/build/mini-panels/list/firstplace/edit/content gets a fatal error now at
sites/all/modules/panels/plugins/display_renderers/panels_renderer_editor.class.php on line 318

I think I'll go back to the non-dev for now.

MORE UPDATE:

Using the non-dev I can get rouned corners without an error like post #9
if I use the right hand edit button to style :)
The left hand produces an error like post #9

Image attached ... huh can't add another image on edit. See the next post.

usa2k’s picture

usa2k CreditAttribution: usa2k commented
FileSize
minipanel.jpg52.52 KB

The image for the previous post's edit.

merlinofchaos’s picture

merlinofchaos CreditAttribution: merlinofchaos commented
Status: Needs work » Fixed

I edited panels.module to look for version 1.7 of ctools, not 1.8, then ran update.php.
admin/build/mini-panels/list/firstplace/edit/content gets a fatal error now at

...and this surprises you why? There's a reason I put those numbers in. If you get the -dev version of Panels you pretty much have to get the -dev version of CTools. I'm not even interested in bug reports about trying to have them out of sync and forcing the issue. Was it really too much trouble to go update CTools at the same time?

Vote_Sizing_Steve’s picture

Vote_Sizing_Steve CreditAttribution: Vote_Sizing_Steve commented
FileSize
Capture.PNG55.32 KB

Unable to set a custom style in my Display settings.

Also having the same problems as "Setting mini panel content visibility rule makes content invisible and cannot be undone" (http://drupal.org/node/869612).

Vote_Sizing_Steve’s picture

Vote_Sizing_Steve CreditAttribution: Vote_Sizing_Steve commented

Am now having much luck with the dev version setting the rules. Yipee, thanks!

I'll post later when I know about the (perhaps related) mini panel display style setting holding (http://drupal.org/node/865704).

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Nolza’s picture

Nolza CreditAttribution: Nolza commented

A bit of a tangent on this one, but in the newest panels 3.8 with ctools 1.8 and drupal 6.19 and the latest Skinner, I am able to select the Skinr settings and save under Mini Panels, but the panel does not display the saved settings. Switching to "System Block" however, allows Skinr settings I have saved under Blocks configurations to show. This is a standing workaround for those who are experiencing the same issues as me.