The name for schedule() and unschedule() is misleading. It suggests that a job is being scheduled for execution some time in the future, while it is being dispatched for ASAP execution.

1. Rename schedule() to dispatch()
2. Make finished() accept a progress flag that is stored in feeds_schedule.progress.
3. In finished() set last_executed_time when progress == FEEDS_BATCH_COMPLETE.
4. Make dispatcher query only select feeds where progress == FEEDS_BATCH_COMPLETE.
5. Remove unschedule(), finished() can be used instead (see 3.)
6. Find a better name for finished() ? complete() ?

Comments

alex_b’s picture

alex_b commented

Thanks to andrewlevine whose review here #721428-12: Make scheduler next scheduled time based led to this cleanup ticket.

alex_b’s picture

alex_b commented
Status: Active » Closed (duplicate)

Fixed #908964: Break out job scheduler