subscriptions.module: Saving nodes resets OG e-mail subscription settings

first, make sure you have latest code. next, you would have to run a SQL statement to set this for existing users. try

UPDATE og_uid_global SET og_email=1

use 4.7 tag if you are running 4.7. else use "cvs"

Well, actually... I was just about to complain about a problem with e-mails. Since the change in e-mail settings I've been having trouble receiving e-mails. I have set my profile to "always receive e-mails"; it seems to work for a few hours/e-mails, but then I simply stop receiving e-mails. After I updated the module to the latest version, today, the same thing happened: e-mails worked fine for me for a while, and now I get no e-mails.

By the way, Jason... the e-mails og.module sends are not registered by the "watchdog" page, in case you're trying to find them there.

I just checked in a fix for a user preference that might have caused this bug. please update (wait 12 hours if pulling from drupal.org web site) and retry. you might re-save your user profile to be sure.

Subscribing for now...

Hey Moshe, I keep getting the same problem (i.e. e-mails are sent for awhile, and then they stop) after this update, but now I can at least see something wrong: my user profile keeps defaulting to the "never receive e-mails" option every once in awhile. I don't even have the slighest clue about when or why this happens; any thoughts?

So far I can't seem to find any other users complaing of the same, so it might be happening only to me, the superuser or whatever I'm called.

Okay, I found it! When I edit a node (any node, doesn't have to have anything to with nodes related to OG posts) my e-mail settings go back to the "Never receive anything" option.

Let me run a couple more tests.

Okay, so this happens when you edit or publish a new node: the subscription option goes back to the "Never receive" option.

I just logged in using a normal user account and this happened to me too, which is strange because I haven't got complains from the other users, but I guess it's possible; it's only been a few days since this started to happen.

ok, just checked in a fix. please evaluate and let me know. if downloading from tarball on the web, wait 12 hours ...was a very tricky mysql NULL problem. and a display problem on the 'manage subscription' page. not related to node save i think.

Sorry man... I still get the same error. I edit a node somewhere, and bang, my account setting for group e-mail subscriptions goes back to "never receive e-mails". Don't you get this behavior? Maybe it's an issue that only pops up together with some other module I have installed?

Isn't anybody else complaining about this? Could be it an issue that only pops up when you have some other weird module installed?

Can I do anything to help out on this? Like installing the devel.module and post here the info that crops up when one edits/creates a node; something like that?

yes, that would be helpful. specifically, you want to look for any queries that do an INSERT or UPDATE against the pg_uid or og_uid_global tables. you will have to turn on the 'stop form redirection' feature of devel so you actually see the queries on the submit page before you get redirected to view node page.

you could also try disabling other mdules and see if that helps. especially be wary of ones that will re-save the user object after a node post like user points or similar.

Okay, so I get these lines as the final queries for the subscription.module (after it has finished inserting into the watchdog table the "subscription sent" notices):

user_fields -- SELECT * FROM users WHERE uid = 1
og_user -- UPDATE og_uid_global SET og_email=0 WHERE uid=1

And disabling the subscriptions.module avoids the og_email settings getting lost. So, does this issue belong to the subscriptions.module or the og.module?

yes, belongs there. if one wants to perform a user_save(), one has to do a user_load() first. one cannot just SELECT * FROM users.

note that subscription and subscriptions (note the s at end) are different modules. you use both in your post so i don't know which is misbehaving. please reaffiliate this issue with the right module.

actually, this issue started out as some other bug and i close it now. please reopen a bug against subscription(s).