Different places in the code supply different default values to variable_get($variable_name, $default_value).

E.g.:

    'title'            => variable_get('forward_epostcard_title', 'Send an e-Postcard'),
...
    '#default_value' => variable_get('forward_epostcard_title', t('Send an e-Postcard')),

    drupal_set_title(variable_get('forward_page_title', 'Forward this page'));
...
        'attributes' => array('title' => variable_get('forward_page_title', t('Forward this page to a friend')), 'class' => 'forward-page'),

Likewise for forward_page_title, forward_thankyou and site_name. The latter should default to "Drupal".

Comments

seanr’s picture

seanr
he/him
commented
Status: Active » Fixed

Regarding the first one, hook_menu doesn't need the t() function - the menu system does it automatically later on. The other one and the Drupal vs drupal ones are fixed. The forward_thankyou value does match in both places where it appears.

c960657’s picture

c960657 commented
Status: Fixed » Active

Regarding forward_page_title: These two occurrences differ:

 drupal_set_title(variable_get('forward_page_title', 'Forward this page'));

 'attributes' => array('title' => variable_get('forward_page_title', t('Forward this page to a friend')), 'class' => 'forward-page'),

Regarding forward_thankyou: These two occurrences differ (there is one or two spaces before “We appreciate”):

 '#default_value' => variable_get('forward_thankyou', 'Thank you for your help in spreading the word about !site.  We appreciate your help.'),

 drupal_set_message(check_plain(t(variable_get('forward_thankyou', 'Thank you for your help in spreading the word about !site. We appreciate your help.'), array('!site' => variable_get('site_name', 'Drupal')))), 'status');

BTW, HEAD contains a few stray dsm() calls.

seanr’s picture

seanr
he/him
commented

Both of those are fixed now. I've commented out the dsm calls, but it should be noted that the D7 port of this is VERY much a work in progress. Email formatting is currently quite broken, for example. ;-)

seanr’s picture

seanr
he/him
commented
Status: Active » Fixed

Found a few more, fixed and committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.