Closed (fixed)
Project:
Feeds
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Anonymous (not verified)
Created:
4 Aug 2010 at 02:12 UTC
Updated:
16 May 2024 at 00:51 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
Anonymous (not verified) commentedI worked out why this wasn't working - it's a bug.
The attached patch fixes it by merging the existing value (if any) with the new value(s). It was previously ignoring the existing value and overwriting it.
Let me know if this patch fixes it for you too.
Comment #2
Anonymous (not verified) commentedWould the same thing apply for taxonomy.inc?
For example, using a free tagging - multitag 'Categories' vocabulary:
Source -> Target:
------------------
Category Level 1 -> Categories
Category Level 2 -> Categories
Category Level 3 -> Categories
The result is, only Level 3 is stored in Categories, 1 & 2 are lost.
Comment #3
Anonymous (not verified) commentedIn mappers/taxonomy inc, I think this is the solution, change:
to this:
I still need to test this.
Comment #4
Anonymous (not verified) commentedI tested the patches (mine attached now), and they really work.
My patch is for 6x10-beta4, but it should apply to latest dev.
If the maintainers feel they should be part of feeds, please include them.
Comment #5
Anonymous (not verified) commentedOn a side not, my patch might need array_unique to reduce duplicates,
$terms = array_unique(array_merge($terms, explode(',', $node->taxonomy['tags'][$vocab->vid]));Unless Drupal does this anyway.
Comment #6
alex_b commentedarray_unique is not necessary as taxonomy uses drupal_explode_tags() to split tags - which in turn uses array_unique. We should be using drupal_explode_tags(), too btw.
Comment #7
alex_b commentedCommitted, thank you.
http://drupal.org/cvs?commit=416046