When not used, the field descreption area is present. The description areas of default contact form fields are hidden when they are not in use. It leads to a form with different spaces between the fields. Scripters can solve it in css (.description {
display: none;}), but nicer is solving it in the module depending on content.

CommentFileSizeAuthor
#7 description.jpg129.57 KBAnonymous (not verified)
#5 description area.jpg49.35 KBAnonymous (not verified)

Comments

beautifulmind’s picture

Do you mean when #description is empty, it should not be used? Okay.
Thanks for your concern and raising the issue.
Regards.

beautifulmind’s picture

Thanks for raising the issue. I have fixed the issue and you can use the latest dev version ( > August 4).

Regards.

Anonymous’s picture

I tried the 4 aug 2010 - 1:04 version, it has no effect.

What i meant you can see om http://www.mirakel.cmseasy.nl/contact. Click the "info" button. The field "Uw telefoonnummer" is a Contact Form Field and has a "bottom margin" created by the description area (class) of the field. Description is not used here.
Other fields are default Contact fields without a description and without the description area/class.

Regards
Martin

beautifulmind’s picture

Yes I got the issue and if you observe the cvs messages on project description page, you will find a message regarding committing a fix for this. The fix is not updated in the dev version because Drupal may include when next cron runs. Which is why I advised to use version having date > 4th August.

Thanks for you concern.
Regards.

Anonymous’s picture

StatusFileSize
new49.35 KB

Hi,

On aug 5 I tried the cvs patch 'commit #402590' and today the dev release 5 aug. I see no changes, it didn't solve the issue.

Maybe there is a misunderstanding what I meanth. Comment #3 gives I good explanation and in the attached image it is the space between the fields "Uw telefoonnummer" and "Uw emailadres": It is different compared to the other (default contact module) fields caused bij the description area of the contact form field "Uw telefoonnummer".

Thanks for the attention and effort that you give, it is a little layout issue that can be solved in css by css scripters.

Martin

beautifulmind’s picture

Do you mean those empty span tags?

Anonymous’s picture

StatusFileSize
new129.57 KB

The div class description with the <br> in it.
see att.

beautifulmind’s picture

Please make sure that you have following code at line #168 in contact_field.module file

foreach ($am__settings as $key => $value) {
      if ($key != 'title' && $value != "") {
        $am__field[$om__result->field_name]["#". $key] = $value;
      }
    }

I, in no way, was able to generate the issue after adding this code. The August 5 commit includes this code.

Thanks for your concern. I really appreciate it.
Regards.

Anonymous’s picture

The <br> code in de class reminded me that I have CKE editor installed, And yes, this is a part of code CKE editor leaves in an empty field. After switching of the editor and saving a clean field it was solved.

Thanks for helping in this, problem was not contact form field related and solved.

beautifulmind’s picture

Status: Active » Closed (fixed)

Thank you.