Clicking Add button does nothing.

CommentFileSizeAuthor
taxonomy manager wont add2.gif196.81 KBzet

Comments

alrick’s picture

Had the same issue - tried all popular browsers, to no avail.

What fixed the issue is installation of jQuery modules.

zet’s picture

All of them ?

zet’s picture

Taxonomy Manager Drupal 5 and JQuery Upadate module:
In case you are using the JQuery Update module v2.x on your D5 installation, the Taxonomy Manager won't work. See this issue for more information.
To fix the problem download the tree.js file and replace it with the one included in the taxonomy manager folder under /js.

I am using JQuery Update module v2.x , but on D6 installation, the explanation above is for D5. Does anyone know what to do is D6? Maybe doing the same thing works for D6 too ? Has anyone tried ?

reinis.berzins’s picture

Priority: Normal » Critical

I tested both with and without "jQuery update" module, and both with Taxonomy manager 6.x-2.2 and 6.x-2.x-dev - the buttons in the Taxonomy manager just do nothing.

P.S. I changed it the issue priority to "Critical" as the module doesn't work at all.

pglatz’s picture

I'm experiencing the same issue; the add and delete buttons have no effect. I followed the above link to "jQuery modules", but the page says "jQuery libraries", and there are no releases for it.

mh86’s picture

without any jQuery updates, I'm pretty sure the buttons are working (you can test this at my demo site --> http://mhutterer.at/?q=admin/content/taxonomy_manager)

which version of the jQuery module are you using (all v2.x?) or is there any other module which might change the jQuery libs?

pglatz’s picture

I'm up to date on core (6.19) and all modules, according to the available updates page.

jQuery Update 6.x-1.1
jQuery UI 6.x-1.3
jQuery plugins 6.x-1.10

jQuery Update 6.x-1.1 is bringing in jQuery 1.2.6

Core 6.19 also uses jQuery 1.2.6; how shoul;d I be bringing in 2.x? I thought jQuery Update would have. Thanks for the link to your site; yes, it works for me.

mh86’s picture

is it possible for you to disable the jQuery modules one after the other and see if the Taxonomy Manager starts working? this would be of great help identifying the conflict

pglatz’s picture

I disabled jQuery Update 6.x-1.1 and the problem went away.

Thanks for your suggestion, all seems fine now.

reinis.berzins’s picture

Buttons don't react even on a fresh Drupal installation with only few core modules enabled. The same thing happens to both my websites - both hosted on Hostmonster.com.

At first when I clicked on an empty vocabulary "Forums" and I was offered to enter multiple terms and press "Add" button which worked well, however afterwards when the interface changed to taxonomy term tree with buttons above it - these buttons didn't react anymore. However, I could expand/collapse the term tree (even for 3 sub-terms it took long ~5 seconds to expand). I could open the term edit block by clicking on the term hyperlinks in the tree which happened very slowly, reloading the whole page.

Following the suggestions in other comments I first installed "jQuery update" module and then uninstalled, but Taxonomy manager's buttons didn't react in any case.

gease’s picture

In my case, there was a conflict with cleanr theme, which I used in admin (http://drupal.org/node/761764). jQuery Update v.6-2.dev, which uses jQuery v. 1.3.2, instead makes no conflict.

trevorbradley’s picture

I also hit a problems with buttons not working after manually updating misc/jquery.js . Reverting back to the standard version makes the buttons work again. (subscribing)

EDIT (2010-11-24): I'd really love to see a version of taxonomy manager that works with the most recent jquery.js, as other jquery libraries (jquery.url.js, for instance) can't use the older jquery.js. I have to choose between taxonomy manager and newer jquery libs.

DeNelo’s picture

I second #10 and #12. Using Bartik theme.
Standard Taxonomy module works fine.

mh86’s picture

just realized, that D7 affected as well. seems to be related to some Drupal updates.
going to look at this as soon as possible

DeNelo’s picture

Yay!

mh86’s picture

committed fixes for D7, problem was related to #208611: Add drupal_array_merge_deep() and drupal_array_merge_deep_array() to stop drupal_add_js() from adding settings twice
still sometimes issues with validation errors and refreshing, but in general buttons work now

manveru’s picture

Does not work for me, too, on Firefox 4 in Drupal 7. Version: 7.x-1.x-dev latest today (ie. 23 Apr)

All buttons do not work.

jaxon77’s picture

Version: 6.x-2.2 » 7.x-1.0-beta1

Having the same issue in drupal 7. None of the buttons work when clicked. Using the most up to date drupal and taxonomy manager.

DeNelo’s picture

Still doesn't work... Sorry, have no new information to add. Just that it still does not work. At one point I saw it working, but in this clean install of Drupal 7 it doesn't.
Please tell me if I need to check something or what information I should provide to you.

mh86’s picture

Status: Active » Fixed

This should be fixed with #1004988: Nothing works in Tao based themes (also affected other themes).
Please re-open, if the buttons still do not work!

DeNelo’s picture

Using Seven as admin theme. Tried Stark and others to no effect.
I have not installed the JQuery Update module (updates Drupal 7 to jQuery 1.5.2 and jQuery UI 1.8.11) - should I?

mh86’s picture

Status: Fixed » Active

hm, difficult to tell. The JS for the buttons is pretty simple and I have no idea why I doesn't work for some people (a JQuery update should not be necessary).
Can you tell me which id the input button "Add" and its corresponding hidden fieldset have?

DeNelo’s picture

<fieldset id="taxonomy-manager-toolbar" ...
<input type="button" id="edit-add-show" value="Add" class="taxonomy-manager-buttons add">

...
- is that what you are asking?

mh86’s picture

Button looks good. Can you find a '? It might be hidden.
I will release a new beta soon, which also means that this issue won't be fixed in the new beta release, but we can do that afterwards!

DeNelo’s picture

Ha! Found it.
If the Devel > Theme developer module is enabled, Taxonomy Manager does not work.
If the Devel > Theme developer module is disabled, Taxonomy Manager works beautifully.
Perhaps that should be added as a note somewhere (or fixed)! :)

Thanks for going into this (and for the module, by the way!)

mh86’s picture

Title: Clicking Add button does nothing » Clicking Add button does nothing with Devel Theme developer

Thanks for this information, now it's possible to fix it!
I will take a look at it soon!

mh86’s picture

Title: Clicking Add button does nothing with Devel Theme developer » Incompatible with Devel Theme developer
Status: Active » Closed (won't fix)

I was taking a look at this issue and it seems to be hard to fix. On the one hand Devel themer changes the html output, which is problematic for JS selectors (although some could be easily fixed) and on the other hand it somehow damages my AJAX callbacks.

Marking this issue as won't fix (except someone else wants to take care) and adding a note to the fronpage.

zet’s picture

Title: Incompatible with Devel Theme developer » Clicking Add button does nothing
Version: 7.x-1.0-beta1 » 7.x-1.0-rc1
Status: Closed (won't fix) » Active

I'm reopening this instead of creating a new issue, and changed the title back, because this is not just a devel module incompatibility.

Here is my current list of enabled modules, with which the add button does the same (nothing)
Devel module is not installed and inexistent, never installed.

Pachet Nume Tip Versiune
Administration Administration menu (admin_menu) Module 7.x-3.0-rc3
Administration Administration menu Toolbar style (admin_menu_toolbar) Module 7.x-3.0-rc3
Chaos tool suite Chaos tools (ctools) Module 7.x-1.2
Chaos tool suite Field API Pane Editor (fape) Module 7.x-1.1
Core Block (block) Module 7.17
Core Color (color) Module 7.17
Core Comment (comment) Module 7.17
Core Contextual links (contextual) Module 7.17
Core Dashboard (dashboard) Module 7.17
Core Database logging (dblog) Module 7.17
Core Field (field) Module 7.17
Core Field SQL storage (field_sql_storage) Module 7.17
Core Field UI (field_ui) Module 7.17
Core File (file) Module 7.17
Core Filter (filter) Module 7.17
Core Help (help) Module 7.17
Core Image (image) Module 7.17
Core List (list) Module 7.17
Core Locale (locale) Module 7.17
Core Menu (menu) Module 7.17
Core Node (node) Module 7.17
Core Number (number) Module 7.17
Core Options (options) Module 7.17
Core Path (path) Module 7.17
Core RDF (rdf) Module 7.17
Core Search (search) Module 7.17
Core Shortcut (shortcut) Module 7.17
Core System (system) Module 7.17
Core Taxonomy (taxonomy) Module 7.17
Core Text (text) Module 7.17
Core Update manager (update) Module 7.17
Core User (user) Module 7.17
Currency Currency (currency) Module 7.x-1.0
Currency Currency API (currency_api) Module 7.x-1.0
Development ModuleInfo (moduleinfo) Module 7.x-1.0
Development Patch manager (patch_manager) Module 7.x-1.0
Features Features (features) Module 7.x-1.0
Internet-Marketing Currency Converter Zet (currency_converter_zet) Module 7.x-1.2
Location Smart IP (smart_ip) Module 7.x-1.7
Media Imagecache Actions (imagecache_actions) Module 7.x-1.0
Media Imagecache Canvas Actions (imagecache_canvasactions) Module 7.x-1.0
Multilingual Localization update (l10n_update) Module 7.x-1.0-beta3
OM OM Maximenu (om_maximenu) Module 7.x-1.44
OM OM Tools (om_tools) Module 7.x-2.13
Other Automatic Nodetitles (auto_nodetitle) Module 7.x-1.0
Other Entity API (entity) Module 7.x-1.0-rc3
Other Icon fonts (admin_icons) Module 7.x-1.x-dev
Other Libraries (libraries) Module 7.x-2.0
Other LoginToboggan (logintoboggan) Module 7.x-1.3
Other Permissions grid (permission_grid) Module 7.x-1.2
Other Weather (weather) Module 7.x-1.3
Spam control CAPTCHA (captcha) Module 7.x-1.0-beta2
Spark Edit (edit) Module 7.x-1.0-alpha5
Taxonomy Taxonomy Manager (taxonomy_manager) Module 7.x-1.0-rc1
User interface Aloha Editor (aloha) Module 7.x-2.0-alpha1
User interface Filter â "true WYSIWYG" (filter_true_wysiwyg) Module 7.x-2.0-alpha1
User interface jQuery Update (jquery_update) Module 7.x-2.2
Views Better Exposed Filters (better_exposed_filters) Module 7.x-3.0-beta3
Views Views (views) Module 7.x-3.5
Views Views Bulk Operations (views_bulk_operations) Module 7.x-3.0
Views Views Slideshow (views_slideshow) Module 7.x-3.0
Views Views UI (views_ui) Module 7.x-3.5

zet’s picture

Title: Clicking Add button does nothing » Clicking Add button does nothing - incompatibility with Devel module and Tao based themes (like Rubik)
Issue tags: +Clicking Add button does nothing - incompatibility with Devel module and Tao based themes (like Rubik)

ModuleInfo (moduleinfo) Module 7.x-1.0
Aloha Editor (aloha) Module 7.x-2.0-alpha1
Filter â "true WYSIWYG" (filter_true_wysiwyg) Module 7.x-2.0-alpha1
jQuery Update (jquery_update) Module 7.x-2.2
Spark Edit (edit) Module 7.x-1.0-alpha5

Still not working after disabling the modules above

Later Edit :
After reading #23, I changed Rubik administration theme to Seven - now Add button works

It should be specified on the module's project page too, that The Taxonomy Manager is incompatible with the Tao based themes like Rubik, because a lot of drupal users use Rubik as an administration theme and even some Drupal distribution are using it.

lpedretti’s picture

Problem is in tao theme's template.php's tao_preprocess_fieldset() function.

In line 212

  if (!empty($element['#id'])) {
    $vars['attributes']['id'] = $element['#id'];
  }

But in the toolbar $vars there is

[#id] => edit-toolbar

inside the "element" key, that confuses tao's preprocess function and ends with the toolbar having an id='edit-toolbar'. That breaks hideForm.js , line 10:

$('#taxonomy-manager-toolbar', context).once('hideForm', function() {
,,,

#taxonomy-manager-toolbar does not exists anymore, there's only #edit-toolbar.

One solution, replace tao's template.php code at line 212 with:

  if (!empty($element['#id'])) {
  	if (!empty($element["#attributes"]["id"])) {
		$vars['attributes']['id'] = $element["#attributes"]["id"];
	} else {
		$vars['attributes']['id'] = $element['#id'];
	}
  }

There may be better solutions, i didn't think of, but as of this, it works and doesn't break other parts of my site's administration backend.

Hope it helps!

Best regards.

myAppyness’s picture

#30 works like a charm

star-szr’s picture

Closed #1004988: Nothing works in Tao based themes as a duplicate of this issue.

Peter Arius’s picture

#30 works for me, too.

Taxonomy Manager 7.x-1.0-rc1
Tao 7.x-3.0-beta4
Rubik 7.x-4.0-beta8
Drupal 7.19

The same issue is filed for Rubik theme, too: #1798256: Incompatible with Taxonomy Manager: Toolbar buttons are not clickable.

Edit: re-opened #1016844: Taxonomy Manager broken - incompatibility with Tao based themes (like Rubik) for tao, because that seems to be the right issue to follow.

aviddv1’s picture

#30 worked for me.

wiifm’s picture

Status: Active » Closed (duplicate)

I think it makes sense to close this issue as a duplicate, and focus on getting this committed into the theme Tao.

Please refer to http://drupal.org/node/1016844#comment-7091182 for a patch that will address this (same as #30)

haydeniv’s picture

Category: Bug report » Task
Priority: Critical » Normal
Issue summary: View changes
Status: Closed (duplicate) » Active

Reopening this because the Taxonomy Manager project page can use an update.

Drupal 7
The Taxonomy Manager is incompatible with the Devel Themer (#874488: Clicking Add button does nothing - incompatibility with Devel module and Tao based themes (like Rubik) )

Is no longer relevant as this was fixed in TAO beta-4.

pimok3000’s picture

Using D7.38 and Seven Theme as Admin Theme, i still faced this issue. Enabling Bartik as administration theme, doing the things i wanted to do and re-enabling seven as admin theme again solved the issue that the Buttons didn´t work.

  • mh86 committed db7ab3f on 8.x-1.x
    #874488 fixing toolbar buttons
    
    
tryitonce’s picture

just came across the same problem - Taxonomy Manager not clickable terms in Seven theme.
My solution - well, this initial idea is not working - refering to the taxonomy_manager.css.

avpaderno’s picture

Issue tags: -Clicking Add button does nothing - incompatibility with Devel module and Tao based themes (like Rubik)

I am removing the tag, since it's duplicating the issue title. I apologize for bumping this issue.

vladimiraus’s picture

Status: Active » Closed (outdated)

Thank you for contribution. 👍
Drupal 7 is no longer supported. 🤷‍♂️
Closing as outdated. 🔐