Remove CVS access tab in favor of the project maintainers form [#880818]

See #69556: move "cvs access" tab into project, make it generic for background. Once that lands, we need a patch to rip out the "CVS access" code entirely, and convert this stuff to use the new project maintainers form and related code (e.g. hook_project_permission_info()).

Comment	File	Size	Author
#4	880818-4.cvs_project_maintainers.patch	12.51 KB	dww
#4	880818-4.cvs_project_maintainers.interdiff.txt	2.94 KB	dww
#1	880818-1.cvs_project_maintainers.patch	12.53 KB	dww

Comments

Comment #1

dww

we/he/they

commented 13 August 2010 at 23:59

Assigned:	Unassigned	» dww
Status:	Active	» Needs review

Status	File	Size
new	880818-1.cvs_project_maintainers.patch	12.53 KB

This should be everything we need. Might be worth adding some tests for this, too, but cvs.module is a dying beast, so I'm not sure it's worth the effort.

Comment #2

dww

we/he/they

commented 16 August 2010 at 22:05

Over at #69556-7: move "cvs access" tab into project, make it generic I originally proposed this permission should be called "Write to CVS". Then at #69556-9: move "cvs access" tab into project, make it generic I switched it to "Administer CVS" as I wrote "for consistency". Now that's considered a UI bug. ;) Heh.

So, should we just move it back to "Write to CVS"? I think that's better than "Access CVS" since anyone still has read-only access. This is specifically about controlling write access, so "write" should be in the name. "CVS write access" also works (although it's a bit longer).

Thoughts?

Thanks,
-Derek