If you choose a pager position no pager settings are displayed.

CommentFileSizeAuthor
#1 884076-pager_settings-1.patch2.77 KBredndahead

Comments

redndahead’s picture

Status: Active » Fixed
StatusFileSize
new2.77 KB

This patch was committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

dtarc’s picture

I'm not seeing pagers enabled. The patch in #1 adjusts the keys for the views areas for which to put the pager in, but I'm seeing an unrelated issue.

Using Drupal 6.19, Views 6.x-3.x-dev (Aug 17) Views Slideshow 6.x-3.x-dev (Aug 16)

It looks like the pager is only generated when the pager type is set to fields. If the pager is set to Numbered or Thumbnails, there is no pager.

Looking at views_cycle_slideshow.theme.inc it is pretty clear that no pager is being generated for those pager types:

function theme_views_slideshow_cycle_pager($vss_id, $view, $options) {
  $pager_type = $options['views_slideshow_cycle']['pager_type'];

  $attributes['class'] = 'views_slideshow_cycle_pager views_slideshow_pager_' . $pager_type;
  $attributes['id'] = "views_slideshow_cycle_pager_" . $vss_id;
  $attributes = drupal_attributes($attributes);
  
  $output = '';
  if ($pager_type == 'thumbnails' || $pager_type == 'numbered') {
    $output = '<div' . $attributes . '></div>';
  }
  else if ($pager_type == 'fields') {
    $output = '<div' . $attributes . '>';
    foreach ($view->result as $count => $node) {
      $rendered_fields = '';
      foreach ($options['views_slideshow_cycle']['pager_fields'] as $field => $use) {
        if ($use !== 0 && is_object($view->field[$field])) {
          $rendered_fields .= '<div class="views-field-'. views_css_safe($view->field[$field]->field) .'">';
          if ($view->field[$field]->label()) {
            $rendered_fields .= '<label class="view-label-'. views_css_safe($view->field[$field]->field) . '">';
            $rendered_fields .= $view->field[$field]->label() . ':';
            $rendered_fields .= '</label>';
          }
          $rendered_fields .= '<div class="views-content-'. views_css_safe($view->field[$field]->field) .'">';
          $rendered_fields .=  $view->style_plugin->rendered_fields[$count][$field];
          $rendered_fields .= '</div>';
          $rendered_fields .= '</div>';
        }
      }
  
      $output .= theme('views_slideshow_cycle_pager_item', $rendered_fields, $vss_id, $count);
    }
    $output .= '</div>';
  }
  return $output;
}
dtarc’s picture

Status: Closed (fixed) » Needs work
redndahead’s picture

I'll check it out, but all numbered or thumbnails needs is to output that div that you can see on the 9th line. Javascript takes care of the rest.

dtarc’s picture

Hmm...this may be a javascript issue then from the sounds of it, I'll check out what's going on with the js.

redndahead’s picture

Status: Needs work » Fixed

I have tested all 3 pagers working in cycle with this patch #866840: Make pager pluggable Going to mark this one back as fixed and if you can test the patch at that link that would help.

dtarc’s picture

The patch in #2 at #866840: Make pager pluggable fixed the problem. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.