Posted by jauzah on August 16, 2010 at 1:29pm
2 followers
Jump to:
| Project: | Coherent Access |
| Version: | 6.x-1.0 |
| Component: | Code |
| Category: | support request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | active |
Issue Summary
on several places in the module there is the following code:implode(',', array_fill(0, count($gids), '%d'))
the correct way to implode the $gids is the following one:implode(',', $gids)
Comments
#1
It looks like this code was written before the db_placeholders api function was developed.
I think the correct approach would be to use the api function :
db_placeholders($gids, 'int').IMHO This certainly is not a critical bug report - more of a coding preference.